AaronFiore/electrum
1
0
Fork 0
Code Activity
16,320 Commits 2 Branches 181 Tags
8dca907891da3a3fa9e1a3a78d107c403d1a721b
Commit Graph

16320 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
ThomasV
8dca907891 get_tx_parent: populate cache in chronological order 2023-04-26 18:29:46 +02:00
SomberNight
ad5f95cb87 util.profiler: add "min_threshold" arg 2023-04-26 14:49:37 +00:00
SomberNight
ee52154542 transaction: TxInput: store addr/spk/value_sats, instead of re-calc 
We were re-calculating txin.address from the prevtx-utxo on every call,
e.g. in electrum/gui/qt/utxo_list.py#L103 (for every utxo in the wallet).

For a wallet with ~1300 utxos, UTXOList.update() took ~3.2 sec before this,
now it's ~0.8 sec.
 2023-04-26 13:08:27 +00:00
SomberNight
312e50e9a9 qml: send screen: bip21: fallback to onchain addr if no LN channels 
given a bip21 uri that has both onchain addr and bolt11,
if we have LN enabled but no LN channels, auto-fallback to paying onchain

we will have to clean up and unify this logic between GUIs. becoming spaghetti :/
rumour has it, Thomas has a branch? :P
 2023-04-25 22:23:24 +00:00
SomberNight
5b122e723f follow-up prev: re-add some newlines 2023-04-25 18:19:19 +00:00
SomberNight
55140a9e27 gui/messages.py: allow localization of these strings 2023-04-25 17:54:07 +00:00
Sander van Grieken
663ea431f6 followup 61179ede8c 2023-04-25 14:22:19 +02:00
Sander van Grieken
a23457f48d qml: consistency camelcase pyqtProperties 2023-04-25 14:15:13 +02:00
Sander van Grieken
e26d49f11e qml: consistency camelcase public slots qetxdetails, qelnpaymentdetails, qechannelopener, qeaddressdetails 2023-04-25 13:46:30 +02:00
Sander van Grieken
264540e12b qml: consistency camelcase public slots qedaemon, qeinvoice, qewizard 2023-04-25 13:40:16 +02:00
Sander van Grieken
61179ede8c qml: consistency camelcase qewallet 2023-04-25 13:33:15 +02:00
Sander van Grieken
f0bbbe9955 qml: consistency camelcase public slots listmodels 2023-04-25 13:22:34 +02:00
Sander van Grieken
2b091b283a qml: qebitcoin remove unused code, fix scoping, camelcase 2023-04-25 13:04:09 +02:00
Sander van Grieken
96fd339a52 qml: followup 22fa84a0, use fixed font, use camelcase for QML properties 2023-04-25 12:46:30 +02:00
ghost43
664544886a Merge pull request #8318 from SomberNight/202304_qt_bumpfee 
qt bump fee: disallow targeting an abs fee. only allow setting feerate
 2023-04-24 16:56:53 +00:00
SomberNight
22fa84a0d5 qml: ReceiveDialog: clicking QR code to show encoded text 
closes https://github.com/spesmilo/electrum/issues/8331
 2023-04-24 16:53:20 +00:00
SomberNight
adf976fef4 qml: QERequestDetails: use uppercase in bolt11 QR code 
same trick as in other GUIs
 2023-04-24 16:21:26 +00:00
SomberNight
bf41675d4c qml: invoice/request list: flip sort order: newest on top 
to be consistent with the History, and with other GUIs

(the model is the easiest place to do it. QSortFilterProxyModel/etc looks overkill)
 2023-04-24 15:33:10 +00:00
Sander van Grieken
407769cb5f qml: remove Scan.qml 2023-04-24 17:32:13 +02:00
Sander van Grieken
5ead4feabb qml: wallet menu wider to fit wide translated texts 2023-04-24 17:24:22 +02:00
SomberNight
e097a3f875 CI: add some task dependencies 
run linter first, then tests, then binary builds
 2023-04-24 13:37:01 +00:00
ghost43
8ef395f4f3 Merge pull request #8337 from SomberNight/202304_flake8_bugbear 
CI: flake8-bugbear
 2023-04-24 13:27:54 +00:00
SomberNight
4cbb8399d2 CI: also run flake8-bugbear, as part of flake8 2023-04-24 13:00:12 +00:00
SomberNight
4219022c2e fix flake8-bugbear B023 
B023 Function definition does not bind loop variable 'already_selected_buckets_value_sum'

in keepkey/qt.py, looks like this was an actual bug
(fixed in trezor plugin already: 52a4810752 )
 2023-04-24 13:00:07 +00:00
SomberNight
612d3493df fix flake8-bugbear B017 
B017 `assertRaises(Exception)` and `pytest.raises(Exception)` should be considered evil. They can lead to your test passing even if the code being tested is never executed due to a typo. Assert for a more specific exception (builtin or custom), or use `assertRaisesRegex` (if using `assertRaises`), or add the `match` keyword argument (if using `pytest.raises`), or use the context manager form with a target.
 2023-04-24 12:58:30 +00:00
SomberNight
90315e72d6 fix flake8-bugbear B016 
B016 Cannot raise a literal. Did you intend to return it or raise an Exception?
 2023-04-24 12:58:26 +00:00
SomberNight
8266ebcc46 fix flake8-bugbear B008 
B008 Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
 2023-04-24 12:58:23 +00:00
SomberNight
e2406f21b4 fix flake8-bugbear B011 
B011 Do not call assert False since python -O removes these calls. Instead callers should raise AssertionError().
 2023-04-24 12:58:19 +00:00
SomberNight
312f2641e7 don't use bare except 
use "except Exception", or if really needed explicitly "except BaseException"
 2023-04-24 12:58:01 +00:00
Sander van Grieken
6848b8f375 qml: refactor all custom QRScan component wrappers to ScanDialog 
(except SendDialog, which has a Paste button and slightly different behavior)
 2023-04-24 13:34:05 +02:00
Sander van Grieken
49df18c613 qml: add hint property to QRScan 2023-04-24 13:19:40 +02:00
Sander van Grieken
959d481e93 qml: create ScanDialog 2023-04-24 13:19:01 +02:00
Sander van Grieken
674c2b55e7 qml: small fixes 2023-04-24 12:38:41 +02:00
Sander van Grieken
2fc9ee5c51 p4a: fix for Qt5 accessibility bug 
see 087fc3c583
 2023-04-24 11:29:26 +02:00
SomberNight
b429992e77 wizard.py: don't use mutable default args 2023-04-24 09:33:21 +02:00
SomberNight
e9aad6896e wizard.py: change stack to be per-instance 
seems less error-prone
 2023-04-24 09:33:21 +02:00
SomberNight
fd9a90f3b6 wizard.py: fix clearing stack between wizards 
try finishing a wizard and then launching a new one: the new one kept
building on top of the stack of the prev wizard
 2023-04-24 09:33:21 +02:00
SomberNight
417423ecd7 qt: PayToEdit: fix input_qr_from_camera 
closes https://github.com/spesmilo/electrum/issues/8342

probably regression from 1f4cedf56a
 2023-04-24 00:58:41 +00:00
SomberNight
a8623f63bb qml: fix send "flow with LN but not LN enabled AND having bip21 uri" 
closes https://github.com/spesmilo/electrum/issues/8334
 2023-04-23 16:42:08 +00:00
SomberNight
7907eb1f86 qml/qeinvoice.py: turn _bip21 field into local var 2023-04-23 16:36:32 +00:00
SomberNight
6b75d5f134 qt SwapDialog: handle sm.max_amount_forward_swap() being None 
closes https://github.com/spesmilo/electrum/issues/8341
 2023-04-23 16:13:03 +00:00
SomberNight
ea864cd5c9 qml: TxListModel: don't rely on wallet.db.get_transaction() finding tx 
tx might get removed from wallet after wallet.get_full_history() but before the model is populated

closes https://github.com/spesmilo/electrum/issues/8339
 2023-04-23 16:00:42 +00:00
SomberNight
1a2d4494eb qt: fix sweeping 
closes https://github.com/spesmilo/electrum/issues/8340

regression from 2f6d60c715
 2023-04-23 15:10:38 +00:00
SomberNight
ad58916729 wizard.py: (trivial) fix type hint and an f-string 2023-04-23 00:13:22 +00:00
SomberNight
6b0db411ae wallet: save_db immediately after init_lightning() generates keys 
Had a crash shortly after enabling lightning and the LN keys were lost...
Though note that opening a channel triggers wallet.save_db(), so I think
nothing of real value is at risk without this change.
 2023-04-23 00:06:45 +00:00
ThomasV
0fcf423fbe Revert "lnworker: schedule_force_closing is not async" 
This reverts commit fcf836bc94.
 2023-04-22 17:20:47 +02:00
ThomasV
fcf836bc94 lnworker: schedule_force_closing is not async 2023-04-22 15:03:39 +02:00
ThomasV
f787d6eede qt piechart: show a full circle if there is only one item in the list 2023-04-22 12:50:14 +02:00
Sander van Grieken
0d536b83ba qml: ignore update() when wallet not set yet. closes #8330 2023-04-22 12:18:02 +02:00
Sander van Grieken
7383cdc474 qml: don't crash when tx not found on histogram event. closes #8332 2023-04-22 11:40:36 +02:00