ThomasV
5f30f2a0c0
txbatcher: be careful when removing local transactions
...
1. Do not remove local transaction in find_base_tx.
This logic was intended to cleanup claim transactions that are
never broadcast (for example, if the counterparty gets a refund)
(see 1bf1de36cb )
However, this code is too unspecific and may result in fund loss,
because the transaction being removed may contain outgoing payments.
For example, if the electrum server is not responsive, the tx will
be seen as local and deleted. In that case, another payment will
be attempted, thus paying twice.
2. Do not remove tx after try_broadcasting returns False.
The server might be lying to us. We can only remove the local tx
if there is a base_tx, because the next tx we create will try to
spend the same output.
2025-08-21 10:26:35 +02:00
ghost43
e85a3f2d3f
Merge pull request #10157 from SomberNight/202508_swap_sanity_check_costs
...
swaps: add sanity-check for total swap costs
2025-08-20 18:05:13 +00:00
ghost43
7e743b7998
Merge pull request #10156 from f321x/improve_reverse_swap_mining_fee
...
swaps: add sanity check to reverse swap mining fee
2025-08-20 16:22:54 +00:00
SomberNight
2f1e373077
commands: reverse_swap: don't require provider_mining_fee in dryrun
2025-08-20 16:20:52 +00:00
f321x
71c71a96f3
swaps: add sanity check to reverse swap mining fee
2025-08-20 17:57:36 +02:00
SomberNight
bb39ca5595
swaps: add sanity-check for total swap costs
2025-08-20 15:13:25 +00:00
ghost43
a29125f5c5
Merge pull request #10153 from SomberNight/202508_lnpeer_rate_limits
...
lnpeer: add some rate-limits
2025-08-20 12:28:50 +00:00
ThomasV
5553d5aa86
Merge pull request #10152 from SomberNight/202508_swaps_dm_replies
...
swaps: nostr: add sanity checks for replies
2025-08-20 12:37:41 +02:00
ThomasV
dad6d51e85
Merge pull request #10155 from f321x/swap_prepayment_fix
...
swaps: improve prepayment invoice handling
2025-08-20 12:35:42 +02:00
f321x
04b0aca878
swaps: improve prepayment invoice handling
2025-08-20 12:04:44 +02:00
SomberNight
df96f87ed7
lnworker: limit max number of incoming channel-less peers
2025-08-19 18:28:16 +00:00
SomberNight
1380ed4ba7
lnpeer: rate-limit ordered_message_queues
2025-08-19 18:28:13 +00:00
SomberNight
b8d989e13b
lnpeer: rate-limit reply_channel_range
2025-08-19 18:28:09 +00:00
SomberNight
65d04dfbb7
lnpeer: slow down peers sending too much gossip
2025-08-19 18:28:01 +00:00
SomberNight
93e0e8a7b8
swaps: nostr: add sanity checks for replies
2025-08-19 16:38:27 +00:00
ghost43
da9b921f57
Merge pull request #10151 from spesmilo/dm_replies_no_defaultdict
...
submarine_swaps: use dict instead of defaultdict for dm_replies
2025-08-19 16:04:28 +00:00
ThomasV
eae6ddd773
submarine_swaps: use dict instead of defaultdict for dm_replies
2025-08-19 17:54:25 +02:00
ghost43
fc3aa2e8ee
Merge pull request #10150 from SomberNight/202508_swaps_parsing
...
swaps: more robust parsing
2025-08-19 14:35:57 +00:00
SomberNight
81be0554a3
swaps: more robust parsing
2025-08-19 13:42:21 +00:00
ghost43
5b8569e814
Merge pull request #10149 from f321x/improve_swaps_send_dm
...
swaps: make NostrTransport.send_direct_message() more robust
2025-08-19 13:35:47 +00:00
f321x
37614e9092
swaps: handle timeouts in send_direct_message
...
Adds logic to retry sending a direct message in
`NostrTransport.send_direct_message()` on `TimeoutError`.
Handles `TimeoutError` exception more gracefully by catching it and
returning `None`.
2025-08-19 15:29:58 +02:00
Sander van Grieken
e90534beaa
fee_policy: use FEERATE_PRECISION for .. precision
2025-08-19 14:16:32 +02:00
ThomasV
6ffaa55813
lnwatcher: early return in sweep_commitment_transaction if chan.need_to_subscribe returns False
2025-08-19 14:06:22 +02:00
SomberNight
74d2c6386a
wallet: sweep_preparations to raise UserFacingException on p2sh/etc
...
closes https://github.com/spesmilo/electrum/issues/10145
2025-08-18 17:02:34 +00:00
ghost43
e7c8377808
Merge pull request #10128 from f321x/fix_4111
...
fix: psbt_nostr: don't save tx without txid
2025-08-18 16:30:16 +00:00
ghost43
f68bea0b59
Merge pull request #10147 from SomberNight/202508_typehint_callables
...
type-hint some Callables
2025-08-18 16:12:36 +00:00
SomberNight
f8926b4957
type-hint some Callables
...
could not figure out how to type-hint coinchooser.sufficient_funds with typing.Protocol,
at least PyCharm complained on all my attempts
2025-08-18 15:38:25 +00:00
ghost43
0c6ff6ab62
Merge pull request #10122 from accumulator/qml_invoice_validation_error
...
qml: handle invoice validation errors on save
2025-08-18 14:32:57 +00:00
ghost43
8feaa4bb66
Merge pull request #10141 from SomberNight/202508_kswizard_multisig
...
wizard: enable_keystore: fix for multisig
2025-08-18 14:27:45 +00:00
ghost43
784a517a4b
Merge pull request #10146 from f321x/fix_10144
...
qt: invoice_list: only show invoice if it is not None
2025-08-18 14:26:18 +00:00
f321x
9fcf5f1581
qt: invoice_list: only show invoice if it is not None
...
Check if the invoice is not None when the user tries to open the
invoice details to prevent an Exception, update the list instead if the
invoice hasn't been found.
It can happen that the user deletes the invoice through the CLI
and then tries to open the details in the gui, which hasn't been
updated, at the same time.
Fixes #10144
2025-08-18 11:02:22 +02:00
f321x
a68bfab596
swaps: improve preimage extraction logic
2025-08-18 10:03:24 +02:00
ghost43
4c6d8166a4
Merge pull request #10143 from SomberNight/202508_fix_old_keystore_check_password
...
keystore: Old_KeyStore: fix check_password(None) if ks has password
2025-08-17 00:22:30 +00:00
SomberNight
2318cf7369
keystore: Old_KeyStore: fix check_password(None) if ks has password
...
check_password(None) should raise InvalidPassword when called on a keystore that has a password.
regression from f86bdc86a2
fixes https://github.com/spesmilo/electrum/issues/10142
2025-08-16 18:08:10 +00:00
SomberNight
dc999aa948
wizard: enable_keystore: fix for multisig
...
regression from 66c0fec1ea
2025-08-15 20:52:49 +00:00
SomberNight
14494c13dc
qt wizard: start: merge "start_viewstate" and "initial_data"
2025-08-15 20:46:24 +00:00
SomberNight
43987c5ca0
wizard: make start() kwarg-only
...
I want to see where initial_data arg is actually set from.
Looks like hardly anywhere(?)
It is really hard to see because the wizard is crazy-dynamic, there's polymorphism and mixins everywhere.
2025-08-15 20:35:29 +00:00
SomberNight
392400295e
wallet.get_tx_fee_warning: fix rounding error for sub-1 sat/vbyte fees
...
```
>>> Decimal("0.1") < 100/1000
True
```
ref https://bitcointalk.org/index.php?topic=5554840.msg65694417#msg65694417
2025-08-15 18:26:19 +00:00
ghost43
8a8ab26d44
Merge pull request #10140 from SomberNight/202508_test_keystore_wizard
...
wallet: enable/disable_keystore: some more fixes and tests
2025-08-15 18:16:38 +00:00
SomberNight
5997494c46
tests: wizard: add test "adding unrelated seed to xpub-only ks raises"
2025-08-15 17:39:57 +00:00
SomberNight
cd63be233b
wallet: disable_keystore() not to destroy get_key_origin_info()
2025-08-15 17:29:55 +00:00
SomberNight
f025a75356
tests: wizard: use real bip39 seeds
2025-08-15 17:19:22 +00:00
SomberNight
0ceb54b61f
wallet: enable/disable_keystore: rm functionality from 2fa wallets
...
was already not working, but does not even really make sense without larger changes
2025-08-15 16:18:13 +00:00
ghost43
1ae3d0a0bf
Merge pull request #10131 from SomberNight/202508_commands_onchain_history
...
commands: add back from_height/to_height params to onchain_history
2025-08-15 13:36:25 +00:00
Sander van Grieken
bd6dfc53a2
qml: avoid hue wrap-around for fees < 1sat/vbyte, limit precision.
2025-08-15 11:35:33 +02:00
Sander van Grieken
b4ffd3eeeb
qt: contacts: stretch address, not name
2025-08-15 10:44:31 +02:00
ghost43
5a9f54fba0
Merge pull request #10133 from f321x/qml_timestamp_precision
...
qml: reduce tx history timestamp precision
2025-08-14 17:26:08 +00:00
SomberNight
0fea61ac3a
tests: wizard: KeystoreWizard: also test disable_keystore()
2025-08-14 17:06:52 +00:00
SomberNight
6554ec674e
tests: wizard: KeystoreWizard: add test case for old seed
2025-08-14 16:44:57 +00:00
SomberNight
e3d1c6aefd
wallet: enable/disable_keystore: trivial clean-up
2025-08-14 16:16:31 +00:00