AaronFiore/electrum
1
0
Fork 0
Code Activity

wizard: make start() kwarg-only

Browse Source 
I want to see where initial_data arg is actually set from.
Looks like hardly anywhere(?)
It is really hard to see because the wizard is crazy-dynamic, there's polymorphism and mixins everywhere.
This commit is contained in:
SomberNight
2025-08-15 20:35:29 +00:00
parent 392400295e
commit 43987c5ca0
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
electrum/wizard.py
View File

@@ -257,7 +257,7 @@ class KeystoreWizard(AbstractWizard):
# one at a time
return True
def start(self, initial_data: dict = None) -> WizardViewState:
def start(self, *, initial_data: dict = None) -> WizardViewState:
if initial_data is None:
initial_data = {}
self.reset()
@@ -487,7 +487,7 @@ class NewWalletWizard(KeystoreWizard):
# todo: load only if needed, like hw plugins
self.plugins.load_plugin_by_name('trustedcoin')
def start(self, initial_data: dict = None) -> WizardViewState:
def start(self, *, initial_data: dict = None) -> WizardViewState:
if initial_data is None:
initial_data = {}
self.reset()
@@ -861,7 +861,7 @@ class ServerConnectWizard(AbstractWizard):
if wizard_data.get('autoconnect') is not None:
self._daemon.config.NETWORK_AUTO_CONNECT = wizard_data.get('autoconnect')
def start(self, initial_data: dict = None) -> WizardViewState:
def start(self, *, initial_data: dict = None) -> WizardViewState:
if initial_data is None:
initial_data = {}
self.reset()
@@ -888,7 +888,7 @@ class TermsOfUseWizard(AbstractWizard):
def accept_terms_of_use(self, _):
self._config.TERMS_OF_USE_ACCEPTED = TERMS_OF_USE_LATEST_VERSION
def start(self, initial_data: dict = None) -> WizardViewState:
def start(self, *, initial_data: dict = None) -> WizardViewState:
if initial_data is None:
initial_data = {}
self.reset()

2
tests/test_wizard.py
View File

@@ -140,7 +140,7 @@ class KeystoreWizardTestCase(WizardTestCase):
def _wizard_for(self, *, wallet_type: str = 'standard', hww: bool = False) -> tuple[KeystoreWizard, WizardViewState]:
w = KeystoreWizardTestCase.TKeystoreWizard(self.plugins)
v = w.start({'wallet_type': wallet_type})
v = w.start(initial_data={'wallet_type': wallet_type})
self.assertEqual('keystore_type', v.view)
d = v.wizard_data
if hww: