From 43987c5ca0c9344ffc1be75a10ea78e19df692fa Mon Sep 17 00:00:00 2001 From: SomberNight Date: Fri, 15 Aug 2025 20:35:29 +0000 Subject: [PATCH] wizard: make start() kwarg-only I want to see where initial_data arg is actually set from. Looks like hardly anywhere(?) It is really hard to see because the wizard is crazy-dynamic, there's polymorphism and mixins everywhere. --- electrum/wizard.py | 8 ++++---- tests/test_wizard.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/electrum/wizard.py b/electrum/wizard.py index ae624a16b..34aea668a 100644 --- a/electrum/wizard.py +++ b/electrum/wizard.py @@ -257,7 +257,7 @@ class KeystoreWizard(AbstractWizard): # one at a time return True - def start(self, initial_data: dict = None) -> WizardViewState: + def start(self, *, initial_data: dict = None) -> WizardViewState: if initial_data is None: initial_data = {} self.reset() @@ -487,7 +487,7 @@ class NewWalletWizard(KeystoreWizard): # todo: load only if needed, like hw plugins self.plugins.load_plugin_by_name('trustedcoin') - def start(self, initial_data: dict = None) -> WizardViewState: + def start(self, *, initial_data: dict = None) -> WizardViewState: if initial_data is None: initial_data = {} self.reset() @@ -861,7 +861,7 @@ class ServerConnectWizard(AbstractWizard): if wizard_data.get('autoconnect') is not None: self._daemon.config.NETWORK_AUTO_CONNECT = wizard_data.get('autoconnect') - def start(self, initial_data: dict = None) -> WizardViewState: + def start(self, *, initial_data: dict = None) -> WizardViewState: if initial_data is None: initial_data = {} self.reset() @@ -888,7 +888,7 @@ class TermsOfUseWizard(AbstractWizard): def accept_terms_of_use(self, _): self._config.TERMS_OF_USE_ACCEPTED = TERMS_OF_USE_LATEST_VERSION - def start(self, initial_data: dict = None) -> WizardViewState: + def start(self, *, initial_data: dict = None) -> WizardViewState: if initial_data is None: initial_data = {} self.reset() diff --git a/tests/test_wizard.py b/tests/test_wizard.py index dbe54f794..068e91512 100644 --- a/tests/test_wizard.py +++ b/tests/test_wizard.py @@ -140,7 +140,7 @@ class KeystoreWizardTestCase(WizardTestCase): def _wizard_for(self, *, wallet_type: str = 'standard', hww: bool = False) -> tuple[KeystoreWizard, WizardViewState]: w = KeystoreWizardTestCase.TKeystoreWizard(self.plugins) - v = w.start({'wallet_type': wallet_type}) + v = w.start(initial_data={'wallet_type': wallet_type}) self.assertEqual('keystore_type', v.view) d = v.wizard_data if hww: