Merge pull request #169 into master

5053990 README: remove bittrex (fetch support) (Aaron Fiore)
9034346 container: fetch: remove bittrex (Aaron Fiore)
c7ba59c container: lib_fetch: remove bittrex (Aaron Fiore)
44560d7 README: remove coinbase-pro (fetch support) (Aaron Fiore)
0e0ae15 client: docker-finance.d: fetch: remove coinbase-pro (Aaron Fiore)
6704b3e client: Dockerfiles: local: finance: remove coinbase-pro (Aaron Fiore)
f7cf8ca container: fetch: remove coinbase-pro (Aaron Fiore)
ae3caef container: lib_fetch: remove coinbase-pro (Aaron Fiore)
58e860d container: fetch: remove celsius (Aaron Fiore)
d8a1b4c container: lib_fetch: remove celsius (Aaron Fiore)

README.md

@@ -155,17 +155,17 @@ However, for accounts that require fetch/import functionality, only the followin
 
 #### Available but requires community maintenance
 
-- [X] [Bittrex](https://bittrex.com/) *(non-US)*
 - [X] [Changelly](https://changelly.com/)
-- [X] [Coinbase Pro](https://pro.coinbase.com/) *("Sunsetted")*
 - [X] [Kraken](https://kraken.com/) *(non-WA)*
 - [X] [Lofty.ai](https://lofty.ai/)
 - [X] [Nexo](https://nexo.com/) *(non-US)*
 
 #### Available but no longer maintained
 
+- [X] Bittrex *(bankrupt [US] / wind down [Global])*
 - [X] BlockFi *(bankrupt)*
 - [X] Celsius Network *(bankrupt)*
+- [X] Coinbase Pro *("sunsetted")*
 
 ### DeFi
 

client/Dockerfiles/local/finance/archlinux/Dockerfile.fetch.in

@@ -40,7 +40,5 @@ WORKDIR /usr/local/lib/php
 
 RUN composer require -n ozdemirburak/json-csv
 RUN composer require -n ccxt/ccxt
-# "Sunsetted" Coinbase Pro
-#RUN composer require mocking-magician/coinbase-pro-sdk
 
 # vim: sw=2 sts=2 si ai et

client/Dockerfiles/local/finance/ubuntu/Dockerfile.fetch.in

@@ -38,7 +38,5 @@ WORKDIR /usr/local/lib/php
 
 RUN composer require ozdemirburak/json-csv
 RUN composer require ccxt/ccxt
-# "Sunsetted" Coinbase Pro
-#RUN composer require mocking-magician/coinbase-pro-sdk
 
 # vim: sw=2 sts=2 si ai et

client/docker-finance.d/container/fetch/fetch.yaml.in

@@ -175,12 +175,6 @@ version: @DOCKER_FINANCE_VERSION@
         #   - https://docs.cdp.coinbase.com/sign-in-with-coinbase/docs/api-currencies
         #subaccount: "platform/{BTC,LTC,ETH,USDC,USD}"
 
-      coinbase-pro:
-        key: "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"
-        passphrase: "XXXXXXXXXXX"
-        secret: "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX=="
-        subaccount: "exchange"
-
       coinbase-wallet:
         # API scanner keys can be generated at etherscan.io, polygonscan.com
         # key format: blockchain1/API_KEY1,blockchain2/API_KEY2

container/src/finance/lib/internal/fetch/exchanges/fetch.php

@@ -28,9 +28,6 @@
 namespace docker_finance\exchanges
 {
     require_once('exchanges/internal/base.php');
-    require_once('exchanges/internal/exchanges/archive/bittrex.php');
-    require_once('exchanges/internal/exchanges/archive/celsius.php');
-    require_once('exchanges/internal/exchanges/archive/coinbase-pro.php');
     require_once('exchanges/internal/exchanges/coinbase.php');
     require_once('exchanges/internal/exchanges/gemini.php');
     require_once('utils/utils.php');
@@ -70,18 +67,9 @@ namespace docker_finance\exchanges
                 case 'coinbase':
                     $this->api = new internal\exchanges\Coinbase($this->get_env());
                     break;
-                case 'coinbase-pro':
-                    $this->api = new internal\exchanges\CoinbasePro($this->get_env());
-                    break;
                 case 'gemini':
                     $this->api = new internal\exchanges\Gemini($this->get_env());
                     break;
-                case 'bittrex':
-                    $this->api = new internal\exchanges\Bittrex($this->get_env());
-                    break;
-                case 'celsius':
-                    $this->api = new internal\exchanges\Celsius($this->get_env());
-                    break;
                 default:
                     utils\CLI::throw_fatal("unsupported subtype '$subtype' for interal API");
                     break;

container/src/finance/lib/internal/fetch/fetch.php

@@ -87,10 +87,7 @@ namespace docker_finance
         switch ($type) {
             case 'account':
                 switch ($subtype) {
-                    case 'bittrex':
-                    case 'celsius':
                     case 'coinbase':
-                    case 'coinbase-pro':
                     case 'gemini':
                         $api = new exchanges\Fetch($env);
                         break;

container/src/finance/lib/internal/lib_fetch.bash

@@ -69,7 +69,7 @@ function lib_fetch::__parse_args()
 
   Support account(s):
 
-    account${global_arg_delim_2}<bittrex|celsius|coinbase|coinbase-pro|coinbase-wallet|coinomi|gemini|ledger|metamask|pera-wallet>
+    account${global_arg_delim_2}<coinbase|coinbase-wallet|coinomi|gemini|ledger|metamask|pera-wallet>
 
   Fetch year:
 
@@ -357,10 +357,7 @@ function lib_fetch::__fetch()
 {
   # Supported remote fetch accounts
   local -r _supported_accounts=(
-    "bittrex"
-    "celsius"
     "coinbase"
-    "coinbase-pro"
     "coinbase-wallet"
     "coinomi"
     "gemini"
@@ -427,15 +424,10 @@ function lib_fetch::__fetch_account()
     local _need_secret=false
 
     case "$_account" in
-      bittrex | celsius | coinbase | gemini)
+      coinbase | gemini)
         _need_key=true
         _need_secret=true
         ;;
-      coinbase-pro)
-        _need_key=true
-        _need_secret=true
-        _need_passphrase=true
-        ;;
     esac
 
     #