From d8a1b4cff11f9f5e4a283af86afc6a3534ac2e46 Mon Sep 17 00:00:00 2001 From: Aaron Fiore Date: Sat, 4 Jan 2025 00:34:11 -0800 Subject: [PATCH 01/10] container: lib_fetch: remove celsius --- container/src/finance/lib/internal/lib_fetch.bash | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/container/src/finance/lib/internal/lib_fetch.bash b/container/src/finance/lib/internal/lib_fetch.bash index d0ed4f7..cfe81fb 100644 --- a/container/src/finance/lib/internal/lib_fetch.bash +++ b/container/src/finance/lib/internal/lib_fetch.bash @@ -69,7 +69,7 @@ function lib_fetch::__parse_args() Support account(s): - account${global_arg_delim_2} + account${global_arg_delim_2} Fetch year: @@ -358,7 +358,6 @@ function lib_fetch::__fetch() # Supported remote fetch accounts local -r _supported_accounts=( "bittrex" - "celsius" "coinbase" "coinbase-pro" "coinbase-wallet" @@ -427,7 +426,7 @@ function lib_fetch::__fetch_account() local _need_secret=false case "$_account" in - bittrex | celsius | coinbase | gemini) + bittrex | coinbase | gemini) _need_key=true _need_secret=true ;; From 58e860dd948b8fd1d52bd7454f18fd4383de5eb8 Mon Sep 17 00:00:00 2001 From: Aaron Fiore Date: Sat, 4 Jan 2025 00:35:22 -0800 Subject: [PATCH 02/10] container: fetch: remove celsius --- container/src/finance/lib/internal/fetch/exchanges/fetch.php | 4 ---- container/src/finance/lib/internal/fetch/fetch.php | 1 - 2 files changed, 5 deletions(-) diff --git a/container/src/finance/lib/internal/fetch/exchanges/fetch.php b/container/src/finance/lib/internal/fetch/exchanges/fetch.php index 14f2274..71b5ec2 100644 --- a/container/src/finance/lib/internal/fetch/exchanges/fetch.php +++ b/container/src/finance/lib/internal/fetch/exchanges/fetch.php @@ -29,7 +29,6 @@ namespace docker_finance\exchanges { require_once('exchanges/internal/base.php'); require_once('exchanges/internal/exchanges/archive/bittrex.php'); - require_once('exchanges/internal/exchanges/archive/celsius.php'); require_once('exchanges/internal/exchanges/archive/coinbase-pro.php'); require_once('exchanges/internal/exchanges/coinbase.php'); require_once('exchanges/internal/exchanges/gemini.php'); @@ -79,9 +78,6 @@ namespace docker_finance\exchanges case 'bittrex': $this->api = new internal\exchanges\Bittrex($this->get_env()); break; - case 'celsius': - $this->api = new internal\exchanges\Celsius($this->get_env()); - break; default: utils\CLI::throw_fatal("unsupported subtype '$subtype' for interal API"); break; diff --git a/container/src/finance/lib/internal/fetch/fetch.php b/container/src/finance/lib/internal/fetch/fetch.php index 5205335..acb6d1b 100644 --- a/container/src/finance/lib/internal/fetch/fetch.php +++ b/container/src/finance/lib/internal/fetch/fetch.php @@ -88,7 +88,6 @@ namespace docker_finance case 'account': switch ($subtype) { case 'bittrex': - case 'celsius': case 'coinbase': case 'coinbase-pro': case 'gemini': From ae3caef11015f486a6b8046839265eb9464d1d7d Mon Sep 17 00:00:00 2001 From: Aaron Fiore Date: Sat, 4 Jan 2025 00:41:44 -0800 Subject: [PATCH 03/10] container: lib_fetch: remove coinbase-pro --- container/src/finance/lib/internal/lib_fetch.bash | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/container/src/finance/lib/internal/lib_fetch.bash b/container/src/finance/lib/internal/lib_fetch.bash index cfe81fb..680b38c 100644 --- a/container/src/finance/lib/internal/lib_fetch.bash +++ b/container/src/finance/lib/internal/lib_fetch.bash @@ -69,7 +69,7 @@ function lib_fetch::__parse_args() Support account(s): - account${global_arg_delim_2} + account${global_arg_delim_2} Fetch year: @@ -359,7 +359,6 @@ function lib_fetch::__fetch() local -r _supported_accounts=( "bittrex" "coinbase" - "coinbase-pro" "coinbase-wallet" "coinomi" "gemini" @@ -430,11 +429,6 @@ function lib_fetch::__fetch_account() _need_key=true _need_secret=true ;; - coinbase-pro) - _need_key=true - _need_secret=true - _need_passphrase=true - ;; esac # From f7cf8ca96021ca3398fbe1d28a949c7106613e98 Mon Sep 17 00:00:00 2001 From: Aaron Fiore Date: Sat, 4 Jan 2025 00:42:49 -0800 Subject: [PATCH 04/10] container: fetch: remove coinbase-pro --- container/src/finance/lib/internal/fetch/exchanges/fetch.php | 4 ---- container/src/finance/lib/internal/fetch/fetch.php | 1 - 2 files changed, 5 deletions(-) diff --git a/container/src/finance/lib/internal/fetch/exchanges/fetch.php b/container/src/finance/lib/internal/fetch/exchanges/fetch.php index 71b5ec2..d26327b 100644 --- a/container/src/finance/lib/internal/fetch/exchanges/fetch.php +++ b/container/src/finance/lib/internal/fetch/exchanges/fetch.php @@ -29,7 +29,6 @@ namespace docker_finance\exchanges { require_once('exchanges/internal/base.php'); require_once('exchanges/internal/exchanges/archive/bittrex.php'); - require_once('exchanges/internal/exchanges/archive/coinbase-pro.php'); require_once('exchanges/internal/exchanges/coinbase.php'); require_once('exchanges/internal/exchanges/gemini.php'); require_once('utils/utils.php'); @@ -69,9 +68,6 @@ namespace docker_finance\exchanges case 'coinbase': $this->api = new internal\exchanges\Coinbase($this->get_env()); break; - case 'coinbase-pro': - $this->api = new internal\exchanges\CoinbasePro($this->get_env()); - break; case 'gemini': $this->api = new internal\exchanges\Gemini($this->get_env()); break; diff --git a/container/src/finance/lib/internal/fetch/fetch.php b/container/src/finance/lib/internal/fetch/fetch.php index acb6d1b..2cb2765 100644 --- a/container/src/finance/lib/internal/fetch/fetch.php +++ b/container/src/finance/lib/internal/fetch/fetch.php @@ -89,7 +89,6 @@ namespace docker_finance switch ($subtype) { case 'bittrex': case 'coinbase': - case 'coinbase-pro': case 'gemini': $api = new exchanges\Fetch($env); break; From 6704b3ec2104816487c73e50aecd0f5210715428 Mon Sep 17 00:00:00 2001 From: Aaron Fiore Date: Sat, 4 Jan 2025 00:44:42 -0800 Subject: [PATCH 05/10] client: Dockerfiles: local: finance: remove coinbase-pro --- client/Dockerfiles/local/finance/archlinux/Dockerfile.fetch.in | 2 -- client/Dockerfiles/local/finance/ubuntu/Dockerfile.fetch.in | 2 -- 2 files changed, 4 deletions(-) diff --git a/client/Dockerfiles/local/finance/archlinux/Dockerfile.fetch.in b/client/Dockerfiles/local/finance/archlinux/Dockerfile.fetch.in index 3527e05..ca8962d 100644 --- a/client/Dockerfiles/local/finance/archlinux/Dockerfile.fetch.in +++ b/client/Dockerfiles/local/finance/archlinux/Dockerfile.fetch.in @@ -40,7 +40,5 @@ WORKDIR /usr/local/lib/php RUN composer require -n ozdemirburak/json-csv RUN composer require -n ccxt/ccxt -# "Sunsetted" Coinbase Pro -#RUN composer require mocking-magician/coinbase-pro-sdk # vim: sw=2 sts=2 si ai et diff --git a/client/Dockerfiles/local/finance/ubuntu/Dockerfile.fetch.in b/client/Dockerfiles/local/finance/ubuntu/Dockerfile.fetch.in index 4fda03b..cf53ba0 100644 --- a/client/Dockerfiles/local/finance/ubuntu/Dockerfile.fetch.in +++ b/client/Dockerfiles/local/finance/ubuntu/Dockerfile.fetch.in @@ -38,7 +38,5 @@ WORKDIR /usr/local/lib/php RUN composer require ozdemirburak/json-csv RUN composer require ccxt/ccxt -# "Sunsetted" Coinbase Pro -#RUN composer require mocking-magician/coinbase-pro-sdk # vim: sw=2 sts=2 si ai et From 0e0ae15adbb54c2d094caad5c7456516534846e4 Mon Sep 17 00:00:00 2001 From: Aaron Fiore Date: Sat, 4 Jan 2025 00:45:53 -0800 Subject: [PATCH 06/10] client: docker-finance.d: fetch: remove coinbase-pro --- client/docker-finance.d/container/fetch/fetch.yaml.in | 6 ------ 1 file changed, 6 deletions(-) diff --git a/client/docker-finance.d/container/fetch/fetch.yaml.in b/client/docker-finance.d/container/fetch/fetch.yaml.in index d6561ba..5c04bc7 100644 --- a/client/docker-finance.d/container/fetch/fetch.yaml.in +++ b/client/docker-finance.d/container/fetch/fetch.yaml.in @@ -175,12 +175,6 @@ version: @DOCKER_FINANCE_VERSION@ # - https://docs.cdp.coinbase.com/sign-in-with-coinbase/docs/api-currencies #subaccount: "platform/{BTC,LTC,ETH,USDC,USD}" - coinbase-pro: - key: "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX" - passphrase: "XXXXXXXXXXX" - secret: "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX==" - subaccount: "exchange" - coinbase-wallet: # API scanner keys can be generated at etherscan.io, polygonscan.com # key format: blockchain1/API_KEY1,blockchain2/API_KEY2 From 44560d7ec15b7cbec3054d86b74d5baf7a972aee Mon Sep 17 00:00:00 2001 From: Aaron Fiore Date: Sat, 4 Jan 2025 00:47:03 -0800 Subject: [PATCH 07/10] README: remove coinbase-pro (fetch support) NOTE: hledger-flow is still available for old accounts. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 44ee24d..a6a3932 100644 --- a/README.md +++ b/README.md @@ -157,7 +157,6 @@ However, for accounts that require fetch/import functionality, only the followin - [X] [Bittrex](https://bittrex.com/) *(non-US)* - [X] [Changelly](https://changelly.com/) -- [X] [Coinbase Pro](https://pro.coinbase.com/) *("Sunsetted")* - [X] [Kraken](https://kraken.com/) *(non-WA)* - [X] [Lofty.ai](https://lofty.ai/) - [X] [Nexo](https://nexo.com/) *(non-US)* @@ -166,6 +165,7 @@ However, for accounts that require fetch/import functionality, only the followin - [X] BlockFi *(bankrupt)* - [X] Celsius Network *(bankrupt)* +- [X] Coinbase Pro *("sunsetted")* ### DeFi From c7ba59cfa16d526ce7ea4e0797fe71c885ba782a Mon Sep 17 00:00:00 2001 From: Aaron Fiore Date: Sat, 4 Jan 2025 01:08:02 -0800 Subject: [PATCH 08/10] container: lib_fetch: remove bittrex --- container/src/finance/lib/internal/lib_fetch.bash | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/container/src/finance/lib/internal/lib_fetch.bash b/container/src/finance/lib/internal/lib_fetch.bash index 680b38c..901c13a 100644 --- a/container/src/finance/lib/internal/lib_fetch.bash +++ b/container/src/finance/lib/internal/lib_fetch.bash @@ -69,7 +69,7 @@ function lib_fetch::__parse_args() Support account(s): - account${global_arg_delim_2} + account${global_arg_delim_2} Fetch year: @@ -357,7 +357,6 @@ function lib_fetch::__fetch() { # Supported remote fetch accounts local -r _supported_accounts=( - "bittrex" "coinbase" "coinbase-wallet" "coinomi" @@ -425,7 +424,7 @@ function lib_fetch::__fetch_account() local _need_secret=false case "$_account" in - bittrex | coinbase | gemini) + coinbase | gemini) _need_key=true _need_secret=true ;; From 9034346426b10115f1c02aebf2b185ba014b50aa Mon Sep 17 00:00:00 2001 From: Aaron Fiore Date: Sat, 4 Jan 2025 01:08:46 -0800 Subject: [PATCH 09/10] container: fetch: remove bittrex --- container/src/finance/lib/internal/fetch/exchanges/fetch.php | 4 ---- container/src/finance/lib/internal/fetch/fetch.php | 1 - 2 files changed, 5 deletions(-) diff --git a/container/src/finance/lib/internal/fetch/exchanges/fetch.php b/container/src/finance/lib/internal/fetch/exchanges/fetch.php index d26327b..76a9c15 100644 --- a/container/src/finance/lib/internal/fetch/exchanges/fetch.php +++ b/container/src/finance/lib/internal/fetch/exchanges/fetch.php @@ -28,7 +28,6 @@ namespace docker_finance\exchanges { require_once('exchanges/internal/base.php'); - require_once('exchanges/internal/exchanges/archive/bittrex.php'); require_once('exchanges/internal/exchanges/coinbase.php'); require_once('exchanges/internal/exchanges/gemini.php'); require_once('utils/utils.php'); @@ -71,9 +70,6 @@ namespace docker_finance\exchanges case 'gemini': $this->api = new internal\exchanges\Gemini($this->get_env()); break; - case 'bittrex': - $this->api = new internal\exchanges\Bittrex($this->get_env()); - break; default: utils\CLI::throw_fatal("unsupported subtype '$subtype' for interal API"); break; diff --git a/container/src/finance/lib/internal/fetch/fetch.php b/container/src/finance/lib/internal/fetch/fetch.php index 2cb2765..16637ed 100644 --- a/container/src/finance/lib/internal/fetch/fetch.php +++ b/container/src/finance/lib/internal/fetch/fetch.php @@ -87,7 +87,6 @@ namespace docker_finance switch ($type) { case 'account': switch ($subtype) { - case 'bittrex': case 'coinbase': case 'gemini': $api = new exchanges\Fetch($env); From 5053990d34913e27f79948c653a6893fe4352592 Mon Sep 17 00:00:00 2001 From: Aaron Fiore Date: Sat, 4 Jan 2025 01:12:17 -0800 Subject: [PATCH 10/10] README: remove bittrex (fetch support) NOTE: hledger-flow is still available for old accounts. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a6a3932..eb2efa1 100644 --- a/README.md +++ b/README.md @@ -155,7 +155,6 @@ However, for accounts that require fetch/import functionality, only the followin #### Available but requires community maintenance -- [X] [Bittrex](https://bittrex.com/) *(non-US)* - [X] [Changelly](https://changelly.com/) - [X] [Kraken](https://kraken.com/) *(non-WA)* - [X] [Lofty.ai](https://lofty.ai/) @@ -163,6 +162,7 @@ However, for accounts that require fetch/import functionality, only the followin #### Available but no longer maintained +- [X] Bittrex *(bankrupt [US] / wind down [Global])* - [X] BlockFi *(bankrupt)* - [X] Celsius Network *(bankrupt)* - [X] Coinbase Pro *("sunsetted")*