Coinbase: fix '401 Authentication' error, full migration to ccxt #75

Merged
AaronFiore merged 0 commits from refs/pull/75/head into master 2024-07-04 02:11:12 +00:00
AaronFiore commented 2024-07-03 08:53:26 +00:00 (Migrated from gitea.com)

Description

Regarding #74, from git-log:

A recent combination of Coinbase and ccxt changes will now result in
authentication errors (server error 401) because of docker-finance's
coinbase implementation (specifically, direct calls to internal ccxt).

docker-finance's previous usage of request() meant hooking into the
underlying ccxt API and not the end-user public-facing API (publicly
documented - not necessarily the "public" vs "private" APIs provided by
exchanges, as seen in ccxt documentation).

This direct usage of request() was obviously never recommended but it
was always easier to interact with to get to the underlying raw object
(at least at the time of original docker-finance coinbase writing).

Since it appears that ccxt has refactored the authentication mechanism
related to request(), this commit also refactors in order to provide a
working fix for authentication.

Fixes #74

Agreement

### Description Regarding #74, from git-log: ``` A recent combination of Coinbase and ccxt changes will now result in authentication errors (server error 401) because of docker-finance's coinbase implementation (specifically, direct calls to internal ccxt). docker-finance's previous usage of request() meant hooking into the underlying ccxt API and not the end-user public-facing API (publicly documented - not necessarily the "public" vs "private" APIs provided by exchanges, as seen in ccxt documentation). This direct usage of request() was obviously never recommended but it was always easier to interact with to get to the underlying raw object (at least at the time of original docker-finance coinbase writing). Since it appears that ccxt has refactored the authentication mechanism related to request(), this commit also refactors in order to provide a working fix for authentication. ``` Fixes #74 ### Agreement - [x] I have read and understood the [Development](https://gitea.com/EvergreenCrypto/docker-finance#development) and [License](https://gitea.com/EvergreenCrypto/docker-finance#license-and-disclaimer) documentation
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Reference: EvergreenCrypto/docker-finance#75