EvergreenCrypto/docker-finance
1
1
Fork 1
Code Issues 31 Pull Requests Actions Releases 10 Activity

Coinbase: SIWC V2 compliance / fixes / improvements #49

Merged
AaronFiore merged 0 commits from refs/pull/49/head into master 2024-05-06 22:10:50 +00:00
Conversation 0 Commits - Files Changed - +4904 -18237
AaronFiore commented 2024-05-03 23:50:00 +00:00 (Migrated from gitea.com)
Copy Link

All users:

  • Must re-fetch all applicable years
  • Must re-import all applicable years
  • If applicable, must re-run the taxes command on all relevant years

Changes:

  • Support for Coinbase SIWC Spring 2024's breaking API changes
  • Coinbase Advanced Trade lot calculation fixes
  • bitcoin.tax undocumented cost-basis "feature" fixes
    • Coinbase Trade / Advanced Trade
  • bitcoin.tax cost-basis related improvements
    • Coinbase Card / Earn
  • Support non-fiat pairings
    • Coinbase Trade / Advanced Trade
  • Add more fiat support
    • 99% supported (see backreference TODOs)
  • Subaccount improvements
  • New tags / improved tags
  • Refactoring / optimizations

Resolves #48

Contributes to #39

All users: - **Must re-`fetch` all applicable years** - **Must re-`import` all applicable years** - **If applicable, must re-run the `taxes` command on all relevant years** --- Changes: - Support for Coinbase SIWC Spring 2024's breaking API changes - Coinbase Advanced Trade lot calculation fixes - bitcoin.tax undocumented cost-basis "feature" fixes * Coinbase Trade / Advanced Trade - bitcoin.tax cost-basis related improvements * Coinbase Card / Earn - Support non-fiat pairings * Coinbase Trade / Advanced Trade - Add more fiat support * 99% supported (see backreference TODOs) - Subaccount improvements - New tags / improved tags - Refactoring / optimizations --- Resolves #48 Contributes to #39
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API
Related to `dfi` API
 Breaking
Breaking change that won't be backward compatible
 Bug/Fix
Provides a bug fix
 Bug/Issue
Something is not working
 client/Dockerfiles
Client Dockerfile / docker-compose.yml related
 client/docker-finance.d
Client/container configurations (template, generated)
 client/docker (src)
Client source
 client/Doxygen
Client Doxygen related (not documentation)
 client/plugins
Client plugins
 container/finance
Container finance (source)
 container/hledger-flow
Container hledger-flow (source)
 container/plugins
Container plugins
 container/root
Container root (source)
 Dependency
Documentation
Documentation changes
 Enhancement
Improve existing functionality
 Feature
New functionality
 ₿ig ₿eautiful ₿ounty
Bounty available
 Language/Bash
Bash language specific
 Language/C++
C++ language specific
 Language/Docker-related
Dockerfile or docker-compose
 Language/GNU Awk
`gawk` specific
 Language/hledger .rules
hledger rules (hledger-flow)
 Language/PHP
PHP language specific
 Language/YAML
YAML specific
 Optimization
Priority/Critical
The priority is critical
 Priority/High
The priority is high
 Priority/Low
The priority is low
 Priority/Medium
The priority is medium
 Privacy
Refactor
Repository
Root repository-related (.gitea, .gitignore, etc.)
 Reviewed/Confirmed
Issue has been confirmed
 Reviewed/Duplicate
This issue or pull request already exists
 Reviewed/Invalid
Invalid issue
 Reviewed/Won't Fix
This issue won't be fixed
 Security
This is security issue
 Status/Abandoned
Somebody has started to work on this but abandoned work
 Status/Blocked
Something is blocking this issue or pull request
 Status/Need More Info
Feedback is required to reproduce issue or to continue work
 Tests
Issue or pull request related to tests (functional, unit, benchmarks, etc.)
No Label Breaking Bug/Fix container/finance container/hledger-flow Enhancement Language/Bash Language/GNU Awk Language/hledger .rules Language/PHP Priority/High Refactor
Milestone
No items
No Milestone v1.0.0-beta.2
Assignees
Clear assignees
AaronFiore
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Reference: EvergreenCrypto/docker-finance#49
Delete Branch "refs/pull/49/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?