EvergreenCrypto/docker-finance
1
1
Fork 1
Code Issues 31 Pull Requests Actions Releases 10 Activity

client: fix base path location deduction when sourced #303

Manually merged
AaronFiore merged 0 commits from AaronFiore/docker-finance:client-base-path-fix into master 2026-02-19 19:26:49 +00:00
Conversation 0 Commits - Files Changed -
AaronFiore commented 2026-02-19 02:05:28 +00:00
Owner
Copy Link

Description

  • Since these files are only ever sourced, deduction must be relative to
    BASH_SOURCE (or else realpath will break)

  • Fixes client-side plugins completion

    • realpath breakage was introduced in #301

Agreement

### Description - Since these files are only ever sourced, deduction must be relative to `BASH_SOURCE` (or else realpath will break) - Fixes client-side `plugins` completion * realpath breakage was introduced in [#301](https://gitea.evergreencrypto.co/EvergreenCrypto/docker-finance/issues/301) ### Agreement - [x] I have read and understood the [Development](https://gitea.evergreencrypto.co/EvergreenCrypto/dfi-docs/src/branch/master/markdown/How-do-I-contribute.md#development) and [License](https://gitea.evergreencrypto.co/EvergreenCrypto/dfi-docs/src/branch/master/markdown/Where-is-the-legalese.md#where-is-the-legalese) documentation
AaronFiore added this to the v1.3.0 milestone 2026-02-19 02:05:28 +00:00
AaronFiore added 1 commit 2026-02-19 02:05:29 +00:00
client: fix base path location deduction when sourced 4c34a882c9 
- Since these files are only ever sourced, deduction must be relative to
  `BASH_SOURCE`

- Fixes client-side completion (realpath breakage)
AaronFiore force-pushed client-base-path-fix from 4c34a882c9 to dfa71123e2 2026-02-19 02:15:04 +00:00 Compare
AaronFiore force-pushed client-base-path-fix from dfa71123e2 to 9683bf8750 2026-02-19 18:35:24 +00:00 Compare
AaronFiore force-pushed client-base-path-fix from 9683bf8750 to eca2f75f74 2026-02-19 19:11:50 +00:00 Compare
AaronFiore manually merged commit 413f5805a5 into master 2026-02-19 19:26:49 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API
Related to `dfi` API
 Breaking
Breaking change that won't be backward compatible
 Bug/Fix
Provides a bug fix
 Bug/Issue
Something is not working
 client/Dockerfiles
Client Dockerfile / docker-compose.yml related
 client/docker-finance.d
Client/container configurations (template, generated)
 client/docker (src)
Client source
 client/Doxygen
Client Doxygen related (not documentation)
 client/plugins
Client plugins
 container/finance
Container finance (source)
 container/hledger-flow
Container hledger-flow (source)
 container/plugins
Container plugins
 container/root
Container root (source)
 Dependency
Documentation
Documentation changes
 Enhancement
Improve existing functionality
 Feature
New functionality
 ₿ig ₿eautiful ₿ounty
Bounty available
 Language/Bash
Bash language specific
 Language/C++
C++ language specific
 Language/Docker-related
Dockerfile or docker-compose
 Language/GNU Awk
`gawk` specific
 Language/hledger .rules
hledger rules (hledger-flow)
 Language/PHP
PHP language specific
 Language/YAML
YAML specific
 Optimization
Priority/Critical
The priority is critical
 Priority/High
The priority is high
 Priority/Low
The priority is low
 Priority/Medium
The priority is medium
 Privacy
Refactor
Repository
Root repository-related (.gitea, .gitignore, etc.)
 Reviewed/Confirmed
Issue has been confirmed
 Reviewed/Duplicate
This issue or pull request already exists
 Reviewed/Invalid
Invalid issue
 Reviewed/Won't Fix
This issue won't be fixed
 Security
This is security issue
 Status/Abandoned
Somebody has started to work on this but abandoned work
 Status/Blocked
Something is blocking this issue or pull request
 Status/Need More Info
Feedback is required to reproduce issue or to continue work
 Tests
Issue or pull request related to tests (functional, unit, benchmarks, etc.)
No Label Bug/Fix client/docker-finance.d client/docker (src) Language/Bash
Milestone
No items
No Milestone v1.3.0
Assignees
Clear assignees
AaronFiore
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Reference: EvergreenCrypto/docker-finance#303
Delete Branch "AaronFiore/docker-finance:client-base-path-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?