EvergreenCrypto/docker-finance
1
1
Fork 1
Code Issues 31 Pull Requests Actions Releases 10 Activity

container: root: common: utility: refactor/deprecate, add/enhance free functions, refactor/add tests #249

Merged
AaronFiore merged 0 commits from refs/pull/249/head into master 2025-12-09 23:14:26 +00:00
Conversation 1 Commits - Files Changed - +588 -5470
AaronFiore commented 2025-12-09 22:42:16 +00:00 (Migrated from gitea.com)
Copy Link

Description

  • Factors out (and deprecates) Command
  • Deprecates certain free functions
  • Adds better error handling
  • Adds more free functions
  • Refactors file handling
  • Improves documentation
  • Refactors/adds tests

Notes on file loading (and general file handlers):

The interpreter command .L will load files but appears to not fail if
the file isn't source code or a library.

Calling gSystem->Load() will load a given library but not source file,
and appears to not accept paths (which will be needed for pluggables).

Because gInterpreter->LoadFile("path") will load either a source file
or library by given "path", and is consistent with dfi's approach to
path handling, this function appears to be the winner (for now).

Agreement

### Description - Factors out (and deprecates) `Command` - Deprecates certain free functions - Adds better error handling - Adds more free functions - Refactors file handling - Improves documentation - Refactors/adds tests Notes on file loading (and general file handlers): The interpreter command `.L` will load files but appears to not fail if the file isn't source code or a library. Calling `gSystem->Load()` will load a given library but not source file, and appears to not accept paths (which will be needed for pluggables). Because `gInterpreter->LoadFile("path")` will load either a source file or library by given "path", and is consistent with `dfi`'s approach to path handling, this function appears to be the winner (for now). ### Agreement - [x] I have read and understood the [Development](https://gitea.com/EvergreenCrypto/docker-finance#development) and [License](https://gitea.com/EvergreenCrypto/docker-finance#license-and-disclaimer) documentation
AaronFiore commented 2025-12-09 22:42:26 +00:00 (Migrated from gitea.com)
Copy Link

All tests pass.

All tests pass.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API
Related to `dfi` API
 Breaking
Breaking change that won't be backward compatible
 Bug/Fix
Provides a bug fix
 Bug/Issue
Something is not working
 client/Dockerfiles
Client Dockerfile / docker-compose.yml related
 client/docker-finance.d
Client/container configurations (template, generated)
 client/docker (src)
Client source
 client/Doxygen
Client Doxygen related (not documentation)
 client/plugins
Client plugins
 container/finance
Container finance (source)
 container/hledger-flow
Container hledger-flow (source)
 container/plugins
Container plugins
 container/root
Container root (source)
 Dependency
Documentation
Documentation changes
 Enhancement
Improve existing functionality
 Feature
New functionality
 ₿ig ₿eautiful ₿ounty
Bounty available
 Language/Bash
Bash language specific
 Language/C++
C++ language specific
 Language/Docker-related
Dockerfile or docker-compose
 Language/GNU Awk
`gawk` specific
 Language/hledger .rules
hledger rules (hledger-flow)
 Language/PHP
PHP language specific
 Language/YAML
YAML specific
 Optimization
Priority/Critical
The priority is critical
 Priority/High
The priority is high
 Priority/Low
The priority is low
 Priority/Medium
The priority is medium
 Privacy
Refactor
Repository
Root repository-related (.gitea, .gitignore, etc.)
 Reviewed/Confirmed
Issue has been confirmed
 Reviewed/Duplicate
This issue or pull request already exists
 Reviewed/Invalid
Invalid issue
 Reviewed/Won't Fix
This issue won't be fixed
 Security
This is security issue
 Status/Abandoned
Somebody has started to work on this but abandoned work
 Status/Blocked
Something is blocking this issue or pull request
 Status/Need More Info
Feedback is required to reproduce issue or to continue work
 Tests
Issue or pull request related to tests (functional, unit, benchmarks, etc.)
No Label API container/plugins container/root Enhancement Language/C++ Refactor Tests
Milestone
No items
No Milestone v1.1.0
Assignees
Clear assignees
AaronFiore
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Reference: EvergreenCrypto/docker-finance#249
Delete Branch "refs/pull/249/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?