EvergreenCrypto/docker-finance
1
1
Fork 1
Code Issues 31 Pull Requests Actions Releases 10 Activity

hledger-flow: coinbase: Coinbase Trade: remove comment2 overwrite #50

Merged
AaronFiore merged 0 commits from refs/pull/50/head into master 2024-05-11 03:58:06 +00:00
Conversation 1 Commits - Files Changed - +4902 -18237
AaronFiore commented 2024-05-07 02:05:01 +00:00 (Migrated from gitea.com)
Copy Link
  • Use Buy total for cost-basis instead of subtotal overwrite
  • Remove redundant Sell overwrite

Fixup to pull request #49

- Use Buy total for cost-basis instead of subtotal overwrite - Remove redundant Sell overwrite Fixup to pull request #49
AaronFiore commented 2024-05-11 03:55:22 +00:00 (Migrated from gitea.com)
Copy Link

NOTE: #50 and #49 have exposed a larger issue regarding bitcoin.tax's handling of cost-basis. Particularly; non-fiat pairs and closing report balance.

These issues need to have a separate ticket opened as they are not resolved by this PR.

NOTE: #50 and #49 have exposed a larger issue regarding bitcoin.tax's handling of cost-basis. Particularly; non-fiat pairs and closing report balance. These issues need to have a separate ticket opened as they are not resolved by this PR.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API
Related to `dfi` API
 Breaking
Breaking change that won't be backward compatible
 Bug/Fix
Provides a bug fix
 Bug/Issue
Something is not working
 client/Dockerfiles
Client Dockerfile / docker-compose.yml related
 client/docker-finance.d
Client/container configurations (template, generated)
 client/docker (src)
Client source
 client/Doxygen
Client Doxygen related (not documentation)
 client/plugins
Client plugins
 container/finance
Container finance (source)
 container/hledger-flow
Container hledger-flow (source)
 container/plugins
Container plugins
 container/root
Container root (source)
 Dependency
Documentation
Documentation changes
 Enhancement
Improve existing functionality
 Feature
New functionality
 ₿ig ₿eautiful ₿ounty
Bounty available
 Language/Bash
Bash language specific
 Language/C++
C++ language specific
 Language/Docker-related
Dockerfile or docker-compose
 Language/GNU Awk
`gawk` specific
 Language/hledger .rules
hledger rules (hledger-flow)
 Language/PHP
PHP language specific
 Language/YAML
YAML specific
 Optimization
Priority/Critical
The priority is critical
 Priority/High
The priority is high
 Priority/Low
The priority is low
 Priority/Medium
The priority is medium
 Privacy
Refactor
Repository
Root repository-related (.gitea, .gitignore, etc.)
 Reviewed/Confirmed
Issue has been confirmed
 Reviewed/Duplicate
This issue or pull request already exists
 Reviewed/Invalid
Invalid issue
 Reviewed/Won't Fix
This issue won't be fixed
 Security
This is security issue
 Status/Abandoned
Somebody has started to work on this but abandoned work
 Status/Blocked
Something is blocking this issue or pull request
 Status/Need More Info
Feedback is required to reproduce issue or to continue work
 Tests
Issue or pull request related to tests (functional, unit, benchmarks, etc.)
No Label Bug/Fix container/hledger-flow Enhancement Language/hledger .rules Priority/High
Milestone
No items
No Milestone v1.0.0-beta.2
Assignees
Clear assignees
AaronFiore
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Reference: EvergreenCrypto/docker-finance#50
Delete Branch "refs/pull/50/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?