EvergreenCrypto/docker-finance
1
1
Fork 1
Code Issues 31 Pull Requests Actions Releases 10 Activity

Merge pull request #209 into master

Browse Source 
903560c container: php: refactor for linter (Aaron Fiore)
This commit was merged in pull request #209.
This commit is contained in:
Aaron Fiore
2025-08-19 13:39:48 -07:00
parent 3adcb008d2 903560ccc3
commit dbf9cbf6c9
6 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
container/src/finance/lib/internal/fetch/blockchains/fetch.php
View File

@@ -51,7 +51,7 @@ namespace docker_finance\blockchains
parent::__construct($env);
}
public function fetch(internal\Metadata $metadata = null): void
public function fetch(internal\Metadata|null $metadata = null): void
{
// API_SUBACCOUNT format: blockchain/account/address[,blockchain/account/address,...]"
// TODO: if caller is using a custom delimiter, this will break!

2
container/src/finance/lib/internal/fetch/blockchains/internal/base.php
View File

@@ -296,7 +296,7 @@ namespace docker_finance\blockchains
*
* @warning Implementation *should* param check for null.
*/
abstract public function fetch(internal\Metadata $metadata = null): void;
abstract public function fetch(internal\Metadata|null $metadata = null): void;
}
} // namespace docker_finance\blockchains

2
container/src/finance/lib/internal/fetch/blockchains/internal/blockchains/algorand.php
View File

@@ -290,7 +290,7 @@ namespace docker_finance\blockchains\internal\blockchains
$this->explorer = new algorand\AlgoIndexer($env);
}
public function fetch(internal\Metadata $metadata = null): void
public function fetch(internal\Metadata|null $metadata = null): void
{
if (is_null($metadata)) {
utils\CLI::throw_fatal("metadata unavailable");

4
container/src/finance/lib/internal/fetch/blockchains/internal/blockchains/ethereum.php
View File

@@ -65,7 +65,7 @@ namespace docker_finance\blockchains\internal\blockchains\ethereum
* @details Upstream returns a variable-size string with the higher length
* being ETH transferred. Example: 279006000000000000000 = 279.006
*/
private function amount_calculator(string $value, string $decimal = null): string
private function amount_calculator(string $value, string|null $decimal = null): string
{
// non-ERC-20
if (empty($decimal)) {
@@ -342,7 +342,7 @@ namespace docker_finance\blockchains\internal\blockchains
$this->explorer = new ethereum\Etherscan($env);
}
public function fetch(internal\Metadata $metadata = null): void
public function fetch(internal\Metadata|null $metadata = null): void
{
if (is_null($metadata)) {
utils\CLI::throw_fatal("metadata unavailable");

2
container/src/finance/lib/internal/fetch/blockchains/internal/blockchains/tezos.php
View File

@@ -285,7 +285,7 @@ namespace docker_finance\blockchains\internal\blockchains
$this->explorer = new tezos\TzKt($env);
}
public function fetch(internal\Metadata $metadata = null): void
public function fetch(internal\Metadata|null $metadata = null): void
{
if (is_null($metadata)) {
utils\CLI::throw_fatal("metadata unavailable");

2
container/src/finance/lib/internal/fetch/exchanges/internal/exchanges/gemini.php
View File

@@ -97,7 +97,7 @@ namespace docker_finance\exchanges\internal\exchanges\gemini
* @param string $path URI path
* @param string $api API scope
* @param string $method HTTP method
* @param array<string> $params Optional parameters
* @param array<string, int|string> $params Optional parameters
* @return mixed Raw requested data
*/
protected function request(