f28a2824d5
We should not show the untrusted text in the GUI... With this change, we still log the text, but otherwise it should avoid unintentionally showing it anywhere, as the original exception is masked away. related: https://github.com/spesmilo/electrum/issues/8599#issuecomment-1706775508 Example traceback (and the exc is then shown in main_window.on_error): ``` 10.77 | D | n/network | got error from server for Network.listunspent_for_scripthash: <UntrustedServerReturnedError [DO NOT TRUST THIS MESSAGE] original_exception: "RPCError(0, 'heyheyhey')"> 10.78 | E | gui.qt.main_window.[test_segwit_2] | on_error Traceback (most recent call last): File "...\electrum\electrum\network.py", line 898, in wrapper return await func(self, *args, **kwargs) File "...\electrum\electrum\network.py", line 1149, in listunspent_for_scripthash return await self.interface.listunspent_for_scripthash(sh) File "...\electrum\electrum\interface.py", line 1027, in listunspent_for_scripthash raise aiorpcx.jsonrpc.RPCError(0, "heyheyhey") aiorpcx.jsonrpc.RPCError: (0, 'heyheyhey') The above exception was the direct cause of the following exception: Traceback (most recent call last): File "...\electrum\electrum\gui\qt\util.py", line 925, in run result = task.task() File "...\electrum\electrum\gui\qt\main_window.py", line 2505, in <lambda> task = lambda: self.network.run_from_another_thread( File "...\electrum\electrum\network.py", line 383, in run_from_another_thread return fut.result(timeout) File "...\Python310\lib\concurrent\futures\_base.py", line 458, in result return self.__get_result() File "...\Python310\lib\concurrent\futures\_base.py", line 403, in __get_result raise self._exception File "...\electrum\electrum\wallet.py", line 151, in sweep_preparations async with OldTaskGroup() as group: File "...\aiorpcX\aiorpcx\curio.py", line 304, in __aexit__ await self.join() File "...\electrum\electrum\util.py", line 1316, in join task.result() File "...\electrum\electrum\wallet.py", line 142, in find_utxos_for_privkey await _append_utxos_to_inputs( File "...\electrum\electrum\wallet.py", line 129, in _append_utxos_to_inputs u = await network.listunspent_for_scripthash(scripthash) File "...\electrum\electrum\network.py", line 872, in make_reliable_wrapper async with OldTaskGroup(wait=any) as group: File "...\aiorpcX\aiorpcx\curio.py", line 304, in __aexit__ await self.join() File "...\electrum\electrum\util.py", line 1327, in join self.completed.result() File "...\electrum\electrum\network.py", line 903, in wrapper raise wrapped_exc from e electrum.network.UntrustedServerReturnedError: The server returned an error. ```
Electrum - Lightweight Bitcoin client
Licence: MIT Licence
Author: Thomas Voegtlin
Language: Python (>= 3.8)
Homepage: https://electrum.org/
Getting started
(If you've come here looking to simply run Electrum, you may download it here.)
Electrum itself is pure Python, and so are most of the required dependencies, but not everything. The following sections describe how to run from source, but here is a TL;DR:
$ sudo apt-get install libsecp256k1-dev
$ python3 -m pip install --user ".[gui,crypto]"
Not pure-python dependencies
If you want to use the Qt interface, install the Qt dependencies:
$ sudo apt-get install python3-pyqt5
For elliptic curve operations, libsecp256k1 is a required dependency:
$ sudo apt-get install libsecp256k1-dev
Alternatively, when running from a cloned repository, a script is provided to build libsecp256k1 yourself:
$ sudo apt-get install automake libtool
$ ./contrib/make_libsecp256k1.sh
Due to the need for fast symmetric ciphers, cryptography is required. Install from your package manager (or from pip):
$ sudo apt-get install python3-cryptography
If you would like hardware wallet support, see this.
Running from tar.gz
If you downloaded the official package (tar.gz), you can run Electrum from its root directory without installing it on your system; all the pure python dependencies are included in the 'packages' directory. To run Electrum from its root directory, just do:
$ ./run_electrum
You can also install Electrum on your system, by running this command:
$ sudo apt-get install python3-setuptools python3-pip
$ python3 -m pip install --user .
This will download and install the Python dependencies used by
Electrum instead of using the 'packages' directory.
It will also place an executable named electrum in ~/.local/bin,
so make sure that is on your PATH variable.
Development version (git clone)
(For OS-specific instructions, see here for Windows, and for macOS)
Check out the code from GitHub:
$ git clone https://github.com/spesmilo/electrum.git
$ cd electrum
$ git submodule update --init
Run install (this should install dependencies):
$ python3 -m pip install --user -e .
Create translations (optional):
$ sudo apt-get install python3-requests gettext qttools5-dev-tools
$ ./contrib/pull_locale
Finally, to start Electrum:
$ ./run_electrum
Run tests
Run unit tests with pytest:
$ pytest electrum/tests -v
To run a single file, specify it directly like this:
$ pytest electrum/tests/test_bitcoin.py -v
Creating Binaries
Contributing
Any help testing the software, reporting or fixing bugs, reviewing pull requests and recent changes, writing tests, or helping with outstanding issues is very welcome. Implementing new features, or improving/refactoring the codebase, is of course also welcome, but to avoid wasted effort, especially for larger changes, we encourage discussing these on the issue tracker or IRC first.
Besides GitHub,
most communication about Electrum development happens on IRC, in the
#electrum channel on Libera Chat. The easiest way to participate on IRC is
with the web client, web.libera.chat.