1
0

15327 Commits

Author SHA1 Message Date
SomberNight
9ea705dadc prepare release 4.3.3 4.3.3 2023-01-02 15:35:37 +00:00
SomberNight
764aea4434 update locale 2023-01-02 15:32:19 +00:00
SomberNight
85ec4b2f61 qt gui: display nice error if QR code data overflows
there is existing handler-code at e.g.
1a7634e615/electrum/gui/qt/transaction_dialog.py (L309)
but we should make sure setData() always raises the exc when needed,
as paintEvent() is too late for nice handling.

closes https://github.com/spesmilo/electrum/issues/4288
closes https://github.com/spesmilo/electrum/issues/4280
2023-01-02 14:07:58 +00:00
SomberNight
459a7e2eaa cirrus CI: disable macOS builds, as no more intel-based mac workers
related https://cirrus-ci.org/blog/2022/11/08/sunsetting-intel-macos-instances/
2023-01-02 14:07:54 +00:00
SomberNight
23cb6f5f78 build: use $CIRRUS_CPU to determine cpu count on CI
related https://github.com/cirruslabs/cirrus-ci-docs/issues/1115
2023-01-02 14:07:51 +00:00
SomberNight
8e183d3bef qt network dialog: don't poll Tor socks proxy, but scan on interaction
Polling is introduces spam in Tor logs.
Also, Tor Browser 12.0 apparently has a bug where our polling renders
the socks proxy unusuable after some time.
see https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41549

Instead of trying to detect a Tor socks proxy every 10 seconds, we now
run detection when the Qt network dialog gets opened, and also when
the user switches to the "Proxy" tab in the dialog.

fixes https://github.com/spesmilo/electrum/issues/7317
2023-01-02 14:07:47 +00:00
SomberNight
b926f11702 qt gui: handle swap server unreachable
note: testnet swap server is offline atm
closes https://github.com/spesmilo/electrum/issues/8107
2023-01-02 14:07:43 +00:00
SomberNight
67f0f90e8d bitcoin: trivial speedup for DecodeBase58Check (down to ~80% time) 2023-01-02 14:06:49 +00:00
SomberNight
9bbb1f24e5 simplify prev 2023-01-02 14:06:14 +00:00
SomberNight
e58501a3fe logging: add a relative timestamp to stderr console logs
In the past we decided not to put a timestamp into the stderr logs
to have shorter log lines (to save column width in a terminal).
However over time I at least have found that it would be valuable
to have timestamps also in the stderr - e.g. when users provide logs.
Often I am only interested in the time taken between logged events,
so as a compromise to still save some length, I propose adding relative
timestamps (relative to process startup time).

Compare these log lines from the file logger:

```
20220816T120601.882003Z |     INFO | gui.qt.ElectrumGui | starting Qt main loop
20220816T120601.905619Z |     INFO | gui.qt.history_list.HistoryModel | refreshing... reason: update_tabs
20220816T120601.911908Z |    DEBUG | util.profiler | Abstract_Wallet.get_full_history 0.0059 sec
20220816T120602.095670Z |     INFO | interface.[testnet.hsmiths.com:53012] | connection established. version: ['ElectrumX 1.16.0', '1.4']
```
With these from the existing stderr logger:
```
I/w | wallet.Standard_Wallet.[test_segwit_3] | set_up_to_date: True
I/i | interface.[testnet.aranguren.org:51002] | set blockchain with height 2343721
D | util.profiler | ElectrumWindow.load_wallet 0.0778 sec
I | gui.qt.ElectrumGui | starting Qt main loop
```
With these re what I propose for the stderr logger:
```
  3.20 | D | util.profiler | Abstract_Wallet.get_full_history 0.0029 sec
  5.70 | I | i/interface.[testnet1.bauerj.eu:50002] | disconnecting due to: ConnectError(ConnectionRefusedError(22, 'The remote computer refused the network connection', None, 1225, None))
 38.63 | I | w/wallet.Standard_Wallet.[9dk] | starting taskgroup.
 38.84 | D | util.profiler | WalletDB._write 0.0059 sec
 62.96 | I | i/interface.[blockstream.info:993] | set blockchain with height 2343722
150.65 | I | exchange_rate.CoinGecko | getting fx quotes for EUR
```
2023-01-02 14:06:10 +00:00
SomberNight
8995a3e1bd Qt chan list: Ctrl+F filter to work for long channel id 2022-12-10 12:46:17 +00:00
SomberNight
52ccea5329 lnchannel: log chan id in ChannelBackup logger
otherwise it's hard to debug what's going on when having many channels
2022-12-10 12:45:53 +00:00
ThomasV
e8ac09721c kivy: remove user_rbf boolean property (unused) 2022-12-07 15:59:11 +01:00
ThomasV
3131fde97b submarine swaps: set rbf for CLI transactions
(it was already the case with GUI)
2022-12-07 13:26:29 +01:00
SomberNight
f86229f169 Merge pull request #8091 from zouppen/convert_currency_cmd
Add command for currency conversions
2022-12-06 18:29:49 +00:00
Joel Lehtonen OH64K
a24a928e9f commands: Make conversion to/from BTC the default
As suggested by SomberNight in PR #8091, the difference is that this
commit handles currencies in case-insensitive manner.

Co-authored-by: ghost43 <somber.night@protonmail.com>
2022-12-06 16:46:15 +02:00
Joel Lehtonen
62711a57bc commands: Better default currencies in convert_currency
Co-authored-by: ghost43 <somber.night@protonmail.com>
2022-12-06 04:19:48 +02:00
Joel Lehtonen
0b540956fb exchange_rate: "BTC" to "BTC" rate is not guaranteed to be present
Which ccy rates are available depends on the configured
exchange (config key use_exchange) and the configured currency (config
key currency). Only for some exchanges, the fx.ccy-BTC fx rate is
available (depends on the ExchangeBase.get_rates implementation).

As they say, for hodlers 1 BTC = 1 BTC.
2022-12-06 04:19:23 +02:00
Joel Lehtonen
09170bdd1f commands: Improve error messages in convert_currency
Co-authored-by: ghost43 <somber.night@protonmail.com>
2022-12-06 03:30:24 +02:00
Joel Lehtonen OH64K
cdc1660d47 commands: Remove unused requested_amount and fix a typo (#8090) 2022-12-05 22:31:16 +00:00
Joel Lehtonen
02dba54ab9 commands: Add command "convert_currency"
This adds command "convert_currency" which allows the user to do
currency conversions via command line or JSON RPC. Wallet not
required.
2022-12-05 23:29:37 +02:00
Joel Lehtonen
01d31dd61d exchange_rate: Add precisions of some cryptocurrencies
There are many cryptocurrencies available in CoinGecko and some other
exchange rate providers. If the user wants to use a cryptocurrency as
a display currency, the precisions used to be 2. This patch adds
precisions of some cryptocurrencies.
2022-12-05 23:08:12 +02:00
Joel Lehtonen
9ac58d0bc0 exchange_rate: Allow formatting amount with custom currency 2022-12-05 23:08:12 +02:00
Sander van Grieken
21d1842b84 log if get_history fails sanity check 2022-12-03 11:09:51 +01:00
Sander van Grieken
96f4530eb2 qml: ReceiveDialog styling 2022-12-05 19:42:29 +01:00
ghost43
e8c5ff5d2d Merge pull request #8087 from SomberNight/20221204_build_nproc_2
CI: AppImage build is failing with `Container errored with 'OOMKilled'`
2022-12-04 16:30:37 +00:00
SomberNight
feb75ec9e6 CI: AppImage build is failing with "Container errored with 'OOMKilled'"
"AppImage build" on the CI is failing with "Container errored with 'OOMKilled'" since 65ae281180
https://cirrus-ci.com/task/6506466559918080
https://cirrus-ci.com/task/6518283422662656

Apparently, when running in a Cirrus CI container, `nproc` returns the number of host CPUs,
instead of the number of cpus available to the container.
Opened upstream issue:
https://github.com/cirruslabs/cirrus-ci-docs/issues/1115
2022-12-04 00:11:29 +00:00
SomberNight
8cfbce827c ledger plugin: fix binaries
follow-up https://github.com/spesmilo/electrum/pull/8041
(ac239a81b8)
2022-12-03 22:52:23 +00:00
SomberNight
65ae281180 build: don't hardcode num worker threads "make -j4" 2022-12-03 22:50:18 +00:00
Sander van Grieken
96af21faeb qml: show extra fee in ConfirmTxDialog (2fa) 2022-12-02 13:50:31 +01:00
Sander van Grieken
ad2b01716c qml: request details hooks to backend callback, not to QEWallet signal.
Also fix destructor issue
2022-12-01 11:39:28 +01:00
Sander van Grieken
4c7ab67474 qml: receive dialog flickable when challenged vertical space 2022-12-01 10:33:16 +01:00
Sander van Grieken
5e34f01f53 qml: keep elements in place when QR code (and size) changes in ReceiveDialog 2022-12-01 10:00:26 +01:00
Sander van Grieken
ffcd533a8d qml: refactor OpenChannel to dialog, fix lifecycle/race conditions swap & openchannel 2022-11-30 15:10:35 +01:00
Sander van Grieken
56e37f74d4 qml: swapdialog styling fixes 2022-11-30 14:20:29 +01:00
Sander van Grieken
969f84913e qml: keystore icon indicator for watch-only 2022-11-30 13:56:46 +01:00
Sander van Grieken
441ffff02b qml: network overview page 2022-11-30 11:05:57 +01:00
Sander van Grieken
1f22b865c3 qml: pastebutton and qr scan will only fill textarea after validation,
more clear text for pubkey and seed for cosigners
2022-11-29 11:28:59 +01:00
Sander van Grieken
9354dfc86d qml: skip multisig_show_masterpubkey view and instead present master pub key on every
cosigner key/seed import page.
2022-11-28 17:42:29 +01:00
Sander van Grieken
b7dcc1277c qml: listen for verified callbacks in fee bumpers, tx canceller and txdetails.
TxDetails updates the page, Rbf adn Cpfp fee bump dialogs and RbfCancelDialog auto-close.
2022-11-28 15:45:06 +01:00
Sander van Grieken
31f30a9247 qml: disable drawer for now 2022-11-28 14:19:23 +01:00
Sander van Grieken
4fb010da1a qml: move balance from drawer to history listview header 2022-11-28 13:12:07 +01:00
Sander van Grieken
535754363e qml: fix imports 2022-11-25 20:53:30 +01:00
Sander van Grieken
ebb714fa1b qml: feebump button in TxDetails next to tx fee, remove RbF flag 2022-11-25 18:44:28 +01:00
Sander van Grieken
78df722419 qml: add initial logic and UI for CPFP 2022-11-25 18:43:05 +01:00
Sander van Grieken
8fbfe87e78 qml: rename QETxFeeBumper -> QETxRbfFeeBumper, BumpFeeDialog.qml -> RbfBumpFeeDialog.qml 2022-11-23 17:10:34 +01:00
Sander van Grieken
7397a0c2b4 follow-up prev 2022-11-23 17:09:53 +01:00
Sander van Grieken
990ec311d2 qml: implement cancel rbf tx 2022-11-22 13:37:46 +01:00
Sander van Grieken
9c82a94ad0 qml: add final/rbf to txdetails 2022-11-22 12:41:57 +01:00
Sander van Grieken
cccd5ff19b qml: add 'local' and 'mempool' sections to history, update section on on_tx_verified callback 2022-11-22 00:34:31 +01:00