1
0
Commit Graph

11657 Commits

Author SHA1 Message Date
ThomasV
dd6cb2caf7 GUI: Separate output selection and transaction finalization.
- Output selection belongs in the Send tab.
 - Tx finalization is performed in a confirmation dialog
   (ConfirmTxDialog or PreviewTxDialog)
 - the fee slider is shown in the confirmation dialog
 - coin control works by selecting items in the coins tab
 - user can save invoices and pay them later
 - ConfirmTxDialog is used when opening channels and sweeping keys
2019-11-12 14:42:06 +01:00
SomberNight
f8c84fbb1e hardware wallets: create base class for HW Clients. add some type hints 2019-11-11 17:04:12 +01:00
SomberNight
2fec17760d qt address list: check internal address corruption when copying address
regressing following c721e880d0

note that place_text_on_clipboard is overridden in AddressList
2019-11-11 15:51:23 +01:00
SomberNight
5549f3adbe CoinChooser: avoid NotEnoughFunds if zero buckets are sufficient
closes #5752

Adapted from @JeremyRand's fix
2019-11-11 15:15:04 +01:00
ThomasV
5773097b08 rename 'copy column' to 'copy' 2019-11-10 07:55:37 +01:00
SomberNight
bf8a58c0b4 tx_from_any: strip whitespaces
see https://github.com/spesmilo/electrum/pull/5721#issuecomment-551876236
2019-11-08 17:51:48 +01:00
SomberNight
365aa189f2 qt FileDialogs for transactions: better file extension filter 2019-11-08 15:22:11 +01:00
SomberNight
9ff7d2c5a7 transactions (qt): fix opening raw bytes files
(both when trying to "load tx from file", and "load tx from text" > "browse file")
2019-11-08 15:10:54 +01:00
SomberNight
85a4811742 transaction.tx_from_any: recognise even more types, and add tests 2019-11-08 15:01:18 +01:00
SomberNight
fef1ddd416 wallet: fix #5748 2019-11-08 13:43:12 +01:00
SomberNight
7b18c91b74 psbt follow-up: fix ln cooperative close, and minor type clean up 2019-11-07 18:28:27 +01:00
ThomasV
707b74d22b Merge pull request #5721 from SomberNight/201910_psbt
integrate PSBT support natively. WIP
2019-11-07 17:10:20 +01:00
SomberNight
cd49839bc0 transaction: helpful error msg if user tries to load old partial tx 2019-11-07 07:07:02 +01:00
SomberNight
27df235c26 transactions: reading QR codes: clean-up and accept all encodings 2019-11-07 06:33:15 +01:00
SomberNight
29a6e3c019 psbt: implement PSBT_GLOBAL_VERSION field
based on latest BIP-0174 update: bitcoin/bips#849
2019-11-07 03:43:00 +01:00
SomberNight
83740c1a78 psbt: implement CompactSize key types (previously single-byte types)
based on latest BIP-0174 update: bitcoin/bips#849
2019-11-07 03:27:38 +01:00
SomberNight
aa518c0ea5 psbt: allow insecure signing of legacy UTXOs without full previous tx
When "importing" a psbt, we accept witness utxos even for legacy inputs
(warning shown to user in gui).
When "exporting" a psbt, we follow the spec; except when exporting as a QR code,
in which case we include witness utxos for all inputs.
This makes QR codes for psbts with legacy inputs feasible, just like they
were before, with our custom tx serialization format (with the same risk,
of burning coins as miner fees).
2019-11-07 02:40:10 +01:00
SomberNight
74a46689d8 kivy tx dialog: was missing tx.add_input_from_wallet() call
resulted in e.g. incorrect "tx unrelated to wallet" detection for beyond-gap-limit stuff
2019-11-07 02:26:58 +01:00
SomberNight
8a7c3447b3 tx dialog: try harder to show fee 2019-11-07 02:24:16 +01:00
SomberNight
6573e7f1f3 test_wallet_vertical: add test for manual coinjoin 2019-11-06 18:40:16 +01:00
SomberNight
8e09d429c0 psbt: "updater" must swap NON_WITNESS_UTXO for WITNESS_UTXO if txin is segwit 2019-11-06 03:46:00 +01:00
SomberNight
c077d77316 psbt: test_wallet_vertical: add asserts to avoid silent breakage of psbts we create 2019-11-06 03:42:14 +01:00
SomberNight
955caa7292 transaction: to_json() debug methods display bip32 str (not int) paths 2019-11-05 23:39:50 +01:00
SomberNight
46db33df75 psbt: follow-ups: BCDataStream.read_bytes() should return bytes
This fixes keepkey, as in particular the code in the plugin expected
TxOutpoint.txid to be bytes not a bytearray (and the TxOutpoint named tuple
itself claims txid to be bytes).
2019-11-05 23:35:32 +01:00
SomberNight
cc4f6804b0 psbt: follow-ups: fix trezor 2019-11-05 23:32:00 +01:00
SomberNight
dd14a3fde5 psbt: follow-ups: fix digital bitbox 2019-11-05 22:06:46 +01:00
SomberNight
9e86352022 psbt: follow-ups: fix ledger 2019-11-05 21:34:54 +01:00
SomberNight
26a5f212cb psbt: cleaner API for serialize* methods 2019-11-04 22:25:16 +01:00
SomberNight
1017fefdc9 psbt: only include xpubs for multisig wallets 2019-11-04 22:25:13 +01:00
SomberNight
90b190bbcd psbt: fix bug re witness_utxo serialization 2019-11-04 22:25:09 +01:00
SomberNight
c8c1ea9c86 qt tx dialog: add export options for coinjoins and for coldcard 2019-11-04 22:25:06 +01:00
SomberNight
d872be7f6b psbt: don't put xpubs and full paths into tx by def; only while signing 2019-11-04 22:25:02 +01:00
SomberNight
e6c841d05f psbt: put fake xpubs into globals. keystores handle xfp/der_prefix missing 2019-11-04 22:24:59 +01:00
SomberNight
7eb7eb8674 add support for manual coinjoins 2019-11-04 22:24:55 +01:00
SomberNight
bafe8a2fff integrate PSBT support natively. WIP 2019-11-04 22:24:36 +01:00
ghost43
6d12ebabbb qt tx dialog: show dropdown for "export", instead of separate buttons (#5739) 2019-11-04 16:24:55 +00:00
ghost43
53dea824a4 Merge pull request #5742 from Coldcard/master
plugins/coldcard/qt.py: bugfix for API change on main_window.show_transaction
2019-11-04 14:25:51 +00:00
Peter D. Gray
ec2bdbd02d plugins/coldcard/qt.py: bugfix for API change on main_window.show_transaction 2019-11-04 09:21:41 -05:00
SomberNight
3e98123b17 qt settings dialog: small fixes 2019-11-02 06:13:11 +01:00
SomberNight
f72bb03af6 commands: gettransaction cmd now tests txid before returning tx
thanks for @JeremyRand
ref #5660
2019-11-02 05:46:52 +01:00
SomberNight
3bfcfb49c3 fix qt invoices list: handle lightning disabled
closes #5738
2019-11-02 03:44:22 +01:00
SomberNight
ccccaf099f (trivial) logging "verbosity_filter" was renamed to "LOGGING_SHORTCUT" 2019-10-30 03:24:26 +01:00
SomberNight
75902f8e35 fix logic error in lnworker.on_channel_closed 2019-10-29 20:39:58 +01:00
ThomasV
427f7f8eeb fix #5731 2019-10-29 08:06:53 +01:00
SomberNight
a20317fe2a fix #5726 2019-10-28 21:17:20 +01:00
ThomasV
7b5869c7bc kivy:
- simplify menu
 - add lightning network dialog
2019-10-25 16:46:52 +02:00
ThomasV
2dd368e76e minor fix: show_transaction params 2019-10-24 18:45:51 +02:00
ThomasV
5c1340b7bd pass both invoice and description to show_transaction 2019-10-24 17:27:14 +02:00
ThomasV
76c22f3e06 follow-up a0ec2690cf 2019-10-24 16:27:54 +02:00
ThomasV
24221584e2 fix clear_requests button 2019-10-24 09:32:40 +02:00