1
0
Commit Graph

15949 Commits

Author SHA1 Message Date
SomberNight
aac9afa7c1 tests: add a failing testcase for daemon.update_password_for_directory
related https://github.com/spesmilo/electrum/issues/8259
2023-03-20 20:05:21 +00:00
Sander van Grieken
a5c58f8aae qml: layout fixes for small form-factor devices 2023-03-20 19:52:57 +01:00
Sander van Grieken
677e1259df qml: ElDialog now defaults to parent on Overlay.overlay
This was replicated in basically all ElDialog derived dialogs
2023-03-20 16:53:40 +01:00
SomberNight
b8d4ccd432 wallet: fix get_locktime_for_new_transaction for lagging server
Merchant reported that 0.5% of txs they make are rejected
by the connected server due to the locktime being in the future.

fixes https://github.com/spesmilo/electrum/issues/8245
2023-03-20 15:50:38 +00:00
Sander van Grieken
4ed69cc54f qml: BtcField/FiatField ImhDigitsOnly input method hint 2023-03-20 14:10:13 +01:00
Sander van Grieken
c9df290301 android: update P4A to 8589243afb48fdb116d791dc5b3973382e83273f
include Qt Virtual Keyboard libraries and associated QtQuick components
2023-03-20 13:15:03 +01:00
ThomasV
4fa192d9e7 follow-up c3e52bfafc 2023-03-20 11:09:18 +01:00
ThomasV
2e797b4d77 Merge branch 'master' of github.com:spesmilo/electrum 2023-03-20 11:00:30 +01:00
ThomasV
5ee89a294e Merge pull request #8266 from SomberNight/202303_cb_uint16
lnutil.ImportedChannelBackupStorage: change ser format: int16->uint16
2023-03-20 07:49:52 +01:00
SomberNight
08ae0a73b2 build: add separate .dockerignore files
The .dockerignore symlink in the project root dir is only picked up by the android build.
The android build has the project root as its build context for "docker build" --
the other builds have their own subdirectories as build context, e.g. contrib/build-linux/appimage.
2023-03-20 02:05:40 +00:00
SomberNight
5a4c39cb94 lnutil.ImportedChannelBackupStorage: change ser format: int16->uint16
In the binary serialised format, replace all instances of int16 with uint16.
In particular, this allows port>32767.
Fixes https://github.com/spesmilo/electrum/issues/8264

I think this is backwards compatible, as in, any existing channel backup already out there,
should be properly parsed with the new code. (new code however can serialise cbs that old
code deserialises incorrectly)

```
>>> struct.pack('<h', 258)
b'\x02\x01'
>>> struct.pack('<H', 258)
b'\x02\x01'
```
2023-03-19 19:32:09 +00:00
SomberNight
4fb35c0002 lnutil: clean-up ImportedChannelBackupStorage.from_bytes 2023-03-19 19:22:41 +00:00
SomberNight
a30cda4ebd lnutil: test ImportedChannelBackupStorage.from_bytes
regression test - we should not inadvertently break deserialising existing backups
2023-03-19 19:15:44 +00:00
SomberNight
68bba47052 commands: small fix and clean-up for "serialize" cmd
Docstring was outdated, and
`txout.get('value', txout['value_sats'])`
was a logic bug.

fixes https://github.com/spesmilo/electrum/issues/8265
2023-03-19 18:34:43 +00:00
ThomasV
5cf4b346a9 change message: detached QR code window 2023-03-19 11:40:52 +01:00
ThomasV
8b0a6940bc receive tab: disable widgets if request has expired, instead of applying red stylesheet 2023-03-19 11:13:45 +01:00
ThomasV
4243b250b1 qt send_tab: simplify method names.
when a method belongs to a class, there is no need to repeat the
class name in the method name.
2023-03-19 10:44:33 +01:00
ThomasV
b07fe970bf receive tab: do not use ButtonsTextEdit, add toggle to toolbar. 2023-03-19 10:15:19 +01:00
ThomasV
c3e52bfafc Qt: allow to save invoices that have no amount
(such invoices are already saved by the QML GUI.)
2023-03-19 09:52:47 +01:00
ThomasV
5ab3a250c5 qml: remove '1 month' expiry option.
The list of supported values is in electrum/invoices.py
If the config is set to an unsuported value, the qt app will crash.
2023-03-19 09:02:35 +01:00
ThomasV
aa3697de74 Qr request_list: maybe fix elusive segfault 2023-03-19 06:36:36 +01:00
ThomasV
5c60b9ad29 ln invoice dialog: show fallback address 2023-03-19 05:16:15 +01:00
ThomasV
3b78466123 simplify code (follow-up 2836dccfbb) 2023-03-18 17:45:42 +01:00
ThomasV
d7c5c40c1d Save user-entered amount in invoice. fixes #8252.
Note that this allows users to save invoices that have an empty
amount, which is not allowed by the Qt GUI. Qt will complain at
pay time about empty amount if a lightning invoice without amount
is saved. With onchain invoices, Qt will create an onchain tx with
a zero output.
2023-03-18 17:29:56 +01:00
ThomasV
dd2dced296 follow-up 2836dccfbb 2023-03-18 13:14:14 +01:00
ThomasV
2836dccfbb qml: Handle situation where no more addresses are available without
creating addresses beyond the gap limit.

- if lightning is enabled, propose to create a lightning-only invoice
- otherwise, propose to reuse an address
- never generate addresses beyond the gap limit

Implementation:
 - createDefaultRequest is removed
 - create_bitcoin_address is called whether the wallet has lightning
   or not
2023-03-18 12:58:42 +01:00
Sander van Grieken
cb4c99dc19 qml: styling CloseChannelDialog error text 2023-03-18 11:26:34 +01:00
ThomasV
8cc610298b QML: auto-delete expired requests. Add action to Qt menu 2023-03-18 09:59:18 +01:00
SomberNight
d8abab34d8 build: rm "non-free" from debian apt sources lists
was not needed, and better to avoid :)
2023-03-18 06:22:38 +00:00
ThomasV
f6699e01c3 qml: minor text change 2023-03-18 04:29:28 +01:00
Sander van Grieken
30034847a2 qml: remove Never as request expiry option 2023-03-18 00:57:39 +01:00
Sander van Grieken
39ac484ec7 qml: password change requires password, not PIN. fixes #8257 2023-03-18 00:52:42 +01:00
ThomasV
fed5fe5991 Qml: new receive flow. fixes #8258 2023-03-17 23:02:43 +01:00
SomberNight
adca13a86c android readme: update "access datadir on Android from desktop"
was getting `cp: /sdcard/some_path/my_wallet: Operation not permitted`
adb no longer has permissions to write to the sdcard

New command allows dumping the file directly to local pc via usb.

related:
https://stackoverflow.com/q/72714568
https://stackoverflow.com/q/18471780
2023-03-17 19:21:01 +00:00
SomberNight
48e37696b3 qml wizard: fix creating wallet from master key
fixes https://github.com/spesmilo/electrum/issues/8260
2023-03-17 18:31:50 +00:00
SomberNight
a90bff4586 qml: mark masterkey/wif/addr input fields as sensitive
related: https://github.com/spesmilo/electrum/issues/8256
2023-03-17 17:09:01 +00:00
Sander van Grieken
231ea5d03b qml: status icon InvoiceDialog 2023-03-17 17:33:00 +01:00
SomberNight
55da7276d3 qt export history/privkeys: put wallet name in path
closes https://github.com/spesmilo/electrum/issues/8255
2023-03-17 15:49:58 +00:00
SomberNight
8db1c3814b qt export history: let util.filename_field decide default path
which uses:
directory = config.get('io_dir', os.path.expanduser('~'))
2023-03-17 15:47:42 +00:00
Sander van Grieken
7d2ba3cc39 qml: fix 43d6fd2aef 2023-03-17 16:46:58 +01:00
Sander van Grieken
24a3d6e10f qml: remove editmode toggle, now enabled only on amount-less invoices 2023-03-17 16:46:58 +01:00
ThomasV
c3a0f9c078 Qt swaps_dialog: do not use side effects to update tx.
Use the app timer instead, so that the tx is not recomputed
on every slider move (like in ConfirmTxDialog).

A similar modification is needed for QML. I started with
Qt in order to get a sense of how it should be done.
2023-03-17 15:07:06 +01:00
Sander van Grieken
8eca3e0aaf follow up 7c2f13a76e 2023-03-17 12:33:53 +01:00
ThomasV
7c2f13a76e follow-up fcbd25c1fd. fixes #8253 2023-03-17 12:30:58 +01:00
Sander van Grieken
0b3279820a rm log 2023-03-17 12:01:55 +01:00
Sander van Grieken
8528907a5b qml: trsutedcoin layout consistency 2023-03-17 11:51:56 +01:00
Sander van Grieken
a571451179 qml: allow pay while amount in edit mode 2023-03-17 11:51:48 +01:00
ThomasV
fcbd25c1fd qml: display network status and history server status separately. Also, show network fees on full screen width 2023-03-17 10:15:07 +01:00
ThomasV
49683d6ff1 qml: do not set oneserver based on auto_connect. 2023-03-17 09:22:35 +01:00
Sander van Grieken
0bb41a32c8 qml: fix layout issues in ShowConfirmOTP. fixes #8249 2023-03-17 00:23:50 +01:00