AaronFiore/electrum
1
0
Fork 0
Code Activity
18,218 Commits 2 Branches 181 Tags
a99c454c00bb9256ffa4eeccc7c81a579aa66951
Commit Graph

18218 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
SomberNight
a99c454c00 plugin ConfigVars: enforce "key" starts with name of plugin 2025-03-19 16:49:56 +00:00
SomberNight
b132e357a3 plugin ConfigVars: define vars less dynamically 
and restore ability to have different internal ConfigVar name and user-visible "key"
(Keys are hard to change as that breaks compat, but it is nice to be able to change
the internal var name, to reorganise stuff sometimes. After new ConfigVars are added,
sometimes we get better insight into how the older ones should have been named.)

follow-up https://github.com/spesmilo/electrum/pull/9648
 2025-03-19 16:42:51 +00:00
ThomasV
0266832650 bump min version of electrum_aionostr and its dependencies 2025-03-19 16:21:09 +01:00
ThomasV
1e4728bdf1 Merge pull request #9560 from f321x/nostr_proxy 
Pass proxy settings to aionostr manager for submarine swaps
 2025-03-19 14:26:27 +01:00
ThomasV
e67cb560f6 Commands: add option documentation in docstring. 
This allows plugins to document the commands they add.

The docstring is parsed as a regular expression:

    arg:<type>:<name>:<description>\n

Types are defined in commands.arg_types.

Note that this commit removes support for single letter
shortcuts in command options.

If a command is not properly documented, a warning is issued
with print(), because no logger is available at this point.
 2025-03-19 13:03:38 +01:00
ThomasV
92b03d827c cmdline: suppress the display of global options when displaying the help of a command 2025-03-19 12:17:18 +01:00
ThomasV
d8964a00e7 config vars for plugins 2025-03-19 11:59:05 +01:00
ThomasV
647ae49451 Merge pull request #9651 from f321x/plugin_manifest_json 
Use manifest.json instead of loading init file for plugin registration
 2025-03-19 10:52:02 +01:00
f321x
a9f8048251 use manifest.json instead of loading init file for plugin registration 2025-03-19 10:38:20 +01:00
ThomasV
cbef1bc4b0 Merge pull request #9652 from SomberNight/202503_rm_ledger_hw1 
plugins: ledger: rm support for hw.1
 2025-03-19 08:04:16 +01:00
SomberNight
536fce3f94 cli: don't add wallet to running online GUI, if called with -o 2025-03-18 19:33:24 +00:00
SomberNight
d36e877eb8 lnworker: comment re hist: if paying MPP, amt and fee might be shifted 
a bit confusing behaviour
 2025-03-18 19:25:18 +00:00
ThomasV
26910ef81d Merge pull request #9620 from accumulator/lightning_pass_invoice_not_bolt11 
refactor lnworker.pay_invoice to accept Invoice object instead of bolt11 string
 2025-03-18 20:09:01 +01:00
SomberNight
4c970fd8fa plugins: ledger: better error msg for hw.1 2025-03-18 17:26:12 +00:00
SomberNight
154adf0081 plugins: ledger: rm support for hw.1 
This removes support for Ledger HW.1 and "Nano" (non-S) devices.
These were manufactured/sold around 2015-2016, and are long unsupported by the upstream vendor.

We previously added a deprecation warning to the GUI [0] released in 4.3.3 (2023-01-02), to warn owners of these devices.
This PR now fully removes support.

As a consequence, the unmaintained btchip-python dependency can now be removed, which solves [1].

[0]: 9b82eb6d06
[1]: https://github.com/spesmilo/electrum/issues/9370#issuecomment-2593675364
 2025-03-18 16:18:49 +00:00
SomberNight
7737dbf795 plugins: ledger: fix Ledger_Client_Legacy.sign_transaction 
regression from 2f1095510c
 2025-03-18 15:34:17 +00:00
ThomasV
38f9cac48c Merge pull request #9649 from f321x/move_commands_to_init 
Move plugin commands to init file of plugin
 2025-03-18 11:14:30 +01:00
f321x
e74029c880 move plugin commands to init file of plugin 2025-03-18 09:37:07 +01:00
ghost43
75cef43f9c Merge pull request #9650 from SomberNight/202503_keepkey 
plugins: keepkey: vendor our fork of keepkeylib (as git submodule)
 2025-03-17 18:27:42 +00:00
SomberNight
822ab5d73c requirements: follow-up prev: rm protobuf upper bound 
now that the keepkey pb2's are regenerated using the "new" format,
we don't need an old python3-protobuf to parse them

ref https://github.com/spesmilo/electrum/issues/7922
 2025-03-17 17:53:51 +00:00
SomberNight
c8143957a6 plugins: keepkey: rm dependence on external keepkeylib 
we will instead bundle our own fork, as a git submodule,
https://github.com/spesmilo/electrum-keepkeylib

related https://github.com/spesmilo/electrum/issues/7922
and https://github.com/keepkey/python-keepkey/issues/146
(i.e. upstream keepkeylib is unmaintained)
 2025-03-17 17:53:48 +00:00
SomberNight
457979ce63 plugin.py: fix plugin.read_file 
follow-up 246f03fe20
 2025-03-17 17:52:31 +00:00
ThomasV
e7907d31cc Merge pull request #9646 from f321x/plugins_import_dir_and_zip 
Allow all plugins to be either zip or directory based
 2025-03-17 16:41:37 +01:00
f321x
246f03fe20 allow all plugins to be either zip or directory based 2025-03-17 16:27:33 +01:00
ThomasV
bea4c617f6 Merge pull request #9645 from oren-z0/fix-base-tx-type 
fix base_tx type
 2025-03-17 14:04:44 +01:00
Oren
e658d9118a fix base_tx type 
base_tx in make_unsigned_transaction
is expected to be of type
Optional[Transaction], not boolean.
 2025-03-17 14:54:48 +02:00
ThomasV
3463e68306 add accounting addresses 2025-03-17 10:47:19 +01:00
ThomasV
2133427f53 fix issue #9543 2025-03-17 10:46:00 +01:00
ThomasV
58be5a3ad5 Allow wallets to use non-deterministic lightning, 
if they use a software keystore.

This excludes hardware wallets and watching-only wallet.
Also, this forbids creation of new channels in those wallets,
in case lightning was previously enabled.

Fixes #9440
 2025-03-17 09:51:52 +01:00
ThomasV
f8714dd57a fix #9635 2025-03-16 17:01:07 +01:00
ThomasV
9d1ffe0c37 support for arguments to plugin commands: 
- add a simple parser that only figures out where the config is,
   and does not complain if args are unknown
 2025-03-16 15:01:22 +01:00
ThomasV
d2fa404e06 plugin commands: load the plugin in func_wrapper 2025-03-16 12:26:31 +01:00
ThomasV
51890fd0b5 Merge pull request #9629 from f321x/plugin-commands 
Allow plugins to register CLI commands
 2025-03-16 12:09:09 +01:00
ThomasV
a474b8674d plugin commands: 
- make plugin commands start with plugin name + underscore
 - plugin_name must be passed to the plugin_command decorator
 - fixes:
    - remove plugin_commands (unneeded)
    - func_wrapper must await func()
    - setattr(Commands, name, func_wrapper)
 - add push/pull commands to labels plugin
 2025-03-16 11:53:34 +01:00
ThomasV
cb39737a39 Plugins call with cmd_only: 
- pass temporary config to Plugins
 - load only enabled plugins
 - parse the command line again after plugins are loaded
 2025-03-15 13:31:00 +01:00
ThomasV
4f79e516e4 run_electrum: add parse_command_line method 2025-03-15 13:22:28 +01:00
f321x
ae64583ebc add handling of plugin commands 2025-03-15 13:22:28 +01:00
ThomasV
61c5df8407 Merge pull request #9638 from f321x/140325-force-close-exception 
Fix anchor output sweeping bug creating invalid sweeping tx
 2025-03-14 19:39:32 +01:00
ThomasV
81d4e90f66 Merge branch 'master' into 140325-force-close-exception 2025-03-14 19:38:13 +01:00
SomberNight
2763e14bb3 commands: payto can just call paytomany 2025-03-14 17:38:45 +00:00
SomberNight
e7b42a7b81 Merge branch '202503_wallet_kill_createtx': kill create_transaction 2025-03-14 17:36:56 +00:00
SomberNight
977d8b1dd6 wallet: kill create_transaction 2025-03-14 17:19:41 +00:00
f321x
5edbf923cd fix sweeping anchor outputs with multiple change addresses option enabled, don't consider tx inputs sufficient value if there are no outputs so change outpu gets added 2025-03-14 18:15:04 +01:00
SomberNight
4689a0e78c wallet: towards killing create_transaction: rm "coins" logic 2025-03-14 17:14:59 +00:00
SomberNight
cab1dc5c29 wallet: towards killing create_transaction: pass through "locktime", "version" 2025-03-14 17:03:49 +00:00
SomberNight
3c3778db9c wallet: towards killing create_transaction: rm "sign" arg 2025-03-14 16:44:46 +00:00
SomberNight
fddd4275aa qt: move "FREEZE_REUSED_ADDRESS_UTXOS" option to utxo_list toolbar 
ref https://github.com/spesmilo/electrum/pull/9636
 2025-03-14 16:16:55 +00:00
SomberNight
656c109336 qt: refactor TxEditor preferences: use QMenuWithConfig 2025-03-14 16:05:40 +00:00
ghost43
e62a2c43c5 Merge pull request #9634 from SomberNight/202503_is_frozen_futuretx 
wallet: consider "future" coins as frozen by default
 2025-03-14 14:26:07 +00:00
ThomasV
39224f003d Merge pull request #9636 from SomberNight/202503_avoid_reuse 
wallet: add new config option "FREEZE_REUSED_ADDRESS_UTXOS"
 2025-03-14 12:56:29 +01:00