SomberNight
90579ccfea
kivy: fix paying bip70 invoices
...
this is a regression from #7234
2021-06-19 14:57:15 +02:00
ghost43
086c1397af
Merge pull request #7355 from SomberNight/202106_build
...
build: clean up build scripts, consolidate instructions, reduce code dupe
2021-06-18 15:44:50 +00:00
SomberNight
9d46fe775a
build: try to consolidate instructions and decr codedupe in release.sh
2021-06-18 17:10:15 +02:00
SomberNight
91c913dc0b
build/release.sh: add some comments
2021-06-18 16:29:13 +02:00
SomberNight
47ebc49c4c
(trivial) build/release.sh: convert indents to spaces
...
was mixed tabs/spaces
2021-06-18 16:29:08 +02:00
SomberNight
3df1c3bbf7
build: rename some scripts
...
also, merge sdist/build.sh and sdist/make_tgz into sdist/make_sdist.sh
2021-06-18 16:29:03 +02:00
SomberNight
0842f4977b
build: fresh_clone: turns out we can just clone from a local dir :P
...
this saves us some network requests, and reduces trust in github
2021-06-18 16:28:58 +02:00
SomberNight
5ae167d67d
android build: place binaries in ./dist/ instead of ./bin/
...
Let's try to consolidate and have all build scripts put binaries into ./dist/
2021-06-18 16:28:52 +02:00
ThomasV
9625798a63
release script: follow-up prev commit
2021-06-17 15:02:07 +02:00
SomberNight
2c8f376d3d
prepare release 4.1.4
4.1.4
2021-06-17 14:03:06 +02:00
SomberNight
66f68d6b1f
commands: fix "close_wallet" cmd, which was deadlocking
...
fixes #7348
2021-06-17 12:35:31 +02:00
ThomasV
66628c0bad
contrib/upload: use abbrev=0
2021-06-17 12:18:47 +02:00
ThomasV
9c1a8d7f65
release.sh: fix path for android builds
2021-06-17 12:15:09 +02:00
SomberNight
d3276ee950
build-wine/unsign.sh: allow using before files are uploaded publicly
2021-06-17 12:12:11 +02:00
SomberNight
52fc2f5adb
release.sh: make sure correct commit is checked out
2021-06-17 12:05:40 +02:00
SomberNight
c49d6995d2
kivy: fixes regression where non-LN wallet cannot open settings...
...
fixes https://github.com/spesmilo/electrum/issues/6262#issuecomment-863087368
2021-06-17 11:48:58 +02:00
SomberNight
81a71ec09b
update locale; again :P
...
c2c845a82d accidentally undid the previous update
2021-06-16 20:28:00 +02:00
ThomasV
c2c845a82d
follow-up 8ff49fa9bb
4.1.3
2021-06-16 17:14:06 +02:00
SomberNight
60debf9116
update locale
2021-06-16 16:59:44 +02:00
ThomasV
8ff49fa9bb
Remove signature verification from make_download. Signatures are verified by the website, before deployment.
2021-06-16 16:54:02 +02:00
SomberNight
b1ea3d07ef
pubkeys: add new gpg key I will use to sign releases from now on
...
Also update existing key with some signatures.
Now both keys have ThomasV's sig,
and they cross-sign each other.
I will use sombernight_releasekey to sign releases, and keep using the
older key to sign commits and other day to day stuff. As I use a separate
key to sign commits, the release key can be made hard to get to.
2021-06-16 16:20:49 +02:00
SomberNight
d55fce4edd
prepare release 4.1.3
2021-06-16 14:50:39 +02:00
SomberNight
fbd8c5f7b0
imported wallets: respect "use_change" option; default off
...
Imported wallets used to send change back to the "from address".
We keep this behaviour as default.
There has already been an option "Use change addresses" (exposed in GUI),
ignored so far by imported wallets (was only used by HD wallets).
With this change, imported wallets no longer ignore that option, and if set,
they will send change to a random unused imported address, instead of back to "from address".
If all addresses are used, it falls back to sending change back to the "from address".
see: https://github.com/spesmilo/electrum/pull/7330
see: https://github.com/spesmilo/electrum/issues/5353
2021-06-11 20:12:43 +02:00
SomberNight
8941ba90bd
(trivial) wallet: rename parameter of a method
...
Re get_change_addresses_for_new_transaction,
"allow_reuse" is a confusing parameter name:
it means whether we allow reusing already used change addresses to send new change to.
However, if the method returns [], we will instead reuse the "from address" and send change there.
So it quite unclear without thinking it through what "allow_reuse" means as it could be either
of the two (and they are ~opposite scenarios).
The new name is long but at least it is clear.
2021-06-11 18:23:25 +02:00
SomberNight
3adb309d49
kivy settings: more intuitive "recoverable channels" toggle
...
Previously if the wallet did not have a deterministic node id,
the wallet info dialog could say "lightning enabled, non-recoverable channels", but
the "recoverable channels" setting could be toggled and might even say "yes".
2021-06-11 15:00:06 +02:00
SomberNight
325cd950a4
kivy: settings dialog: call update() from __init__
...
this is a clearer/easier-to-understand API
2021-06-11 14:51:09 +02:00
ThomasV
ad06398e4e
lnworker: rm unused import
2021-06-11 12:27:05 +00:00
ghost43
8abbcbff5a
Merge pull request #7292 from bitromortac/2105-inflight-htlcs
...
lnrouter: add inflight htlcs to liquidity hints
2021-06-10 16:54:48 +00:00
SomberNight
7ee4a2e299
follow-up prev
2021-06-10 18:52:12 +02:00
SomberNight
f52c0fd571
lnchannel: rm HTLC value upper limit of ~42 mBTC
...
closes #7328
closes #7100
see https://github.com/lightningnetwork/lightning-rfc/pull/877#issuecomment-857577075
2021-06-10 17:26:04 +02:00
SomberNight
dab25e3b24
android build: add exec permission to apkdiff.py, and print hashes
2021-06-10 16:41:37 +02:00
ThomasV
4dc7f4d331
release script: call build_docker_image.sh
2021-06-10 14:40:46 +00:00
ThomasV
8788b64504
Update release script with APK fresh clone instruction. Add android/fresh_clone to gitignore
2021-06-10 14:30:17 +00:00
ghost43
c43896fe6a
Merge pull request #7263 from SomberNight/202104_android
...
reproducible build for Android apk
2021-06-10 13:19:41 +00:00
SomberNight
45cb8b5b02
android reproducibility: add Signal's "apkdiff.py" tool, and instructions
2021-06-09 18:34:15 +02:00
SomberNight
3c9346cce2
android build: attempt at reproducible builds
2021-06-09 18:34:09 +02:00
ThomasV
0f4f5e5fb7
Merge pull request #7341 from SomberNight/202106_issue7339
...
wallet: fix channels backups in .backup files
2021-06-09 17:38:50 +02:00
SomberNight
53d6eeb3f3
wallet: rm get_txout_address method
2021-06-08 16:45:30 +02:00
Nima
13e4424922
cmd: add sign with privkey and wallet ( #7147 )
...
* Remove check for sign with privkey in init_cmdline
* Add with_privkey and with_wallet variants of signtransaction command
* Add unit tests for signtransaction_with_privkey and signtransaction_with_wallet commands
2021-06-08 14:33:55 +00:00
SomberNight
34c2cb5220
wallet: fix channels backups in .backup files
...
This is a regression from 64a931f21e ,
which introduced "onchain_channel_backups", and renamed
the old "channel_backups" key to "imported_channel_backups".
The `save_backup` method was not changed to use the new "imported_channel_backups" key,
so the channel backups are in the backup file but they are ignored.
2021-06-08 16:21:43 +02:00
SomberNight
7e6d65ec11
wallet: RBF batching to only consider RBF-opted-in txs, even if local
...
This is easier to understand; the special case is not worth it.
related https://github.com/spesmilo/electrum/issues/7298
2021-06-07 20:11:56 +02:00
Thorsten Hempel
fbf76af2c5
Update wallet backup access ( #7300 )
2021-06-07 16:46:25 +00:00
SomberNight
6c69c73a9f
wallet: add address corruption tests for imported wallets too
...
related: https://github.com/spesmilo/electrum/issues/7338
2021-06-07 18:30:24 +02:00
SomberNight
a425ab0301
invoices/lnaddr: LNInvoice.from_bech32 now raises InvoiceError
...
rm LnAddressError
fixes https://github.com/spesmilo/electrum/issues/7321
related https://github.com/spesmilo/electrum/pull/7234
2021-06-07 14:46:30 +02:00
SomberNight
eb6b4580e8
fix tests: adapt to breaking change of ipaddress.ip_address in py3.9.5
...
fixes https://github.com/spesmilo/electrum/issues/7307
We can simply remove that test as we don't actually care whether the
leading zeroes are allowed.
see 60ce8f0be6
see https://bugs.python.org/issue36384
2021-06-05 08:01:38 +02:00
ghost43
e7c7a2a834
Merge pull request #7308 from bitromortac/2105-fix-cmd-reverse-swap
...
swaps: fix satoshi conversion bug
2021-06-05 05:35:46 +00:00
SomberNight
cd50472b18
kivy: (fix) forbid creating LN payreq if LN is disabled for wallet
...
fix #6346
see https://github.com/spesmilo/electrum/issues/6346#issuecomment-854655931
2021-06-04 14:11:19 +02:00
Thorsten Hempel
b990ff78a5
appimage: update libc6-dev package ( #7299 )
2021-06-04 08:36:23 +00:00
bitromortac
3c02f6b922
swaps: fix satoshi conversion bug
2021-05-19 07:27:54 +02:00
SomberNight
cad4e77853
fix prev
2021-05-15 06:57:59 +02:00