AaronFiore/electrum
1
0
Fork 0
Code Activity
13,798 Commits 1 Branch 181 Tags
6c69c73a9f2237ec44868db985aa9c68c5bfb5ec
Commit Graph

13798 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
SomberNight
6c69c73a9f wallet: add address corruption tests for imported wallets too 
related: https://github.com/spesmilo/electrum/issues/7338
 2021-06-07 18:30:24 +02:00
SomberNight
a425ab0301 invoices/lnaddr: LNInvoice.from_bech32 now raises InvoiceError 
rm LnAddressError

fixes https://github.com/spesmilo/electrum/issues/7321
related https://github.com/spesmilo/electrum/pull/7234
 2021-06-07 14:46:30 +02:00
SomberNight
eb6b4580e8 fix tests: adapt to breaking change of ipaddress.ip_address in py3.9.5 
fixes https://github.com/spesmilo/electrum/issues/7307

We can simply remove that test as we don't actually care whether the
leading zeroes are allowed.

see 60ce8f0be6
see https://bugs.python.org/issue36384
 2021-06-05 08:01:38 +02:00
ghost43
e7c7a2a834 Merge pull request #7308 from bitromortac/2105-fix-cmd-reverse-swap 
swaps: fix satoshi conversion bug
 2021-06-05 05:35:46 +00:00
SomberNight
cd50472b18 kivy: (fix) forbid creating LN payreq if LN is disabled for wallet 
fix #6346

see https://github.com/spesmilo/electrum/issues/6346#issuecomment-854655931
 2021-06-04 14:11:19 +02:00
Thorsten Hempel
b990ff78a5 appimage: update libc6-dev package (#7299) 2021-06-04 08:36:23 +00:00
bitromortac
3c02f6b922 swaps: fix satoshi conversion bug 2021-05-19 07:27:54 +02:00
SomberNight
cad4e77853 fix prev 2021-05-15 06:57:59 +02:00
SomberNight
b2169b745e wallet: (fix) "batch_rbf" must not mutate LN funding txs 
The "Batch RBF transactions" feature mutates existing "local" and "unconfirmed RBF"
transactions when creating new transactions: it simply adds the new outputs to the
existing txs (and updates the change).
The "RBF" flag is only enforced for unconfirmed txs, not for local txs.
The bug was that given a local LN funding tx, when creating a new channel
with "batch_rbf" enabled, we would modify the existing local tx, and
broadcast that.

related: #7298
 2021-05-15 06:31:03 +02:00
SomberNight
9c1a51547a kivy: (trivial) clean-up imports in screens.py 2021-05-06 18:19:55 +02:00
SomberNight
3b0209a3a5 follow-up prev 2021-05-06 18:18:52 +02:00
ghost43
dd84acc109 Merge pull request #7234 from bitromortac/2104-invoice-amt-7184 
invoice: fail gracefully with large amount
 2021-05-06 15:43:36 +00:00
bitromortac
853e912885 invoice: fail gracefully with large amount 2021-05-06 15:37:17 +02:00
bitromortac
6ce96306ca util: check bip21 url for amount 2021-05-06 15:37:17 +02:00
SomberNight
5dcafaf082 mac build: link to issue in README 2021-05-01 06:40:28 +02:00
SomberNight
ef3293ab6a kivy: relocate atlas so it can be made a submodule later 2021-04-30 16:44:32 +02:00
jpph
0a56404f28 bip39 auto import, add coolwallet S weird derivation path (#7261) 
auto import, add coolwallet S weird derivation path #7259

Would be nice to auto detect also coolwallet S derivation path.
In file bip39_wallet_formats.json :
{ "description": "coolwallet S derivation path using bip44 but with segwit script format",
"derivation_path": "m/44'/0'/0'",
"script_type": "p2wpkh-p2sh",
"iterate_accounts": true
}
see https://help.coolwallet.io/article/160-recover-btc-using-coolwallet-s-seed-without-the-wallet for their recovery instruction
 2021-04-30 13:13:01 +00:00
ghost43
1e34b96725 Merge pull request #7258 from bitromortac/2104-openchannel-7219 
kivy: improve openchannel dialog for trampoline
 2021-04-30 11:41:27 +00:00
bitromortac
97b31880d7 kivy: improve openchannel dialog for trampoline 2021-04-30 13:32:07 +02:00
ThomasV
7789497140 release script: add username to signature file, upload files into airlock. 2021-04-30 10:27:33 +00:00
ThomasV
2b05615995 Do not perform webserver update from release script. 
(see publish.sh and deploy.sh in the electrum-web repo)
 2021-04-28 12:37:15 +00:00
SomberNight
1dfa81e7b6 contrib: fix find_restricted_dependencies for deps with version range 
New release of pyinstaller (4.3) broke the script (which is used by freeze_packages.sh).

-----

Compare:

$ wget https://pypi.org/pypi/pyinstaller/4.3/json
$ cat json | jq ".info.requires_dist"
[
  "setuptools",
  "altgraph",
  "pyinstaller-hooks-contrib (>=2020.6)",
  "importlib-metadata ; python_version < \"3.8\"",
  "macholib (>=1.8) ; sys_platform == \"darwin\"",
  "pefile (>=2017.8.1) ; sys_platform == \"win32\"",
  "pywin32-ctypes (>=0.2.0) ; sys_platform == \"win32\"",
  "tinyaes (>=1.0.0) ; extra == 'encryption'",
  "pytest (>=2.7.3) ; extra == 'hook_testing'",
  "execnet (>=1.5.0) ; extra == 'hook_testing'",
  "psutil ; extra == 'hook_testing'"
]

$ wget https://pypi.org/pypi/pyinstaller/4.2/json | jq .
$ cat json | jq ".info.requires_dist"
null

$ wget https://pypi.org/pypi/qrcode/6.1/json
$ cat json | jq ".info.requires_dist"
[
  "six",
  "colorama ; platform_system == \"Windows\"",
  "tox ; extra == 'dev'",
  "pytest ; extra == 'dev'",
  "mock ; (python_version < \"3\") and extra == 'dev'",
  "zest.releaser[recommended] ; extra == 'maintainer'",
  "pillow ; extra == 'pil'",
  "pytest ; extra == 'test'",
  "pytest-cov ; extra == 'test'",
  "mock ; (python_version < \"3\") and extra == 'test'"
]
 2021-04-26 20:45:40 +02:00
ghost43
de716ab07c Merge pull request #7247 from bitromortac/2104-fix-liquidity-hints 
lnworker: fix path_finder access
 2021-04-26 15:17:40 +00:00
SomberNight
8bba3b9ef5 network: also clear network.path_finder in stop_gossip 
stop_gossip should undo start_gossip

related: #7242
 2021-04-26 17:06:52 +02:00
ThomasV
04b1e8718a tx dialog (Qt): if possible, save psbt and fully signed transaction under the same basename. 2021-04-26 12:31:04 +02:00
bitromortac
4cb0b99996 lnworker: fix path_finder access 2021-04-26 08:43:50 +02:00
ThomasV
4411652b1c Merge pull request #7238 from SomberNight/202104_qt_send_max_tooltip 
qt send tab: when clicking "Max", show tooltip explaining max amt
 2021-04-23 20:22:53 +02:00
SomberNight
86ba37dc1c qt send tab: when clicking "Max", show tooltip explaining max amt 
Beginner users often ask why they cannot send their full balance.
Hence, this intends to reduce support load.
In terms of UI, maybe there is a better way to do this but this was
easy to do and still a good first step IMHO.
 2021-04-23 17:52:19 +02:00
SomberNight
37bde9baf9 qt: cpfp: fix handling "no dynamic fee estimates" 
fixes #7237
 2021-04-23 17:27:00 +02:00
ghost43
ecb083b283 Merge pull request #7231 from bitromortac/2104-fix-swap-check 
swaps: fix swap sanity check
 2021-04-23 12:57:44 +00:00
bitromortac
b97e51dbd8 swaps: fix off-by-one sanity check 
Tolerates discrepancies in the swap amount crosschecks. To ensure we
calculate the send/receive amounts correctly we apply a check, using
amount inversion. The inversion is not exact up to +-1 due to used
floor and ceil functions in the methods. They are not invertible,
which is why we relax the check to off-by-ones.
 2021-04-23 07:43:36 +02:00
SomberNight
1436760d3d qt coins tab: Ctrl+F now searches the whole prevout string 
(not just the truncated string that is displayed in the list)
 2021-04-22 20:56:00 +02:00
SomberNight
3b77340671 Qt MyTreeView: rm usages of Qt.UserRole, use explicit roles instead 
This is a bit more verbose but it explicitly shows what data is being
used where.

Also rm implicitly setting editable_columns based on stretch_column.
 2021-04-22 20:37:14 +02:00
SomberNight
720d60c391 (trivial) rm dead code 
follow-up #7152
 2021-04-22 17:57:50 +02:00
SomberNight
af44c846cc tests: add test for payto command 2021-04-22 17:13:56 +02:00
ghost43
0f83270053 Merge pull request #7152 from bitromortac/2103-liquidity-hints 
Liquidity hints for pathfinding
 2021-04-22 14:45:41 +00:00
SomberNight
bb381a263a android build: update p4a/buildozer to latest upstream 
Rebased our branches on latest p4a develop HEAD and buildozer master HEAD.

Re `android.allow_backup = False` in buildozer.spec, now that this setting
has been exposed to buildozer.spec (see https://github.com/kivy/buildozer/pull/1206),
we could finally drop a commit from our branch that did the same:
7a7d415d90

Re commenting out `android.arch` in buildozer.spec, we are setting this
via the ENV VAR in make_apk.
 2021-04-21 20:04:37 +02:00
ThomasV
8ce94248d4 kivy: update wizard message: pin->password 2021-04-21 10:33:11 +02:00
SomberNight
11bb39ee82 kivy: implement freezing channels 2021-04-19 18:57:47 +02:00
SomberNight
4e0a20ae46 gui messages: mv one more message to messages.py 2021-04-19 18:57:43 +02:00
SomberNight
0ab9687734 kivy: make ActionDropdown disappear when an action is selected 2021-04-19 18:57:39 +02:00
SomberNight
e15a11a437 kivy: use ActionDropdown in ChannelDetailsPopup 2021-04-19 18:04:15 +02:00
SomberNight
b8ec85d615 kivy tx dialog: abstract away ActionDropdown, mv into its own file 2021-04-19 18:01:22 +02:00
SomberNight
b27925c6c5 kivy tx dialog: dscancel btn text was too long 
see first part of #6868
 2021-04-19 16:40:57 +02:00
SomberNight
4f6c0c2c61 kivy bump fee dialog: handle no dynamic fee estimates 
fix #7220
 2021-04-19 16:06:43 +02:00
ThomasV
8f95dc2640 Merge pull request #7211 from SomberNight/202104_keep_early_logs 
logging: don't lose log messages during early startup
 2021-04-18 20:56:24 +02:00
ThomasV
d8c6753e88 Merge pull request #7218 from verretor/2021-04-qrcodes 
Avoid hiding QR codes with help_text
 2021-04-18 10:52:23 +02:00
Benoit Verret
2cc16f8ed4 Avoid hiding QR codes with help_text 
In some situations, if a QR code's data and help_text were too long,
the QR code was unscannable.
 2021-04-17 22:54:37 -04:00
ThomasV
7c3f1d9e65 appimage: update libudev-dev package 2021-04-17 12:16:54 +02:00
ThomasV
75d77c55d6 commands, input sanitization: allow 'max' amounts only in specific contexts (payto, paytomany) 2021-04-16 16:03:25 +02:00