SomberNight
120da2783b
util.randrange: use stdlib 'secrets' module instead of 'python-ecdsa'
2020-11-07 19:26:30 +01:00
SomberNight
1c07777e13
follow-up prev
...
ah, forgot to commit this file
2020-11-05 03:10:06 +01:00
SomberNight
c616c3bfad
plugins/labels: better error message when using imported wallets
...
see #6703
2020-11-05 01:59:19 +01:00
SomberNight
193c29af87
wizard, multisig: on bip39/hw ks, only ask for script type for 1st ks
...
When setting up a multisig wallet, there is no point in asking for the
script type for each cosigner (bip39/hw) -- we can just ask for the
first one. If the first keystore is an electrum seed, we end up never asking :)
2020-11-05 01:02:11 +01:00
SomberNight
cc33b752e2
wizard: on adding bip39/hw ks, don't offer path scanning for multisig
...
follow-up #6219
for multisig, it's just confusing and useless as-is
2020-11-05 00:18:54 +01:00
SomberNight
fc97181aa5
config: fix get_fee_text for static fees
...
mismatching units
2020-11-04 01:49:57 +01:00
SomberNight
de80f68e4d
interface: validate protocol-version negotiation on client-side too
...
related: https://github.com/romanz/electrs/issues/314
2020-11-03 20:45:31 +01:00
ThomasV
70b03cb920
Merge pull request #6698 from SomberNight/202010_qt_pay_ellipsis_dotdotdot
...
qt gui: send tab: change "Pay" button text to "Pay..."
2020-10-29 10:58:20 +01:00
SomberNight
802fe8c73a
qt user interface: send tab: change "Pay" button text to "Pay..."
...
Ellipsis ("...") is sometimes used in UIs to suggest there will be an
additional modal dialog before executing the action.
2020-10-29 01:58:34 +01:00
ThomasV
c31ae86bb8
Merge pull request #6634 from SomberNight/202010_fix_main_script_hanging
...
fix main script hanging (not exiting after exception) in some cases
2020-10-28 16:22:39 +01:00
SomberNight
ea22d0073e
config: distinguish knowing mempool is empty vs not having mempool_fees
...
config.mempool_fees is now [] if server claims mempool is ~empty,
and None if no valid histogram has been received from server.
(previously it used to be [] in both cases)
2020-10-27 18:55:39 +01:00
SomberNight
2232955a23
synchronizer: fix request_missing_txs(..allow_server_not_finding_tx=True)
...
fixes #6686
2020-10-26 14:29:10 +01:00
SomberNight
5481fd8af6
interface: validate field order in "mempool.get_fee_histogram" response
2020-10-26 02:07:30 +01:00
SomberNight
25d4a40d6e
qt history tab: fix shortcut in HistoryModel.refresh()
2020-10-25 06:55:10 +01:00
SomberNight
b95525896f
qt send tab: show friendlier error on mistyped bitcoin address
2020-10-25 04:24:31 +01:00
ghost43
8e9d6a4c91
Merge pull request #6685 from SomberNight/202010_bitcoin_script
...
bitcoin/transaction: construct_script, and clean-ups
2020-10-24 23:06:55 +00:00
SomberNight
200f547a07
ledger: fix compat with hw.1 - signing flow deadlocked
...
broke in 8a1b46d839ac24f77bfa5e3a1eed0cb7284b59eac5b685854c517f224c98dc44
2020-10-24 23:32:18 +02:00
SomberNight
03bdb4f1b7
Transaction.get_preimage_script: support custom legacy-p2sh inputs
...
tests based on
- 8ca383c9e0/python/elec-p2sh-hodl.py
- 8ca383c9e0/python/elec-p2wsh-hodl.py
note: I could not reproduce the signature for the p2wsh cltv spend linked above,
so I have created a new testnet output and spent that for that test (to make sure
our behaviour is consensus-valid).
2020-10-24 08:26:11 +02:00
SomberNight
eefb68c82b
transaction: change Transaction.is_segwit_input(txin) to txin.is_segwit()
2020-10-24 08:03:13 +02:00
SomberNight
4c7a92f39c
bitcoin: implement construct_script and use it
2020-10-24 07:49:06 +02:00
SomberNight
89bd520185
bitcoin: move construct_witness from transaction.py to bitcoin.py
2020-10-24 05:18:16 +02:00
ThomasV
59f7d4b02d
fix #6676 and remove dead code
2020-10-23 11:31:04 +02:00
Zibster43
fcccb99a3b
Remove phishing server ( #6660 )
...
Currentlane.lovebitco.in is being actively used in the phishing attack against Electrum users.
This can be confirmed by looking at https://ra.pe or https://hodlister.co/server-verification.txt ,
the server points directly to an ip in the /24 range being used by phishing ElectrumX servers (46.148.231.31) (https://check-host.net/ip-info?host=currentlane.lovebitco.in )
You can also confirm this by connecting directly to the node and attempt to broadcast a transaction.
2020-10-23 02:17:31 +00:00
SomberNight
ee24c74f19
lnchan.receive_revocation: tolerate not having htlc fail reason
...
If we get a revack after reestablish, but the fail_htlc was already
committed in a previous app-session, the fail_htlc will not be re-sent and
we will not have the reason (as it's not persisted).
fixes #6675
2020-10-23 02:35:20 +02:00
ThomasV
7110fde25d
follow-up: fix qt lightning dialog if gossip is not started
2020-10-22 19:20:22 +02:00
ThomasV
f155f3aff5
start lngossip if instantiated; this saves a boolean
2020-10-22 18:48:27 +02:00
ThomasV
5d90790726
wallet.py: always instantiate lnbackups
2020-10-22 18:35:49 +02:00
bitromortac
1855bcb17d
qt: reflect running gossip in lightning icon
2020-10-22 18:05:51 +02:00
bitromortac
750147d931
kivy: display warning when first channel is opened
2020-10-22 18:05:51 +02:00
bitromortac
6a0ada3f79
qt: display warning when first channel is opened
2020-10-22 18:05:51 +02:00
bitromortac
bdca7be1c7
kivy: remove enable/disable button
2020-10-22 18:05:51 +02:00
bitromortac
bba995ada3
qt: remove enable/disable button
2020-10-22 18:05:51 +02:00
bitromortac
3c3a59c517
cli: remove enable/disable lightning
2020-10-22 18:05:51 +02:00
bitromortac
3314c149f2
qt: show channels tab by default if ln wallet
2020-10-22 18:05:51 +02:00
bitromortac
42df51f2dd
qt: remove node suggestion
2020-10-22 18:05:51 +02:00
bitromortac
b543874670
gossip: start gossiping when channel is open
2020-10-22 18:05:51 +02:00
bitromortac
4efcb53d24
network: load gossip db early
...
The gossip db is loaded early when the network is started to save
time when the gui is locked and a wallet not yet loaded. Side effects
of the LNWallet to start peering when a channel db is loaded is
circumvented.
2020-10-22 18:05:51 +02:00
bitromortac
6045de759b
lightning: enable by default but without gossip
...
Enables lightning by creating a node private key and storing it in
the wallet. The gossiper is not launched at start up, only if there
are existing channels.
2020-10-22 18:05:51 +02:00
ThomasV
edc593a886
submarine swap: add comment to explain witness script asymmetry
2020-10-22 17:24:44 +02:00
SomberNight
08f70420e3
submarine_swaps: describe event-flow for both swap direction in docstr
...
So that I don't have to figure out every time.
2020-10-22 17:22:35 +02:00
SomberNight
21e46fb147
contrib: add instructions re cross-compiling libsecp to Linux x86
...
related: #6669
(note that instructions assume this commit as otherwise AUTOCONF_FLAGS is overwritten!)
based on https://stackoverflow.com/a/17748092
2020-10-21 03:27:42 +02:00
SomberNight
914b606cb9
kivy: fix app not even starting
...
```
File "/home/user/venvs/electrum37/lib64/python3.7/site-packages/kivy/lang/builder.py", line 654, in _apply_rule
child = cls(__no_builder=True)
TypeError: __init__() got an unexpected keyword argument '__no_builder'
```
follow-up c70484455c
2020-10-20 14:55:39 +02:00
SomberNight
8ac6d3b17d
wallet.get_history: take locks.
...
Re the check at the end: "history not synchronized" - it's not that it's not synchronized,
rather that the history is changing while being computed.
2020-10-18 22:21:06 +02:00
SomberNight
777095fda8
wallet: simplify get_history
...
some years ago wallet.get_tx_delta returned Optional[int] but it returns int now
2020-10-18 22:14:52 +02:00
SomberNight
f125a06453
wallet: simplify get_wallet_delta
2020-10-18 20:37:29 +02:00
SomberNight
da6080421e
wallet_db: WalletDB.get_txo_addr now returns dict instead of list
2020-10-18 20:37:25 +02:00
SomberNight
e71fa4924f
wallet: rm wallet.txin_value
2020-10-18 20:37:21 +02:00
SomberNight
8b2eb83238
wallet: use get_txin_value in get_wallet_delta
2020-10-18 20:37:18 +02:00
SomberNight
55b5335ebb
qt tx dialog: always show input amounts if we know them
...
Previously we would only show input amounts for partial txs.
Now also show them for complete txs as well, if we know them:
we check in the wallet db for the prevtx and read the value for the output.
This is safe as the input commits to the prevout via txid (which commits to the output value).
Also show "from addresses" in more cases in a similar fashion.
2020-10-18 20:37:14 +02:00
SomberNight
82c8c4280f
lnworker: add request_remote_force_close which can be used without state
...
see #6656
2020-10-17 03:59:50 +02:00