AaronFiore/electrum
1
0
Fork 0
Code Activity
15,900 Commits 2 Branches 181 Tags
0bb41a32c849ee9bcdb2c3a8be90e59716068b2c
Commit Graph

15900 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sander van Grieken
0bb41a32c8 qml: fix layout issues in ShowConfirmOTP. fixes #8249 2023-03-17 00:23:50 +01:00
Sander van Grieken
3e5c692660 qml: don't log (potentially) sensitive data, closes #8124 2023-03-17 00:13:16 +01:00
ThomasV
3574c99275 qml: in the password dialogs, disable the password confirmation 
line if the first entered password is too short.

Without that, a user may enter two passwords that are identical
but too short, and then click on the eye icon in order to discover
that they actuall are identical.. and only at this point guess that
the size might be the problem.

Also, raise the minimum length to 6, because that is what is was
on Kivy.

One of the password dialogs still had two eye icons; that was only
fixed in the wizard. I guess that could be avoided if both dialogs
used the same code.
 2023-03-16 20:51:17 +01:00
SomberNight
ff2da7ceb9 crash reporter: hardcode gui text. do not trust the server with it 
paranoia.
 2023-03-16 19:48:35 +00:00
ThomasV
849d987d0d qml: fix #8247 2023-03-16 20:23:29 +01:00
ThomasV
57a4cbb984 follow-up 7a86d8d: ask proxy first 2023-03-16 20:07:58 +01:00
ThomasV
6890268b1d qml: fix display of server fee in swap dialog 
The previously displayed amount was not the percentage,
but the mining fee plus the percentage.
 2023-03-16 19:29:56 +01:00
SomberNight
d4d6d05d9f qml wizard: enable restore from "2fa" legacy seeds 
not sure why it was disabled, there should be no meaningful distinction at that point
 2023-03-16 17:40:30 +00:00
ThomasV
13a9d1e2fb Add info on how to scan channel backups 2023-03-16 17:24:07 +01:00
ThomasV
2ef60b906f Reword proxy question. 
The second alternative in previous phrase can be misinterpreted as:
'Do you want to connect to the internet through an ISP?'
 2023-03-16 17:12:21 +01:00
SomberNight
0a5d18634c exchange_rate: guard against garbage hist data coming from exchange 
See discussion at 583089d57b (r104678577)
CoinGecko for PLN gives "None" str as rate (instead of null) for two months mid-2014:
```
  2.29 | D | exchange_rate.CoinGecko | found corrupted historical_rate: rate='None'. for ccy='PLN' at 2014-05-10
```
Thanks to @lukasz1992 for reporting.
 2023-03-16 16:11:02 +00:00
ThomasV
7207f13e97 Qt: set history_rates both through settings_dialog and history_list 
follow-up 503776c0de
 2023-03-16 16:48:12 +01:00
SomberNight
3a7bc82881 icons: add "cloud_yes.png", and rename existing "nocloud" 2023-03-16 15:22:10 +00:00
Sander van Grieken
7a86d8dc9e qml: ask user whether to configure Tor or other proxy before presenting proxy detail config screen 2023-03-16 15:42:24 +01:00
Sander van Grieken
39eaf9d871 qml: sharing channel backup only shows QR, not the data as text 2023-03-16 15:12:51 +01:00
Sander van Grieken
d985c9eecc qml: use InfoTextArea for help text in GenericShareDialog 2023-03-16 15:10:42 +01:00
Sander van Grieken
67cb08a835 qml: slider render voids 2023-03-16 15:03:05 +01:00
Sander van Grieken
f49ef14de8 qml: SwapDialog slider styling; add zero tick and fill slider range from zero 2023-03-16 14:14:46 +01:00
ThomasV
e2867b7fe8 qml: move Pay button to the right 
the default action should always be to the right side, because
right-handed people are dominating the world :-).
 2023-03-16 13:02:54 +01:00
ThomasV
3334b2f731 follow-up qml slider: remove unneeded setters 2023-03-16 12:28:44 +01:00
Sander van Grieken
64dde8bc0b qml: show disconnected state in BalanceSummary 2023-03-16 12:19:38 +01:00
ThomasV
5b8fdacac9 qml: ensure that the slider neutral position is in the middle of the screen 2023-03-16 12:13:14 +01:00
Sander van Grieken
f0d44d0681 qml: expand clickable area to full toolbar height and a bit more padding for right-side menu 2023-03-16 12:09:57 +01:00
Sander van Grieken
b59a1410a2 qml: fix network histogram gradient fee range to 600-1 2023-03-16 11:57:35 +01:00
Sander van Grieken
46d5fdbc86 qml: PIN protect wallet seed display 2023-03-16 11:45:28 +01:00
Sander van Grieken
6d67f51e44 qml: show fiat state only for non-lightning wallets 2023-03-16 11:29:49 +01:00
ThomasV
c5dc133c4c qml: use daemon threads 
Without this, if a user starts a lightning payment and quits the
app before the payment succeeds or fails, the app hangs indefinitely
and needs to be killed, because the future never returns.
 2023-03-16 10:38:35 +01:00
Sander van Grieken
bcb06e5075 qml: set default minimum histogram if histogram empty 2023-03-16 10:25:15 +01:00
Sander van Grieken
8db2dcabe3 qml: Invoice Dialog technical details header only relevant for lightning 2023-03-16 10:11:33 +01:00
ThomasV
337d2a32d8 qml PIN: do not lock inactive app, and remove timeout 
- the activity callback does not work properly on android
  (does not work on my phone). Also, it duplicates the lock
  screen function of most phones.

- if we do not lock inactive app, then the PIN feature does
  not need a timeout, and is easier to understand without it.

- in Preferences, explain what it does
 2023-03-16 09:37:43 +01:00
ThomasV
09afacd51c qml: fix logical error with PIN code timeout. 2023-03-16 08:29:36 +01:00
ThomasV
43d6fd2aef qml: use get_node_alias in name_for_node_id. 
(fixes crash caused by lnworker.channel_db being None with trampoline.)
 2023-03-16 08:26:57 +01:00
ThomasV
4e2b7c6ab3 qml: remove requestExpiry from preferences dialog (redundant) 2023-03-16 05:51:57 +01:00
ThomasV
4872ec75ff add initial release notes for 4.4.0 2023-03-15 16:31:13 +01:00
ThomasV
91f36db8ef type checking, follow-up 206bacbcb3 2023-03-15 15:42:58 +01:00
ThomasV
3ddffb9773 follow-up 206bacbcb3 2023-03-15 15:41:08 +01:00
Sander van Grieken
c690c9c1be Revert "qml: ElDialog titlebar click moves focus, hack for android to remove onscreen keyboard" 
This reverts commit f0f320b119.
 2023-03-15 15:39:35 +01:00
Sander van Grieken
2881c49671 qml: move technical details to bottom of InvoiceDialog, add routing hints 2023-03-15 15:19:30 +01:00
ThomasV
206bacbcb3 move MyTreeView and related classes to own submodule 2023-03-15 14:25:42 +01:00
ThomasV
abc8d1550e Expiry: the setting is a period, not a date 2023-03-15 12:35:58 +01:00
ThomasV
5750c8954d receive tab: move back Expiry to its previous location, but use 
dialog instead of ComboBox.

The toolbar location is not good, because it can be perceived as
being about the request currently displayed.
 2023-03-15 12:28:26 +01:00
ThomasV
42a63643f3 receive tab: move expiry to toolbar 2023-03-15 12:20:22 +01:00
ThomasV
33a84f6be5 view menu: use checkable actions 2023-03-15 11:27:05 +01:00
ThomasV
b431d39a8e Qt lists: consistently show Details as first item in the contextual menu 2023-03-15 11:18:19 +01:00
ThomasV
107a6f9080 utxo_dialog: fix minor regression (set cursor to top after drawing) 2023-03-15 11:11:11 +01:00
ThomasV
2db0bc9f73 tx in/out details: rewording 'receiving address' 
in the confirm tx dialog, 'receiving' could lead users to believe
that the funds are going to be sent to this address.
 2023-03-15 11:00:40 +01:00
ThomasV
20e93af70c lightning_tx_dialog: add editable tx description 2023-03-15 10:48:03 +01:00
ThomasV
0bda808b29 Qt lists: always show item detail on double click 
No longer enter edit mode for editable columns.
(that behaviour was difficult to learn, because
it is not explicit which columns are editable)
 2023-03-15 10:35:44 +01:00
ThomasV
660a8ebc7f Qt: let user edit tx label from tx_dialog 
This allows users to edit labels from the utxo_dialog,
without having to search for the transaction in history.

Also, remove block hash from tx dialog: not very useful, and
available through block explorers. (the situation where this
could be useful is case of a chain fork, but in that case the
tx might be mined in both branches of the fork, and we would
want to know that).
 2023-03-15 09:33:11 +01:00
SomberNight
d166fa886e qt: fix paying to openalias 
Probably got broken in https://github.com/spesmilo/electrum/pull/7839 ,
which got released in 4.3.0, ~7 months ago.
As no one complained, this really again raises the question of removing openalias...

related https://github.com/spesmilo/electrum/issues/6232
 2023-03-14 17:21:33 +00:00