AaronFiore/electrum
1
0
Fork 0
Code Activity

qt bump fee: disable targeting an abs fee. only allow setting feerate

Browse Source 
wallet.bump_fee() only allows targeting a feerate.
Prior to this commit, _BaseRBFDialog(TxEditor) allowed setting either a feerate or an abs fee.
When setting an abs fee, TxEditor.update_fee_fields() tries to adjust the feerate accordingly,
and then via side-effecting, wallet.bump_fee() will get called with the derived feerate.
This seems really buggy atm. I think it is best to disable setting abs fees, and
if we want to enable it later, targeting needs to be implemented in wallet.bump_fee() -
just like how it works in ConfirmTxDialog(TxEditor) and wallet.make_unsigned_transaction().
This commit is contained in:
SomberNight
2023-04-20 00:36:40 +00:00
parent a2063f8f48
commit ce8f564fb4
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
electrum/gui/qt/rbf_dialog.py
View File

@@ -49,6 +49,7 @@ class _BaseRBFDialog(TxEditor):
title=title,
make_tx=self.rbf_func)
self.fee_e.setFrozen(True) # disallow setting absolute fee for now, as wallet.bump_fee can only target feerate
new_fee_rate = self.old_fee_rate + max(1, self.old_fee_rate // 20)
self.feerate_e.setAmount(new_fee_rate)
self.update()