AaronFiore/electrum
1
0
Fork 0
Code Activity

lnpeer: MPP receive: require payment_secret for each htlc

Browse Source 
BOLT-04 says:
The final node:
  if it supports basic_mpp:
    MUST require payment_secret for all HTLCs in the set

90468030d5/04-onion-routing.md (basic-multi-part-payments)
This commit is contained in:
SomberNight
2021-02-24 20:34:34 +01:00
parent 691ebaf4f8
commit 9024419fdc
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
electrum/lnpeer.py
View File

@@ -1559,7 +1559,10 @@ class Peer(Logger):
try:
payment_secret_from_onion = processed_onion.hop_data.payload["payment_data"]["payment_secret"]
except:
pass # skip
if total_msat > amt_to_forward:
# payment_secret is required for MPP
raise OnionRoutingFailure(code=OnionFailureCode.INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS, data=b'')
# TODO fail here if invoice has set PAYMENT_SECRET_REQ
else:
if payment_secret_from_onion != derive_payment_secret_from_payment_preimage(preimage):
raise OnionRoutingFailure(code=OnionFailureCode.INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS, data=b'')