AaronFiore/electrum
1
0
Fork 0
Code Activity

synchronizer: request missing txs for addresses in random order

Browse Source 
as discussed in issue #6697, users with large wallets or slow
connections may never see their initial request-missing-tx run complete,
if we always use the same sync order.

This commit shuffles the addresses being requested every time a new
request round happens, so that (if enough time passes and enough initial
state requests are attempted) we will always get the latest state for
each address, regardless of how quickly the connection times out on us
This commit is contained in:
ln2max
2020-11-17 11:37:56 +00:00
committed by SomberNight
parent 42366ba57d
commit 7fdedd5c40
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
electrum/synchronizer.py
View File

@@ -232,7 +232,7 @@ class Synchronizer(SynchronizerBase):
async def main(self):
self.wallet.set_up_to_date(False)
# request missing txns, if any
for addr in self.wallet.db.get_history():
for addr in random_shuffled_copy(self.wallet.db.get_history()):
history = self.wallet.db.get_addr_history(addr)
# Old electrum servers returned ['*'] when all history for the address
# was pruned. This no longer happens but may remain in old wallets.