AaronFiore/electrum
1
0
Fork 0
Code Activity

adb: get_balance: add comment about #8835

Browse Source 
> These kind of checks look incorrect and confused/confusing for me:
> 43a5d03426/electrum/gui/qml/qeinvoice.py (L388)
> 43a5d03426/electrum/gui/qt/main_window.py (L1801)

> For example, consider creating a local tx that spends all UTXOs in the wallet, and consolidates them to another ismine address.
> Such a tx basically does not change what wallet.get_balance() returns.
> but to the checks listed above, the confirmed balance of the wallet I guess should be 0?
This commit is contained in:
SomberNight
2024-01-19 15:22:28 +00:00
parent 43a5d03426
commit 7247130aaf
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
electrum/address_synchronizer.py
View File

@@ -860,6 +860,7 @@ class AddressSynchronizer(Logger, EventListener):
excluded_coins: Set[str] = None) -> Tuple[int, int, int]:
"""Return the balance of a set of addresses:
confirmed and matured, unconfirmed, unmatured
Note: intended for display-purposes. would need extreme care for "has enough funds" checks (see #8835)
"""
if excluded_addresses is None:
excluded_addresses = set()