AaronFiore/electrum
1
0
Fork 0
Code Activity

lnworker: don't query DNS for .onion hosts (fixes #9002)

Browse Source
This commit is contained in:
Sander van Grieken
2024-04-16 13:57:00 +02:00
committed by SomberNight
parent a8620bd3c0
commit 70177e4b26
1 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
electrum/lnworker.py
View File

@@ -542,12 +542,20 @@ class LNWorker(Logger, EventListener, NetworkRetryManager[LNPeerAddr]):
raise ConnStringFormatError(_('Don\'t know any addresses for node:') + ' ' + node_id.hex())
host, port, timestamp = self.choose_preferred_address(list(addrs))
port = int(port)
# Try DNS-resolving the host (if needed). This is simply so that
# the caller gets a nice exception if it cannot be resolved.
try:
await asyncio.get_running_loop().getaddrinfo(host, port)
except socket.gaierror:
raise ConnStringFormatError(_('Hostname does not resolve (getaddrinfo failed)'))
if host.endswith('.onion'):
if not self.network.proxy:
raise ConnStringFormatError(_('.onion address, but no proxy configured'))
if not self.network.is_proxy_tor:
raise ConnStringFormatError(_('.onion address, but proxy is not a TOR proxy'))
else:
# Try DNS-resolving the host (if needed). This is simply so that
# the caller gets a nice exception if it cannot be resolved.
try:
await asyncio.get_running_loop().getaddrinfo(host, port)
except socket.gaierror:
raise ConnStringFormatError(_('Hostname does not resolve (getaddrinfo failed)'))
# add peer
peer = await self._add_peer(host, port, node_id)
return peer