crash reporter: propagate HTTP error as exception
which will then get displayed as an error, and not as if we succeeded sending...
This commit is contained in:
@@ -75,7 +75,7 @@ class BaseCrashReporter(Logger):
|
||||
|
||||
async def do_post(self, proxy, url, data):
|
||||
async with make_aiohttp_session(proxy) as session:
|
||||
async with session.post(url, data=data) as resp:
|
||||
async with session.post(url, data=data, raise_for_status=True) as resp:
|
||||
return await resp.text()
|
||||
|
||||
def get_traceback_info(self):
|
||||
|
||||
@@ -117,7 +117,7 @@ class Exception_Window(BaseCrashReporter, QWidget, MessageBoxMixin, Logger):
|
||||
self.logger.error('There was a problem with the automatic reporting', exc_info=exc_info)
|
||||
self.show_critical(parent=self,
|
||||
msg=(_('There was a problem with the automatic reporting:') + '<br/>' +
|
||||
repr(e)[:120] + '<br/>' +
|
||||
repr(e)[:120] + '<br/><br/>' +
|
||||
_("Please report this issue manually") +
|
||||
f' <a href="{constants.GIT_REPO_ISSUES_URL}">on GitHub</a>.'),
|
||||
rich_text=True)
|
||||
|
||||
Reference in New Issue
Block a user