AaronFiore/electrum
1
0
Fork 0
Code Activity

lnworker.get_channel_by_short_id: give priority to real SCIDs

Browse Source 
always check real SCIDs first, before checking aliases
This commit is contained in:
SomberNight
2023-10-26 14:32:36 +00:00
parent fac5153329
commit 0b25e593d5
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
electrum/lnworker.py
View File

@@ -1367,9 +1367,16 @@ class LNWallet(LNWorker):
return chan, funding_tx
def get_channel_by_short_id(self, short_channel_id: bytes) -> Optional[Channel]:
# First check against *real* SCIDs.
# This e.g. protects against maliciously chosen SCID aliases, and accidental collisions.
for chan in self.channels.values():
if chan.short_channel_id == short_channel_id:
return chan
# Now we also consider aliases.
# TODO we should split this as this search currently ignores the "direction"
# of the aliases. We should only look at either the remote OR the local alias,
# depending on context.
for chan in self.channels.values():
if chan.get_remote_scid_alias() == short_channel_id:
return chan
if chan.get_local_scid_alias() == short_channel_id: