add FIXMEs to instances where we don't use the network proxy
so that it at least does not get forgotten related https://github.com/spesmilo/electrum/issues/4754
This commit is contained in:
@@ -137,6 +137,7 @@ def _get_and_validate(ns, url, _type):
|
||||
|
||||
|
||||
def query(url, rtype):
|
||||
# FIXME this method is not using the network proxy. (although the proxy might not support UDP?)
|
||||
# 8.8.8.8 is Google's public DNS server
|
||||
nameservers = ['8.8.8.8']
|
||||
ns = nameservers[0]
|
||||
|
||||
@@ -53,6 +53,7 @@ if TYPE_CHECKING:
|
||||
ca_path = certifi.where()
|
||||
ssl_context = ssl.create_default_context(purpose=ssl.Purpose.SERVER_AUTH, cafile=ca_path)
|
||||
server = ServerProxy('https://cosigner.electrum.org/', allow_none=True, context=ssl_context)
|
||||
# FIXME this is not using the network proxy.
|
||||
|
||||
|
||||
class Listener(util.DaemonThread):
|
||||
|
||||
@@ -1707,6 +1707,7 @@ def list_enabled_bits(x: int) -> Sequence[int]:
|
||||
|
||||
|
||||
def resolve_dns_srv(host: str):
|
||||
# FIXME this method is not using the network proxy. (although the proxy might not support UDP?)
|
||||
srv_records = dns.resolver.resolve(host, 'SRV')
|
||||
# priority: prefer lower
|
||||
# weight: tie breaker; prefer higher
|
||||
|
||||
Reference in New Issue
Block a user