EvergreenCrypto/docker-finance
1
1
Fork 1
Code Issues 31 Pull Requests Actions Releases 10 Activity

[REQUEST]: support custom Dockerfile #66

New Issue
Closed
opened 2024-06-26 01:43:59 +00:00 by AaronFiore · 0 comments
AaronFiore commented 2024-06-26 01:43:59 +00:00 (Migrated from gitea.com)
Copy Link

Description of feature request or enhancement

The ability to allow custom Dockerfile commands is paramount to end-user customize-ability.

Currently, optional packages are hard-coded and installed by default. Optional packages/commands should be allowed only through docker-finance edit type=build or similar host edit command.

Requirements:

  • ${DOCKER_FINANCE_CLIENT_CONF}
    • Reorg while maintaining user@host format (breaking change)
      • env should be subordinate to machine/platform/tag
      • Add Dockerfiles path to machine/platform/tag
  • client/docker-finance.d
    • Add Dockerfiles path
    • Factor out client/Dockerfiles optional-related to template Dockerfile.*.in files
  • client/src
    • gen additions
    • build | edit additions
### Description of feature request or enhancement The ability to allow custom Dockerfile commands is paramount to end-user customize-ability. Currently, optional packages are hard-coded and installed by default. Optional packages/commands should be allowed only through `docker-finance edit type=build` or similar host edit command. Requirements: - [x] `${DOCKER_FINANCE_CLIENT_CONF}` - [x] Reorg while maintaining `user@host` format (breaking change) - [x] `env` should be subordinate to `machine/platform/tag` - [x] Add `Dockerfiles` path to `machine/platform/tag` - [x] `client/docker-finance.d` - [x] Add `Dockerfiles` path - [x] Factor out `client/Dockerfiles` optional-related to template `Dockerfile.*.in` files - [x] `client/src` - [x] `gen` additions - [x] `build` | `edit` additions
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
API
Related to `dfi` API
 Breaking
Breaking change that won't be backward compatible
 Bug/Fix
Provides a bug fix
 Bug/Issue
Something is not working
 client/Dockerfiles
Client Dockerfile / docker-compose.yml related
 client/docker-finance.d
Client/container configurations (template, generated)
 client/docker (src)
Client source
 client/Doxygen
Client Doxygen related (not documentation)
 client/plugins
Client plugins
 container/finance
Container finance (source)
 container/hledger-flow
Container hledger-flow (source)
 container/plugins
Container plugins
 container/root
Container root (source)
 Dependency
Documentation
Documentation changes
 Enhancement
Improve existing functionality
 Feature
New functionality
 ₿ig ₿eautiful ₿ounty
Bounty available
 Language/Bash
Bash language specific
 Language/C++
C++ language specific
 Language/Docker-related
Dockerfile or docker-compose
 Language/GNU Awk
`gawk` specific
 Language/hledger .rules
hledger rules (hledger-flow)
 Language/PHP
PHP language specific
 Language/YAML
YAML specific
 Optimization
Priority/Critical
The priority is critical
 Priority/High
The priority is high
 Priority/Low
The priority is low
 Priority/Medium
The priority is medium
 Privacy
Refactor
Repository
Root repository-related (.gitea, .gitignore, etc.)
 Reviewed/Confirmed
Issue has been confirmed
 Reviewed/Duplicate
This issue or pull request already exists
 Reviewed/Invalid
Invalid issue
 Reviewed/Won't Fix
This issue won't be fixed
 Security
This is security issue
 Status/Abandoned
Somebody has started to work on this but abandoned work
 Status/Blocked
Something is blocking this issue or pull request
 Status/Need More Info
Feedback is required to reproduce issue or to continue work
 Tests
Issue or pull request related to tests (functional, unit, benchmarks, etc.)
No Label Breaking client/Dockerfiles client/docker-finance.d client/docker (src) Enhancement Feature Refactor
Milestone
No items
No Milestone
Assignees
Clear assignees
AaronFiore
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Reference: EvergreenCrypto/docker-finance#66
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?