EvergreenCrypto/docker-finance
1
1
Fork 1
Code Issues 32 Pull Requests Actions Releases 15 Activity

container: lib_taxes: bitcoin.tax: update docs/supported tags, add support for TransferAccount column, don't write empty OBFS keymap rows #340

Manually merged
AaronFiore merged 0 commits from AaronFiore/docker-finance:lib_taxes-TransferAccount into master 2026-04-06 22:14:03 +00:00
Conversation 0 Commits - Files Changed -
AaronFiore commented 2026-04-03 21:47:16 +00:00
Owner
Copy Link

Description

  • Is backward compatible to all rules without TransferAccount added.

    • TransferAccount value must be added via custom rules.
      • Every DEPOSIT entry must have a corresponding WITHDRAWAL entry
        (and vice versa).

  • Adds new income/spends keymap files dedicated to TransferAccount

    • Kept separate from respective Account keymap files.

  • Upstream appears to support TransferAccount in all years even though
    it was introduced specifically for tax years 2025+ (mileage may vary).

  • Removes empty row quotations after selecting column.

  • No longer writes row when RawValue is subsequently empty.

  • Variable name refactor (RawValue is not limited to accounts).

NOTE: headers are still written, regardless of any keymap data.

Agreement

### Description - Is backward compatible to all rules without `TransferAccount` added. * `TransferAccount` value must be added via custom rules. - Every `DEPOSIT` entry must have a corresponding `WITHDRAWAL` entry (and vice versa). - Adds new income/spends keymap files dedicated to `TransferAccount` * Kept separate from respective `Account` keymap files. - Upstream appears to support `TransferAccount` in all years even though it was introduced specifically for tax years 2025+ (mileage may vary). - Removes empty row quotations after selecting column. - No longer writes row when `RawValue` is subsequently empty. - Variable name refactor (`RawValue` is not limited to accounts). NOTE: headers are still written, regardless of any keymap data. ### Agreement - [x] I have read and understood the [Development](https://gitea.evergreencrypto.co/EvergreenCrypto/dfi-docs/src/branch/master/markdown/How-do-I-contribute.md#development) and [License](https://gitea.evergreencrypto.co/EvergreenCrypto/dfi-docs/src/branch/master/markdown/Where-is-the-legalese.md#where-is-the-legalese) documentation
AaronFiore added this to the v1.5.0 milestone 2026-04-03 21:47:16 +00:00
AaronFiore changed title from container: lib_taxes: bitcoin.tax: update docs/supported tags, add support for `TransferAccount` column to WIP: container: lib_taxes: bitcoin.tax: update docs/supported tags, add support for `TransferAccount` column 2026-04-06 19:42:46 +00:00
AaronFiore changed title from WIP: container: lib_taxes: bitcoin.tax: update docs/supported tags, add support for `TransferAccount` column to container: lib_taxes: bitcoin.tax: update docs/supported tags, add support for `TransferAccount` column 2026-04-06 21:02:09 +00:00
AaronFiore changed title from container: lib_taxes: bitcoin.tax: update docs/supported tags, add support for `TransferAccount` column to container: lib_taxes: bitcoin.tax: update docs/supported tags, add support for `TransferAccount` column, don't write empty OBFS keymap rows 2026-04-06 22:08:51 +00:00
AaronFiore added 2 commits 2026-04-06 22:10:14 +00:00
container: lib_taxes: add support for bitcoin.tax TransferAccount column ed37859c4e 
- Is backward compatible to all rules without `TransferAccount` added.
  * `TransferAccount` value must be added via custom rules.
    - Every `DEPOSIT` entry must have a corresponding `WITHDRAWAL` entry
      (and vice versa).

- Adds new income/spends keymap files dedicated to `TransferAccount`
  * Kept separate from respective `Account` keymap files.

- Upstream appears to support `TransferAccount` in all years even though
  it was introduced specifically for tax years 2025+ (mileage may vary).
container: lib_taxes: don't write empty OBFS keymap rows fc53b1310f 
- Removes empty row quotations after selecting column.
- No longer writes row when `RawValue` is subsequently empty.
- Variable name refactor (`RawValue` is not limited to accounts).

NOTE: headers are still written, regardless of any keymap data.
AaronFiore force-pushed lib_taxes-TransferAccount from 6c59d4541a to fc53b1310f 2026-04-06 22:10:14 +00:00 Compare
AaronFiore manually merged commit af1cb6b974 into master 2026-04-06 22:14:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API
Related to `dfi` API
 Breaking
Breaking change that won't be backward compatible
 Bug/Fix
Provides a bug fix
 Bug/Issue
Something is not working
 client/conf.d
Client/container configurations (template, generated)
 client/Dockerfiles
Client Dockerfile / docker-compose.yml related
 client/Doxygen
Client Doxygen related (not documentation)
 client/plugins
Client plugins
 client/src (docker)
Client source
 container/plugins
Container plugins
 container/src (finance)
Container finance (source)
 container/src (hledger-flow)
Container hledger-flow (source)
 container/src (root)
Container root (source)
 Dependency
Documentation
Documentation changes
 Enhancement
Improve existing functionality
 Feature
New functionality
 ₿ig ₿eautiful ₿ounty
Bounty available
 Language/Bash
Bash language specific
 Language/C++
C++ language specific
 Language/Docker-related
Dockerfile or docker-compose
 Language/GNU Awk
`gawk` specific
 Language/hledger .rules
hledger rules (hledger-flow)
 Language/PHP
PHP language specific
 Language/YAML
YAML specific
 Optimization
Priority/Critical
The priority is critical
 Priority/High
The priority is high
 Priority/Low
The priority is low
 Priority/Medium
The priority is medium
 Privacy
Refactor
Repository
Root repository-related (.gitea, .gitignore, etc.)
 Reviewed/Confirmed
Issue has been confirmed
 Reviewed/Duplicate
This issue or pull request already exists
 Reviewed/Invalid
Invalid issue
 Reviewed/Won't Fix
This issue won't be fixed
 Security
This is security issue
 Status/Abandoned
Somebody has started to work on this but abandoned work
 Status/Blocked
Something is blocking this issue or pull request
 Status/Need More Info
Feedback is required to reproduce issue or to continue work
 Tests
Issue or pull request related to tests (functional, unit, benchmarks, etc.)
No Label container/src (finance) Documentation Enhancement Language/Bash Language/GNU Awk Refactor
Milestone
No items
No Milestone v1.5.0
Assignees
Clear assignees
AaronFiore
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Reference: EvergreenCrypto/docker-finance#340
Delete Branch "AaronFiore/docker-finance:lib_taxes-TransferAccount"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?