EvergreenCrypto/docker-finance
1
1
Fork 1
Code Issues 32 Pull Requests Actions Releases 13 Activity

[REQUEST]: refactor and enhance current dfi completion using bash-completion "library" #332

New Issue
Open
opened 2026-03-20 19:52:56 +00:00 by AaronFiore · 0 comments
AaronFiore commented 2026-03-20 19:52:56 +00:00
Owner
Copy Link

Client (host)

  • Add dependency to finance image (archlinux) Dockerfile and client manifest

Container (finance (archlinux) image)

https://gitea.evergreencrypto.co/EvergreenCrypto/docker-finance/src/branch/master/container/src/finance/completion.bash

  • Refactor dfi completion using bash-completion (i.e., remove direct access to COMP* and use what's available, etc.)
  • Add completion to existing dfi arguments that aren't completing (e.g., dfi profile/subprofile edit type= -> dfi profile/subprofile edit type=rules...)

Notes

The not-so-straightforward resolution to this issue hinges on the fact that the default delim for all dfi completion is the = character (which also exists in COMP_WORDBREAKS). One resolution can be found in c63826f867/completions-core/dd.bash

See also:

For consideration

https://gitea.evergreencrypto.co/EvergreenCrypto/docker-finance/src/branch/master/client/src/docker/completion.bash

  • Add support to client (host) completion but keep backward compatibility, as this would otherwise break the "no more than 3 dependencies" approach to client-side dfi.
## Client (host) - [x] Add dependency to `finance` image (`archlinux`) Dockerfile and client manifest ## Container (`finance` (`archlinux`) image) https://gitea.evergreencrypto.co/EvergreenCrypto/docker-finance/src/branch/master/container/src/finance/completion.bash - [ ] Refactor `dfi` completion using `bash-completion` (i.e., remove direct access to COMP* and use what's available, etc.) - [ ] Add completion to existing `dfi` arguments that aren't completing (e.g., `dfi profile/subprofile edit type=` -> `dfi profile/subprofile edit type=rules...`) ## Notes The not-so-straightforward resolution to this issue hinges on the fact that the default delim for all `dfi` completion is the `=` character (which also exists in `COMP_WORDBREAKS`). One resolution can be found in https://github.com/scop/bash-completion/blob/c63826f8678e7d1fd36cf188bf1ba2eccaf2552e/completions-core/dd.bash See also: - https://github.com/scop/bash-completion/tree/main/completions-core - https://github.com/scop/bash-completion/blob/c63826f8678e7d1fd36cf188bf1ba2eccaf2552e/bash_completion#L1105-L1132 - https://github.com/scop/bash-completion/blob/c63826f8678e7d1fd36cf188bf1ba2eccaf2552e/bash_completion#L1450-L1454 - https://github.com/scop/bash-completion/blob/c63826f8678e7d1fd36cf188bf1ba2eccaf2552e/bash_completion#L2964-L2968 ## For consideration https://gitea.evergreencrypto.co/EvergreenCrypto/docker-finance/src/branch/master/client/src/docker/completion.bash - [ ] Add support to client (host) completion but keep backward compatibility, as this would otherwise break the "no more than 3 dependencies" approach to client-side `dfi`.
AaronFiore added this to the v1.5.0 milestone 2026-03-20 19:52:56 +00:00
AaronFiore added the DependencyEnhancementLanguage/BashRefactor labels 2026-03-20 19:52:56 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
API
Related to `dfi` API
 Breaking
Breaking change that won't be backward compatible
 Bug/Fix
Provides a bug fix
 Bug/Issue
Something is not working
 client/conf.d
Client/container configurations (template, generated)
 client/Dockerfiles
Client Dockerfile / docker-compose.yml related
 client/Doxygen
Client Doxygen related (not documentation)
 client/plugins
Client plugins
 client/src (docker)
Client source
 container/plugins
Container plugins
 container/src (finance)
Container finance (source)
 container/src (hledger-flow)
Container hledger-flow (source)
 container/src (root)
Container root (source)
 Dependency
Documentation
Documentation changes
 Enhancement
Improve existing functionality
 Feature
New functionality
 ₿ig ₿eautiful ₿ounty
Bounty available
 Language/Bash
Bash language specific
 Language/C++
C++ language specific
 Language/Docker-related
Dockerfile or docker-compose
 Language/GNU Awk
`gawk` specific
 Language/hledger .rules
hledger rules (hledger-flow)
 Language/PHP
PHP language specific
 Language/YAML
YAML specific
 Optimization
Priority/Critical
The priority is critical
 Priority/High
The priority is high
 Priority/Low
The priority is low
 Priority/Medium
The priority is medium
 Privacy
Refactor
Repository
Root repository-related (.gitea, .gitignore, etc.)
 Reviewed/Confirmed
Issue has been confirmed
 Reviewed/Duplicate
This issue or pull request already exists
 Reviewed/Invalid
Invalid issue
 Reviewed/Won't Fix
This issue won't be fixed
 Security
This is security issue
 Status/Abandoned
Somebody has started to work on this but abandoned work
 Status/Blocked
Something is blocking this issue or pull request
 Status/Need More Info
Feedback is required to reproduce issue or to continue work
 Tests
Issue or pull request related to tests (functional, unit, benchmarks, etc.)
No Label Dependency Enhancement Language/Bash Refactor
Milestone
No items
No Milestone v1.5.0
Assignees
Clear assignees
AaronFiore
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Reference: EvergreenCrypto/docker-finance#332
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?