- Implements support for unified API via Etherscan V2 (ethereum-based)
* All ethereum-based L2s are now accessed via single API endpoint
- Chains are now available via chain ID
* Updates API key requirement for `fetch` ethereum-based subaccounts
- The API key's value must now be prepended with "etherscan"
* Previously was prepended per-chain ("ethereum" or "polygon")
- The API key is now *required* (can be generated at etherscan.io)
* Resolves fatal error in Etherscan::parse_response()
* Impl will now handle if:
- Config's API key/value is malformed
- Etherscan API key was not given
- Etherscan response is fatal
- Adds support for more L2s
* Arbitrum (One)
* Optimism
* Base
- Adds more L2s to existing accounts
* Coinbase Wallet
* Ledger Live
* MetaMask
- Updates documentation
* Update default generated `fetch` config
* Update `fetch` usage help
* Update README
The container environment's $DOCKER_FINANCE_CONTAINER_CONF is
bind-mounted and, by default, points to ~/.config/docker-finance.d
The parent dir (~/.config) is subsequently owned by root (Docker-ism).
Ergo, with visidata v3.2, visidata cannot create its default dir:
"PermissionError: [Errno 13] Permission denied: for visidata config"
This commit fixes that by setting visidata's default dir to use the
calling profile's docker-finance.d (where profile customization occurs).
Also included is some related refactoring.
- Will now only parse given year (or 'all', if given).
* No longer parses all subsequent years after given year
(unless 'all' is given).
- Now prints most recent daily average for given year instead of most
recent daily average for current year.
- When applicable, as the stream progresses, exit each successive gawk
iteration when no applicable records are present (no taxable events
found for the given tag in the given year).
Previously, when no records were found, a reports file was produced
with either a single header-only row or junk data that resulted from
the assumption there would be real data.
A preexisting hack prevented the junk data from being written after
production but this commit will resolve that hack by preventing the
printing of junk data while also preventing the production of a
header-only file.
- Print warnings when no taxable events are found for the given year.
- Add checks:
* Only verify patched files if the patched files are not empty.
* Empty variable checks.
- Don't break before advancing 'starting_after' cursor
* Only save given year instead of breaking when not given year
- The 'next_starting_after' cursor now exists within 'info' object
- Creates per-wallet / per-account compliance for IRS Rev. Proc. 2024-28
* Obfuscated keymap now creates a unique indentifier per-wallet /
per-account where all trades, spends and income are now clearly
tied to their respective wallets / accounts.
- Removes support for anonymized ("universal pool") reports.
As said before; `lib_ledger` was meant to be a general abstraction to
any underlying CLI ledger.
But, between C++ `ledger` and Ledger Hardware Wallet, this abstraction
has become too confusing and counterproductive.
Since `hledger` will be the underlying implementation for the forseeable
future, all doubt should now be removed.
As said before; `lib_ledger` was meant to be a general abstraction to
any underlying CLI ledger.
But, between C++ `ledger` and Ledger Hardware Wallet, this abstraction
has become too confusing and counterproductive.
Since `hledger` will be the underlying implementation for the forseeable
future, all doubt should now be removed.
Since modules are included upon build type, if a build doesn't support
a feature then that feature's dependencies will not be available.
This commit will give notice of those missing dependencies.
- Adds plugin type support
* Adds pseudo-paths to help usage
* Adds arg parsing of given plugin name
- Prepended pseudo-paths will use repo or custom plugin
Issue #51 describes at least a few undocumented bitcoin.tax issues:
- Bicoin.tax gives unexpected cost-basis results when `Fee` is given
with `Total` (when `Total` is given in place of `Price`). The
expectation is that bitcoin.tax will perform the cost-basis
calculation on `Total` when `Fee` is also given.
However, bitcoin.tax *will* give expected cost-basis results if
`Price` is given in place of `Total` (with `Fee` also given) *or* if
`Total` is given *after* local cost-basis adjustments are made (but
*without* `Fee` given).
The rationale for why docker-finance doesn't use `Price`:
* docker-finance has all of the `Total`s; so `Price` isn't
necessary.
* Local price information isn't available for most trades (and
shouldn't be necessary since all `Total`s are available).
- Additionally, when `Fee` is non-fiat (crypto), it now must be marked
as a SPEND in order to be disposed (and to produce an accurate
closing report).
- Finally, if `FeeCurrency` *does* not match either `Symbol` or
`Currency` (e.g., BTC-ETH w/ BNB fee), it's unknown if cost-basis
must be calculated locally as well (if `Total` is given). Local
calculations cannot be done because `Fee` price information is
(almost certainly) not available for this type of trade.
Until upstream can assert that attaching the `Fee` will subsequently
adjust the cost-basis of `Total` *and* dispose of the `Fee` in the
process (while also allowing `Total` to be used in place of `Price`),
the `Fee` (and `FeeCurrency`) column(s) must not be populated and values
instead moved to SPEND (as described above).
Upstream is aware of these issues (since May) and they're in the process
of resolution. In the meantime, docker-finance work-arounds should
suffice for all trades that have a fiat `Fee` and/or a
`Fee`/`FeeCurrency` that matches one side of the trading pair.
- Make known that non-zero returns are fatal errors
- Return success on success (iadd | manual)
- Add iadd to `edit` usage help
- Remove outdated comments
