From d5220d151e8d8b0e2d0db82ef89a2abddb1c390f Mon Sep 17 00:00:00 2001 From: Aaron Fiore Date: Fri, 21 Jun 2024 20:58:21 -0700 Subject: [PATCH] hledger-flow: coinbase: rules: catch Advanced Trade 0-value txs - Removes 0-values from first double entry while retaining metadata - Catches less-than-a-penny commissions in those same transactions --- .../hledger-flow/accounts/coinbase/coinbase-shared.rules | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/container/src/hledger-flow/accounts/coinbase/coinbase-shared.rules b/container/src/hledger-flow/accounts/coinbase/coinbase-shared.rules index eea2fb1..1eb8664 100644 --- a/container/src/hledger-flow/accounts/coinbase/coinbase-shared.rules +++ b/container/src/hledger-flow/accounts/coinbase/coinbase-shared.rules @@ -656,7 +656,6 @@ if %type ^advanced_trade_fill$ if %type ^advanced_trade_fill$ & %advanced_trade_fill_order_side (^buy$|^sell$) -& %advanced_trade_fill_real_value_amount [1-9] account1 assets:coinbase:%subaccount:%advanced_trade_fill_pair_lhs account2 assets:coinbase:%subaccount:%advanced_trade_fill_pair_rhs amount3 -%advanced_trade_fill_commission %advanced_trade_fill_pair_rhs @@ -664,6 +663,13 @@ if %type ^advanced_trade_fill$ amount4 %advanced_trade_fill_commission %advanced_trade_fill_pair_rhs account4 expenses:coinbase:%subaccount:fees:trading:%advanced_trade_fill_pair_rhs +# NOTE: see WARNING in preprocess about $0.00 Advanced Trade txs +if %type ^advanced_trade_fill$ +& %advanced_trade_fill_order_side (^buy$|^sell$) +& %advanced_trade_fill_real_value_amount ^[^1-9]*$ + account1 + account2 + # # BUY #