From b9b6a0b9a184e4c8235d849680386cda2637fb3e Mon Sep 17 00:00:00 2001 From: Aaron Fiore Date: Thu, 5 Feb 2026 17:21:12 -0800 Subject: [PATCH 1/2] client: dev-tools: lib_linter: cppcheck: bump to --std=c++20 --- client/src/docker/lib/internal/dev-tools/lib_linter.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/docker/lib/internal/dev-tools/lib_linter.bash b/client/src/docker/lib/internal/dev-tools/lib_linter.bash index 318d6e9..bd48b61 100644 --- a/client/src/docker/lib/internal/dev-tools/lib_linter.bash +++ b/client/src/docker/lib/internal/dev-tools/lib_linter.bash @@ -177,7 +177,7 @@ function lib_linter::__lint_cpp() local -r _clang_format="clang-format -i --style=file:${_clang_file}" local -r _cpplint="cpplint --root=${DOCKER_FINANCE_CLIENT_REPO} --filter=-whitespace/braces,-whitespace/newline,-whitespace/line_length,-build/c++11 --headers=hh --extensions=hh,cc,cpp,C" - local -r _cppcheck="cppcheck --enable=warning,style,performance,portability --inline-suppr --std=c++17" + local -r _cppcheck="cppcheck --enable=warning,style,performance,portability --inline-suppr --std=c++20" if [ -z "${_path[*]}" ]; then # Do all From 321751d0094c001ed0e4f47b6ce5ec1805bd1420 Mon Sep 17 00:00:00 2001 From: Aaron Fiore Date: Thu, 5 Feb 2026 17:22:57 -0800 Subject: [PATCH 2/2] container: root: common: add `cppcheck-suppress stlIfStrFind` `basic_string::starts_with()` is not applicable and breaks functionality --- container/src/root/common/utility.hh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/container/src/root/common/utility.hh b/container/src/root/common/utility.hh index b1a2a56..b86c6f7 100644 --- a/container/src/root/common/utility.hh +++ b/container/src/root/common/utility.hh @@ -442,15 +442,15 @@ class PluggableSpace "[a-zA-Z0-9:/_\\-\\.]+"} /* TODO(unassigned): refine */), "invalid characters in pluggable space"); - if (parsed.find('/')) + if (parsed.find('/')) // cppcheck-suppress stlIfStrFind { parsed = std::regex_replace(parsed, std::regex{"/"}, "::"); } - if (parsed.find('-')) + if (parsed.find('-')) // cppcheck-suppress stlIfStrFind { parsed = std::regex_replace(parsed, std::regex{"-"}, "_"); } - if (parsed.find('.')) + if (parsed.find('.')) // cppcheck-suppress stlIfStrFind { parsed = std::regex_replace(parsed, std::regex{"\\."}, "_"); }