A new config API is introduced, and ~all of the codebase is adapted to it.
The old API is kept but mainly only for dynamic usage where its extra flexibility is needed.
Using examples, the old config API looked this:
```
>>> config.get("request_expiry", 86400)
604800
>>> config.set_key("request_expiry", 86400)
>>>
```
The new config API instead:
```
>>> config.WALLET_PAYREQ_EXPIRY_SECONDS
604800
>>> config.WALLET_PAYREQ_EXPIRY_SECONDS = 86400
>>>
```
The old API operated on arbitrary string keys, the new one uses
a static ~enum-like list of variables.
With the new API:
- there is a single centralised list of config variables, as opposed to
these being scattered all over
- no more duplication of default values (in the getters)
- there is now some (minimal for now) type-validation/conversion for
the config values
closes https://github.com/spesmilo/electrum/pull/5640
closes https://github.com/spesmilo/electrum/pull/5649
Note: there is yet a third API added here, for certain niche/abstract use-cases,
where we need a reference to the config variable itself.
It should only be used when needed:
```
>>> var = config.cv.WALLET_PAYREQ_EXPIRY_SECONDS
>>> var
<ConfigVarWithConfig key='request_expiry'>
>>> var.get()
604800
>>> var.set(3600)
>>> var.get_default_value()
86400
>>> var.is_set()
True
>>> var.is_modifiable()
True
```
212 lines
7.9 KiB
Python
212 lines
7.9 KiB
Python
# Electrum - lightweight Bitcoin client
|
|
#
|
|
# Permission is hereby granted, free of charge, to any person
|
|
# obtaining a copy of this software and associated documentation files
|
|
# (the "Software"), to deal in the Software without restriction,
|
|
# including without limitation the rights to use, copy, modify, merge,
|
|
# publish, distribute, sublicense, and/or sell copies of the Software,
|
|
# and to permit persons to whom the Software is furnished to do so,
|
|
# subject to the following conditions:
|
|
#
|
|
# The above copyright notice and this permission notice shall be
|
|
# included in all copies or substantial portions of the Software.
|
|
#
|
|
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
|
|
# BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
|
|
# ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
|
|
# CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
# SOFTWARE.
|
|
import asyncio
|
|
import json
|
|
import locale
|
|
import traceback
|
|
import sys
|
|
import queue
|
|
from typing import NamedTuple, Optional
|
|
|
|
from .version import ELECTRUM_VERSION
|
|
from . import constants
|
|
from .i18n import _
|
|
from .util import make_aiohttp_session, error_text_str_to_safe_str
|
|
from .logging import describe_os_version, Logger, get_git_version
|
|
|
|
|
|
class CrashReportResponse(NamedTuple):
|
|
status: Optional[str]
|
|
text: str
|
|
url: Optional[str]
|
|
|
|
|
|
class BaseCrashReporter(Logger):
|
|
report_server = "https://crashhub.electrum.org"
|
|
issue_template = """<h2>Traceback</h2>
|
|
<pre>
|
|
{traceback}
|
|
</pre>
|
|
|
|
<h2>Additional information</h2>
|
|
<ul>
|
|
<li>Electrum version: {app_version}</li>
|
|
<li>Python version: {python_version}</li>
|
|
<li>Operating system: {os}</li>
|
|
<li>Wallet type: {wallet_type}</li>
|
|
<li>Locale: {locale}</li>
|
|
</ul>
|
|
"""
|
|
CRASH_MESSAGE = _('Something went wrong while executing Electrum.')
|
|
CRASH_TITLE = _('Sorry!')
|
|
REQUEST_HELP_MESSAGE = _('To help us diagnose and fix the problem, you can send us a bug report that contains '
|
|
'useful debug information:')
|
|
DESCRIBE_ERROR_MESSAGE = _("Please briefly describe what led to the error (optional):")
|
|
ASK_CONFIRM_SEND = _("Do you want to send this report?")
|
|
USER_COMMENT_PLACEHOLDER = _("Do not enter sensitive/private information here. "
|
|
"The report will be visible on the public issue tracker.")
|
|
|
|
def __init__(self, exctype, value, tb):
|
|
Logger.__init__(self)
|
|
self.exc_args = (exctype, value, tb)
|
|
|
|
def send_report(self, asyncio_loop, proxy, *, timeout=None) -> CrashReportResponse:
|
|
# FIXME the caller needs to catch generic "Exception", as this method does not have a well-defined API...
|
|
if constants.net.GENESIS[-4:] not in ["4943", "e26f"] and ".electrum.org" in BaseCrashReporter.report_server:
|
|
# Gah! Some kind of altcoin wants to send us crash reports.
|
|
raise Exception(_("Missing report URL."))
|
|
report = self.get_traceback_info()
|
|
report.update(self.get_additional_info())
|
|
report = json.dumps(report)
|
|
coro = self.do_post(proxy, BaseCrashReporter.report_server + "/crash.json", data=report)
|
|
response = asyncio.run_coroutine_threadsafe(coro, asyncio_loop).result(timeout)
|
|
self.logger.info(
|
|
f"Crash report sent. Got response [DO NOT TRUST THIS MESSAGE]: {error_text_str_to_safe_str(response)}")
|
|
response = json.loads(response)
|
|
assert isinstance(response, dict), type(response)
|
|
# sanitize URL
|
|
if location := response.get("location"):
|
|
assert isinstance(location, str)
|
|
base_issues_url = constants.GIT_REPO_ISSUES_URL
|
|
if not base_issues_url.endswith("/"):
|
|
base_issues_url = base_issues_url + "/"
|
|
if not location.startswith(base_issues_url):
|
|
location = None
|
|
ret = CrashReportResponse(
|
|
status=response.get("status"),
|
|
url=location,
|
|
text=_("Thanks for reporting this issue!"),
|
|
)
|
|
return ret
|
|
|
|
async def do_post(self, proxy, url, data) -> str:
|
|
async with make_aiohttp_session(proxy) as session:
|
|
async with session.post(url, data=data, raise_for_status=True) as resp:
|
|
return await resp.text()
|
|
|
|
def get_traceback_info(self):
|
|
exc_string = str(self.exc_args[1])
|
|
stack = traceback.extract_tb(self.exc_args[2])
|
|
readable_trace = self.__get_traceback_str_to_send()
|
|
id = {
|
|
"file": stack[-1].filename if len(stack) else '<no stack>',
|
|
"name": stack[-1].name if len(stack) else '<no stack>',
|
|
"type": self.exc_args[0].__name__
|
|
}
|
|
return {
|
|
"exc_string": exc_string,
|
|
"stack": readable_trace,
|
|
"id": id
|
|
}
|
|
|
|
def get_additional_info(self):
|
|
args = {
|
|
"app_version": get_git_version() or ELECTRUM_VERSION,
|
|
"python_version": sys.version,
|
|
"os": describe_os_version(),
|
|
"wallet_type": "unknown",
|
|
"locale": locale.getdefaultlocale()[0] or "?",
|
|
"description": self.get_user_description()
|
|
}
|
|
try:
|
|
args["wallet_type"] = self.get_wallet_type()
|
|
except Exception:
|
|
# Maybe the wallet isn't loaded yet
|
|
pass
|
|
return args
|
|
|
|
def __get_traceback_str_to_send(self) -> str:
|
|
# make sure that traceback sent to crash reporter contains
|
|
# e.__context__ and e.__cause__, i.e. if there was a chain of
|
|
# exceptions, we want the full traceback for the whole chain.
|
|
return "".join(traceback.format_exception(*self.exc_args))
|
|
|
|
def _get_traceback_str_to_display(self) -> str:
|
|
# overridden in Qt subclass
|
|
return self.__get_traceback_str_to_send()
|
|
|
|
def get_report_string(self):
|
|
info = self.get_additional_info()
|
|
info["traceback"] = self._get_traceback_str_to_display()
|
|
return self.issue_template.format(**info)
|
|
|
|
def get_user_description(self):
|
|
raise NotImplementedError
|
|
|
|
def get_wallet_type(self) -> str:
|
|
raise NotImplementedError
|
|
|
|
|
|
class EarlyExceptionsQueue:
|
|
"""Helper singleton for explicitly sending exceptions to crash reporter.
|
|
|
|
Typically the GUIs set up an "exception hook" that catches all otherwise
|
|
uncaught exceptions (which unroll the stack of a thread completely).
|
|
This class provides methods to report *any* exception, and queueing logic
|
|
that delays processing until the exception hook is set up.
|
|
"""
|
|
|
|
_is_exc_hook_ready = False
|
|
_exc_queue = queue.Queue()
|
|
|
|
@classmethod
|
|
def set_hook_as_ready(cls):
|
|
"""Flush the queue and disable it for future exceptions."""
|
|
if cls._is_exc_hook_ready:
|
|
return
|
|
cls._is_exc_hook_ready = True
|
|
while cls._exc_queue.qsize() > 0:
|
|
e = cls._exc_queue.get()
|
|
cls._send_exception_to_crash_reporter(e)
|
|
|
|
@classmethod
|
|
def send_exception_to_crash_reporter(cls, e: BaseException):
|
|
if cls._is_exc_hook_ready:
|
|
cls._send_exception_to_crash_reporter(e)
|
|
else:
|
|
cls._exc_queue.put(e)
|
|
|
|
@staticmethod
|
|
def _send_exception_to_crash_reporter(e: BaseException):
|
|
assert EarlyExceptionsQueue._is_exc_hook_ready
|
|
sys.excepthook(type(e), e, e.__traceback__)
|
|
|
|
|
|
send_exception_to_crash_reporter = EarlyExceptionsQueue.send_exception_to_crash_reporter
|
|
|
|
|
|
def trigger_crash():
|
|
# note: do not change the type of the exception, the message,
|
|
# or the name of this method. All reports generated through this
|
|
# method will be grouped together by the crash reporter, and thus
|
|
# don't spam the issue tracker.
|
|
|
|
class TestingException(Exception):
|
|
pass
|
|
|
|
def crash_test():
|
|
raise TestingException("triggered crash for testing purposes")
|
|
|
|
import threading
|
|
t = threading.Thread(target=crash_test)
|
|
t.start()
|