AaronFiore/electrum
1
0
Fork 0
Code Activity
Files
08673d3534bee98e039eb6f232f666073838c58b
electrum/electrum
History
f321x 08673d3534 util: cleanup asyncio event loop after stopping 
I noticed many ResourceWarning when running regtests with
PYTHONASYNCIODEBUG=1 and PYTHONDEVMODE=1, each time a daemon
gets stopped the asyncio loop wouldn't get properly cleaned up:

```
(env) user@hp:~/code/electrum-fork$ python3 -m unittest tests.regtest.TestLightningAB.test_lnwatcher_waits_until_fees_go_down
***** test_lnwatcher_waits_until_fees_go_down ******
initializing alice
  0.67 | W | asyncio | Executing <Task finished name='Task-1' coro=<run_offline_command() done, defined at /home/user/code/electrum-fork/./run_electrum:229> result={'msg': 'Please keep ... your wallet.', 'path': '/tmp/alice/r...efault_wallet', 'seed': 'fiction sadd...it radar desk'} created at /home/user/code/electrum-fork/electrum/util.py:1760> took 0.280 seconds
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
funding alice
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
f84277454a04243e500cf84c67aad16e04dd7a88ffa849ffcf20ce3f9af277df
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
initializing bob
  0.54 | W | asyncio | Executing <Task finished name='Task-1' coro=<run_offline_command() done, defined at /home/user/code/electrum-fork/./run_electrum:229> result={'msg': 'Please keep ... your wallet.', 'path': '/tmp/bob/reg...efault_wallet', 'seed': 'wink loud so...ory myth case'} created at /home/user/code/electrum-fork/electrum/util.py:1760> took 0.195 seconds
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
funding bob
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
f68b651e84dc8547f54dd09129018a2d0d256dedc8ccc48595ae172de895371a
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
mining 1 blocks
starting daemon (PID 38153)
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
/tmp/alice/regtest/wallets/default_wallet
/usr/lib64/python3.14/asyncio/base_events.py:758: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=True>
```

This commits adds some cleanup to `util.create_and_start_event_loop()`
to
1. cancel remaining tasks
2. shut down asyncgens
3. shutdown the default executor
4. call loop.close() to free the resources allocated to the loop
See https://stackoverflow.com/questions/30765606/whats-the-correct-way-to-clean-up-after-an-interrupted-event-loop

This seems to reliably solve the mentioned `ResourceWarning`.
2025-10-28 14:53:35 +01:00
..
_vendor
qt desktop gui: upgrade qt5->qt6
2024-09-18 15:48:38 +00:00
chains
contants: add support for mutinynet signet
2025-08-14 15:59:11 +02:00
gui
qt: fix ServerWidget
2025-10-27 18:46:36 +01:00
hw_wallet
refactor 'init_wallet_wizard' hook a bit. add test_wizard trezor test
2025-07-21 02:40:17 +00:00
lnwire
onion_wire: use unqualified byte,... type for yet undefined nested tlv types
2025-02-19 14:27:45 +01:00
locale @ 974d671d27
update locale
2025-08-23 18:59:14 +00:00
plugins
lnworker: enforce creation of PaymentInfo for b11
2025-09-30 09:54:35 +02:00
qrreader
…
scripts
WalletDB() usage: trivial refactors and fixes
2025-07-15 12:30:06 +00:00
utils
…
wordlist
…
__init__.py
follow-up prev: electrum-ecc should search for libsecp dll in electrum/
2025-06-15 18:25:42 +00:00
address_synchronizer.py
transaction: SPV-verify TxInput.block_height and .spent_height
2025-09-24 13:46:35 +00:00
base_crash_reporter.py
crash_reporter: flag reports where console was used in app_version
2025-09-11 17:01:52 +00:00
bip21.py
bip21: trivial follow-up
2024-05-30 13:08:13 +00:00
bip32.py
wallet: disable_keystore() not to destroy get_key_origin_info()
2025-08-15 17:29:55 +00:00
bip39_recovery.py
…
bip39_wallet_formats.json
…
bitcoin.py
fee_policy: lower min relay fee from 1 sat/byte to 0.1 s/b
2025-08-01 18:53:03 +00:00
blockchain.py
tests: test_network: intro MockBlockchain. rewrite tests to use it.
2025-06-09 19:34:34 +00:00
channel_db.py
fix: don't suggest onion peers for channel opening
2025-04-30 11:24:46 +02:00
coinchooser.py
type-hint some Callables
2025-08-18 15:38:25 +00:00
commands.py
Merge pull request #10242 from f321x/return_preimage_cli
2025-10-09 15:31:04 +00:00
constants.py
contants: add support for mutinynet signet
2025-08-14 15:59:11 +02:00
contacts.py
Merge pull request #9846 from accumulator/qt_paytoedit_completer
2025-05-21 09:52:57 +02:00
crypto.py
base64.b64decode: always set validate=True
2025-06-03 18:58:05 +00:00
currencies.json
exchange_rate: add historical rates for BitStamp
2024-10-17 18:26:47 +00:00
daemon.py
daemon: get_wallet: handle OSError for weiiird paths
2025-09-03 14:14:22 +00:00
descriptor.py
wallet: sweep_preparations to raise UserFacingException on p2sh/etc
2025-08-18 17:02:34 +00:00
dns_hacks.py
requirements: bump min dnspython to 2.2.0
2025-05-21 18:41:25 +00:00
dnssec.py
Use async dnspython methods for openalias/dnssec
2025-05-16 17:09:41 +02:00
electrum
…
exchange_rate.py
exchange_rate: clear up confusion re type of ExchangeBase._history
2025-05-05 15:01:11 +00:00
fee_policy.py
fee_policy: use FEERATE_PRECISION for .. precision
2025-08-19 14:16:32 +02:00
harden_memory_linux.py
add harden_memory_linux: harder for other processes to read our memory
2025-04-18 00:54:30 +00:00
i18n.py
logging: add "only_once=False" param to logger.info/warning/etc calls
2025-07-07 14:26:18 +00:00
interface.py
interface: PaddedRSTransport: keep in sync with e-x: flush on close
2025-10-27 18:09:33 +00:00
invoices.py
invoices: only skip generating BIP21 URI for payment request if both amount and message are empty.
2025-05-19 10:49:30 +02:00
json_db.py
wallet_db: add configvar for partial_writes, disable by default
2025-07-15 14:03:48 +00:00
keystore.py
tests: restore from old "hex" seed
2025-09-08 17:12:24 +00:00
lnaddr.py
lnaddr: fix outdated doc reference to lnworker._check_invoice
2025-05-02 15:57:01 +02:00
lnchannel.py
lnutil: make UpdateAddHtlc dataclass
2025-09-29 16:11:07 +00:00
lnhtlc.py
lnaddr: fix outdated doc reference to lnworker._check_invoice
2025-05-02 15:57:01 +02:00
lnmsg.py
lnmsg: support both primitive and complex types (subtypes) in LNSerializer.
2025-02-19 14:29:50 +01:00
lnonion.py
lnonion: (trivial) make OnionPacket.__init__ kw-only
2025-09-29 17:13:27 +00:00
lnpeer.py
lnpeer: move htlc forwarding funcs to lnworker
2025-09-30 09:54:24 +02:00
lnrater.py
fix: prevent lnrater from blocking if no good peers
2025-06-03 10:06:39 +02:00
lnrouter.py
Stop including all invoice r_tags in legacy trampoline onion
2025-04-14 19:20:11 +02:00
lnsweep.py
lnutil: rename RecvMPPResolution.ACCEPTED
2025-09-29 16:11:26 +00:00
lntransport.py
ci: enable more flake8 stuff
2025-04-02 16:21:59 +00:00
lnurl.py
lnurl: only sanitize untrusted LNURL errors
2025-08-27 17:36:51 +02:00
lnutil.py
lnworker: enforce creation of PaymentInfo for b11
2025-09-30 09:54:35 +02:00
lnverifier.py
interface: split request_chunk, based on "can_return_early" param
2025-07-15 22:53:35 +00:00
lnwatcher.py
adb: change API of util.TxMinedInfo: height() is now always SPV-ed
2025-09-24 13:46:24 +00:00
lnworker.py
lnworker: (trivial) add a few missing type-hints
2025-10-09 15:06:23 +00:00
logging.py
logging: add config.LOGS_MAX_TOTAL_SIZE_BYTES: to limit size on disk
2025-08-20 17:57:05 +00:00
lrucache.py
lrucache: add type hints
2025-08-08 14:34:53 +00:00
mnemonic.py
imports, whitespace, type hints
2025-04-23 16:09:31 +02:00
mpp_split.py
fix: suggest_splits exclude single channel splits
2025-05-20 17:34:48 +02:00
network.py
qt: fix ServerWidget
2025-10-27 18:46:36 +01:00
old_mnemonic.py
keystore: Old_KeyStore: change type of hex_seed to hex str
2025-07-18 00:42:09 +00:00
onion_message.py
Update electrum/onion_message.py _get_request_for_path_id return type
2025-02-20 17:17:14 +01:00
payment_identifier.py
lnurl: implement LNURL-withdraw
2025-08-27 15:31:43 +02:00
paymentrequest_pb2.py
…
paymentrequest.proto
chore: fix 404 status URL
2024-11-29 17:09:29 +08:00
paymentrequest.py
refactor(paymentrequest): use f-string in error message
2025-09-12 22:49:02 -07:00
pem.py
…
plot.py
change matplotlib backend from qt5agg to QtAgg
2025-06-10 16:14:04 +02:00
plugin.py
Update plugin.py
2025-09-13 23:12:44 -04:00
qrscanner.py
Consistently use translated strings for UserFacingException raises
2024-01-16 16:25:33 +01:00
ripemd.py
…
rsakey.py
…
segwit_addr.py
dependencies: remove bitstring
2024-04-24 14:14:31 +00:00
simple_config.py
logging: add config.LOGS_MAX_TOTAL_SIZE_BYTES: to limit size on disk
2025-08-20 17:57:05 +00:00
slip39.py
slip39: implement extendable backups
2024-05-20 16:57:11 +02:00
sql_db.py
…
storage.py
storage.write: make os_chmod best-effort
2025-09-05 19:51:33 +00:00
submarine_swaps.py
lnworker: enforce creation of PaymentInfo for b11
2025-09-30 09:54:35 +02:00
synchronizer.py
lnwatcher: add some type hints
2025-09-08 15:01:50 +00:00
trampoline.py
imports, whitespace, type hints
2025-04-23 16:09:31 +02:00
transaction.py
follow-up prev: add type-hints, etc
2025-10-09 14:57:41 +00:00
txbatcher.py
follow-up prev: add type-hints, etc
2025-10-09 14:57:41 +00:00
util.py
util: cleanup asyncio event loop after stopping
2025-10-28 14:53:35 +01:00
verifier.py
adb: change API of util.TxMinedInfo: height() is now always SPV-ed
2025-09-24 13:46:24 +00:00
version.py
prepare release 4.6.2
2025-08-24 18:03:20 +00:00
wallet_db.py
lnworker: enforce creation of PaymentInfo for b11
2025-09-30 09:54:35 +02:00
wallet.py
Merge pull request #10242 from f321x/return_preimage_cli
2025-10-09 15:31:04 +00:00
wizard.py
wizard: enable_keystore: fix for multisig
2025-08-15 20:52:49 +00:00
x509.py
imports, whitespace, type hints
2025-04-23 16:09:31 +02:00