AaronFiore/electrum
1
0
Fork 0
Code Activity
15,867 Commits 2 Branches 181 Tags
4872ec75ffe90287fac4cb1fe5c84898aa589fe3
Commit Graph

15867 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
ThomasV
b960433c60 confirm_tx_dialog: Use future tense in warnings + minor fix 2023-03-09 14:40:08 +01:00
ThomasV
c449c8eda8 set NoWrap for tx input/outputs. Use QTextBrowserWithDefaultSize in utxo dialog. 2023-03-09 11:26:40 +01:00
Sander van Grieken
f7a300b89b qml: successful PIN entry stays valid for 5 mins 2023-03-09 10:19:17 +01:00
Sander van Grieken
db467ff1f7 qml: remove not implemented new version check option in Preferences 2023-03-09 10:01:06 +01:00
ThomasV
37b29b1f37 confirm_tx_dialog: fix toggle_output_rounding 2023-03-08 18:44:29 +01:00
ThomasV
a244b508aa Confirm tx dialog: warn if tx has multiple change outputs 2023-03-08 17:52:15 +01:00
ThomasV
364510906f Fix edge case of batch_rbf, where we need to spend outputs from the base tx 2023-03-08 15:03:05 +01:00
SomberNight
dce0615b5d test_wallet_vertical: add a failing test for rbf-batching 2023-03-08 12:43:29 +01:00
ThomasV
3253e4904b Add rbf_merge_txid to PartialTransaction, instead of calling 
get_unconfirmed_base_tx_for_batching a second time from GUI.
 2023-03-08 12:38:41 +01:00
SomberNight
18cf546aab fix tests side-effecting each other in test_wallet_vertical.test_rbf 2023-03-07 19:07:44 +00:00
ThomasV
a5c7cc65ee make_unsigned_transaction: call get_unconfirmed_base_tx_for_batching lazily 2023-03-07 18:13:27 +01:00
ThomasV
0545edd4c6 confirm_tx_dialog: fix warning (follow-up previous commit) 2023-03-07 08:28:34 +01:00
ThomasV
74718e9085 confirm_tx_dialog: separate messages from warnings. add warnings about tx batching and spending unconfirmed coins 2023-03-06 19:25:46 +01:00
Sander van Grieken
b788f79509 qml: styling, padding various wizardcomponents 2023-03-06 18:05:54 +01:00
Sander van Grieken
9b0ff481b2 qml: txdetails feebump/cancel below mempool position 2023-03-06 18:05:20 +01:00
Sander van Grieken
00286254f9 qml: wizard button padding, wizardcomponent now a Pane 2023-03-06 16:47:19 +01:00
Sander van Grieken
461fcf2443 qml: wizard use flatbuttons 2023-03-06 16:02:08 +01:00
Sander van Grieken
a5485e5f68 android: use material dark style for splashscreen action bar 2023-03-06 12:03:25 +01:00
Sander van Grieken
ce5b6499fd qml: styling fixes 2023-03-06 11:43:32 +01:00
Sander van Grieken
d2883e19ac android: qt5 activity inhibit screenshots 2023-03-06 11:11:08 +01:00
ThomasV
2f6d60c715 Move transaction related settings into transaction editor. 
That way, users can see the effects settings directly on their transaction.
This changes the API of make_tx:
 - get_coins is called inside make_tx, so that inputs can be changed dynamically
 - make_tx takes an optional parameter: unconfirmed_only, passed to get_coins
 - ConfirmTxDialog detects if we can pay by disabling confirmed_only or lowering fee
 2023-03-05 10:17:03 +01:00
ThomasV
27ce9d88c3 follow-up 2ed71579c3: remove wrong assert 2023-03-04 09:04:50 +01:00
ThomasV
2ed71579c3 privacy analysis: detect address reuse 
add tx position to get_addr_io
 2023-03-04 08:53:49 +01:00
ThomasV
798cd607b5 Merge pull request #8230 from SomberNight/202302_osd_tx 
output script descriptors, part 1: change API of transaction.py
 2023-03-04 08:48:56 +01:00
SomberNight
a80bef8421 follow-up descriptor.py: small clean-up 2023-03-03 16:40:45 +00:00
SomberNight
e457bb50e9 trezor: TrezorPlugin._make_multisig to use MultisigDescriptor 
This fixes a regression where the plugin was assuming ordering for
txin.pubkeys (which is now a set).
(previously txin.pubkeys was a list ordered according to the final
sort order of keys inside the bitcoin script)
 2023-03-03 16:40:41 +00:00
SomberNight
31f457c242 wallet.get_script_desc_for_addr: use xpub instead of derived pubkey 
also put key origin info into descriptor, if available
 2023-03-03 16:40:38 +00:00
SomberNight
847b4fa4c4 descriptor.py: sortedmulti to sort .pubkeys already in __init__ 2023-03-03 16:40:35 +00:00
SomberNight
9127c12fa3 descriptor.py: do more validation in PubkeyProvider, and add tests 2023-03-03 16:40:32 +00:00
SomberNight
e7849bce94 descriptor.py: clean-up and test PubkeyProvider.get_full_derivation_* 2023-03-03 16:40:28 +00:00
SomberNight
a536658eef descriptor.py: fix get_satisfaction_progress 2023-03-03 16:40:25 +00:00
SomberNight
144aac4523 descriptors: add more sanity checks, and unit tests 2023-03-03 16:40:22 +00:00
SomberNight
93b9591f25 tests: add test_descriptor.py from bitcoin-core/HWI 2023-03-03 16:40:19 +00:00
SomberNight
36986a9881 transaction.py: set txio.{witness,redeem}|script based on descriptor 2023-03-03 16:40:15 +00:00
SomberNight
0647a2cf9f transaction.py: rm PartialTxInput.{num_sig, script_type} 2023-03-03 16:40:12 +00:00
SomberNight
ec889b8c3f wallet: fix import_requests, and mention quirk re preimages 2023-03-03 16:35:34 +00:00
SomberNight
81bd6f7d1b follow-up invoice changes: fix "Add lightning invoice to bitcoin URIs" 
follow-up 719b468eee
 2023-03-03 16:14:35 +00:00
SomberNight
9e81aba578 follow-up invoice changes: fix kivy RequestDialog 
follow-up 719b468eee
 2023-03-03 16:02:29 +00:00
SomberNight
ca0e4d21f1 follow-up invoice changes: fix kivy lightning_tx_dialog 
follow-up 719b468eee
 2023-03-03 16:02:26 +00:00
SomberNight
26cc1b8308 follow-up invoice changes: fix qt lightning_tx_dialog 
follow-up 719b468eee

Traceback (most recent call last):
  File "...\electrum\electrum\gui\qt\history_list.py", line 673, in mouseDoubleClickEvent
    self.parent.show_lightning_transaction(tx_item)
  File "...\electrum\electrum\gui\qt\main_window.py", line 1082, in show_lightning_transaction
    d = LightningTxDialog(self, tx_item)
  File "...\electrum\electrum\gui\qt\lightning_tx_dialog.py", line 60, in __init__
    self.invoice = invoice.lightning_invoice
AttributeError: 'Request' object has no attribute 'lightning_invoice'
 2023-03-03 16:02:22 +00:00
SomberNight
a1a1fae4cc invoices.py: small clean-up 2023-03-03 16:02:19 +00:00
SomberNight
b42b5c0c0f follow-up invoice changes: fix kivy ReceiveScreen 
follow-up 719b468eee
 2023-03-03 16:02:16 +00:00
SomberNight
5673f08750 follow-up invoice changes: fix wallet.get_bolt11_inv if amt is None 
follow-up 719b468eee

Traceback (most recent call last):
  File "...\electrum\electrum\gui\qt\request_list.py", line 111, in item_changed
    self.receive_tab.update_current_request()
  File "...\electrum\electrum\gui\qt\receive_tab.py", line 227, in update_current_request
    lnaddr = self.wallet.get_bolt11_invoice(req) if not help_texts.ln_is_error else ''
  File "...\electrum\electrum\wallet.py", line 2515, in get_bolt11_invoice
    amount_msat = req.amount_msat if req.amount_msat > 0 else None
TypeError: '>' not supported between instances of 'NoneType' and 'int'
 2023-03-03 16:02:12 +00:00
Sander van Grieken
8fe181d757 qml: sort languages 2023-03-03 15:50:42 +01:00
Sander van Grieken
ba888fc9fa qml: background flatbuttons within pages 2023-03-03 15:50:13 +01:00
Sander van Grieken
b16fb5088b qml: padding around label above TextHighlightPanes 2023-03-03 15:05:29 +01:00
Sander van Grieken
94fd0dcf10 qml: remove bolt11 invoice from qelnpaymentdetails/LightningPaymentDetails 2023-03-03 13:40:31 +01:00
Sander van Grieken
0f596cf2e9 qml: report unified password change failure, impose minimum password length of 5, disallow empty passwords 2023-03-03 12:56:02 +01:00
Sander van Grieken
90355a150f qml: fix exception handler register opened wallet 2023-03-03 12:26:36 +01:00
Sander van Grieken
72b07a3630 qml: don't initialize swaphelper if a non-lightning wallet is opened 
Due to swaphelper's lifecycle (it is kept around longer than the swap dialog) it might
get initialized with a non-lightning wallet. don't initialize in that case.

proper fix is to tie the lifecycle to the swap process, or make it a child of the wallet.
 2023-03-03 10:53:03 +01:00