AaronFiore/electrum
1
0
Fork 0
Code Activity

qt ConfirmTxDialog: don't catch BaseException for make_tx

Browse Source 
not sure what it is supposed to catch...
The examples I could come up with would all be actual bugs;
in which case we should let the exception propagate out to the crash reporter.
This commit is contained in:
SomberNight
2019-12-06 20:41:51 +01:00
parent a6aa97c3e3
commit e0eb3c18eb
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
electrum/gui/qt/confirm_tx_dialog.py
View File

@@ -99,11 +99,6 @@ class TxEditor:
self.tx = None self.tx = None
self.main_window.show_error(str(e)) self.main_window.show_error(str(e))
raise raise
except BaseException as e:
self.tx = None
self.main_window.logger.exception('')
self.show_message(str(e))
return
use_rbf = bool(self.config.get('use_rbf', True)) use_rbf = bool(self.config.get('use_rbf', True))
if use_rbf: if use_rbf:
self.tx.set_rbf(True) self.tx.set_rbf(True)