AaronFiore/electrum
1
0
Fork 0
Code Activity

Merge pull request #10203 from SomberNight/202509_plugin_offline_cmd

Browse Source 
commands: add clear error that plugin commands cannot be run with -o
This commit is contained in:
ThomasV
2025-09-08 17:17:45 +02:00
committed by GitHub
parent b036eaf3eb 7455cf9dec
commit dd7919b597
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
electrum/commands.py
View File

@@ -114,7 +114,7 @@ def format_satoshis(x: Union[float, int, Decimal, None]) -> Optional[str]:
class Command: class Command:
def __init__(self, func, name, s): def __init__(self, func, name, s):
self.name = name self.name = name
self.requires_network = 'n' in s self.requires_network = 'n' in s # better name would be "requires daemon"
self.requires_wallet = 'w' in s self.requires_wallet = 'w' in s
self.requires_password = 'p' in s self.requires_password = 'p' in s
self.requires_lightning = 'l' in s self.requires_lightning = 'l' in s
@@ -2198,6 +2198,9 @@ class Commands(Logger):
def plugin_command(s, plugin_name): def plugin_command(s, plugin_name):
"""Decorator to register a cli command inside a plugin. To be used within a commands.py file """Decorator to register a cli command inside a plugin. To be used within a commands.py file
in the plugins root.""" in the plugins root."""
# atm all plugin commands require a daemon, cannot be run in 'offline' mode:
if 'n' not in s:
s += 'n'
def decorator(func): def decorator(func):
assert len(plugin_name) > 0, "Plugin name must not be empty" assert len(plugin_name) > 0, "Plugin name must not be empty"
func.plugin_name = plugin_name func.plugin_name = plugin_name
@@ -2211,6 +2214,7 @@ def plugin_command(s, plugin_name):
async def func_wrapper(*args, **kwargs): async def func_wrapper(*args, **kwargs):
cmd_runner = args[0] # type: Commands cmd_runner = args[0] # type: Commands
daemon = cmd_runner.daemon daemon = cmd_runner.daemon
assert daemon is not None
kwargs['plugin'] = daemon._plugins.get_plugin(plugin_name) kwargs['plugin'] = daemon._plugins.get_plugin(plugin_name)
return await func(*args, **kwargs) return await func(*args, **kwargs)