From d9480fe33978f2b2f4ebcbd702e817acbde46173 Mon Sep 17 00:00:00 2001 From: SomberNight Date: Mon, 25 Aug 2025 12:22:37 +0000 Subject: [PATCH] contrib: add "set -e" to bash scripts where missing --- contrib/build-wine/sign.sh | 2 ++ contrib/build_tools_util.sh | 2 ++ contrib/generate_payreqpb2.sh | 2 ++ contrib/osx/notarize_app.sh | 1 + 4 files changed, 7 insertions(+) diff --git a/contrib/build-wine/sign.sh b/contrib/build-wine/sign.sh index ceeac8b7b..51cc24455 100755 --- a/contrib/build-wine/sign.sh +++ b/contrib/build-wine/sign.sh @@ -1,5 +1,7 @@ #!/bin/bash +set -e + here=$(dirname "$0") if [ -z "$WIN_SIGNING_PASSWORD" ]; then echo "password missing" diff --git a/contrib/build_tools_util.sh b/contrib/build_tools_util.sh index aab00efdd..3bc500480 100755 --- a/contrib/build_tools_util.sh +++ b/contrib/build_tools_util.sh @@ -1,5 +1,7 @@ #!/usr/bin/env bash +set -e + # Set a fixed umask as this leaks into docker containers umask 0022 diff --git a/contrib/generate_payreqpb2.sh b/contrib/generate_payreqpb2.sh index 87addbb36..959b24cba 100755 --- a/contrib/generate_payreqpb2.sh +++ b/contrib/generate_payreqpb2.sh @@ -1,6 +1,8 @@ #!/bin/bash # Generates the file paymentrequest_pb2.py +set -e + CONTRIB="$(dirname "$(readlink -e "$0")")" EL="$CONTRIB"/../electrum diff --git a/contrib/osx/notarize_app.sh b/contrib/osx/notarize_app.sh index 7a3f44b78..7e18c9562 100755 --- a/contrib/osx/notarize_app.sh +++ b/contrib/osx/notarize_app.sh @@ -1,6 +1,7 @@ #!/usr/bin/env bash # from https://github.com/metabrainz/picard/blob/e1354632d2db305b7a7624282701d34d73afa225/scripts/package/macos-notarize-app.sh +set -e if [ -z "$1" ]; then echo "Specify app bundle as first parameter"