qt payment requests: fix some races

closes #5283, #5407, #5121
2019-06-05 16:29:33 +02:00
parent 0ec574bcf8
commit d2de8de356
2 changed files with 15 additions and 6 deletions
--- a/electrum/paymentrequest.py
+++ b/electrum/paymentrequest.py
@@ -123,6 +123,7 @@ class PaymentRequest:
        return str(self.raw)

    def parse(self, r):
+        self.outputs = []
        if self.error:
            return
        self.id = bh2u(sha256(r)[0:16])
@@ -134,7 +135,6 @@ class PaymentRequest:
            return
        self.details = pb2.PaymentDetails()
        self.details.ParseFromString(self.data.serialized_payment_details)
-        self.outputs = []
        for o in self.details.outputs:
            type_, addr = transaction.get_address_from_output_script(o.script)
            if type_ != TYPE_ADDRESS: