AaronFiore/electrum
1
0
Fork 0
Code Activity

qt bump fee: rename "Final" checkbox to "Keep Replace-By-Fee enabled"

Browse Source 
Now that the checkbox is hidden behind an advanced option, there is
no need to be brief about it, better to be explicit.
(terminology unchanged for kivy.)
This commit is contained in:
SomberNight
2021-02-15 10:15:30 +01:00
parent 4c36c45664
commit d2019fd928
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
electrum/gui/qt/rbf_dialog.py
View File

@@ -115,20 +115,21 @@ class _BaseRBFDialog(WindowModalDialog):
vbox.addWidget(adv_widget)
def _add_advanced_options(self, adv_vbox: QVBoxLayout) -> None:
self.cb_is_final = QCheckBox(_('Final'))
adv_vbox.addWidget(self.cb_is_final)
self.cb_rbf = QCheckBox(_('Keep Replace-By-Fee enabled'))
self.cb_rbf.setChecked(True)
adv_vbox.addWidget(self.cb_rbf)
def run(self) -> None:
if not self.exec_():
return
is_final = self.cb_is_final.isChecked()
is_rbf = self.cb_rbf.isChecked()
new_fee_rate = self.feerate_e.get_amount()
try:
new_tx = self.rbf_func(new_fee_rate)
except Exception as e:
self.window.show_error(str(e))
return
new_tx.set_rbf(not is_final)
new_tx.set_rbf(is_rbf)
tx_label = self.wallet.get_label_for_txid(self.txid)
self.window.show_transaction(new_tx, tx_desc=tx_label)
# TODO maybe save tx_label as label for new tx??
@@ -163,8 +164,9 @@ class BumpFeeDialog(_BaseRBFDialog):
)
def _add_advanced_options(self, adv_vbox: QVBoxLayout) -> None:
self.cb_is_final = QCheckBox(_('Final'))
adv_vbox.addWidget(self.cb_is_final)
self.cb_rbf = QCheckBox(_('Keep Replace-By-Fee enabled'))
self.cb_rbf.setChecked(True)
adv_vbox.addWidget(self.cb_rbf)
self.strat_combo = QComboBox()
options = [