AaronFiore/electrum
1
0
Fork 0
Code Activity

qt confirm_tx_dialog: fix wallet.get_candidates_for_batching

Browse Source 
I don't understand what the "coins not used" comment meant here.
It was added in the change away from the old config.WALLET_BATCH_RBF option
(ab14c3e138).

The `coins` param *is used* in wallet.get_candidates_for_batching.
Without setting that, the returned set of candidates was restricted to
only base txs that had a large enough change output to cover *all* the newly added outputs.
Instead, it is desirable to allow adding new inputs.
This commit is contained in:
SomberNight
2025-09-05 19:17:23 +00:00
parent 969deb2cd9
commit d01e6b8101
3 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/test_wallet_vertical.py
View File

@@ -2162,7 +2162,7 @@ class TestWalletSending(ElectrumTestCase):
coins = wallet.get_spendable_coins(domain=None)
self.assertEqual(2, len(coins))
candidates = wallet.get_candidates_for_batching(outputs, coins)
candidates = wallet.get_candidates_for_batching(outputs, coins=coins)
self.assertEqual(candidates, [])
with self.assertRaises(NotEnoughFunds):
wallet.make_unsigned_transaction(coins=coins, outputs=outputs, fee_policy=FixedFeePolicy(1000), base_tx=toself_tx)