AaronFiore/electrum
1
0
Fork 0
Code Activity

lnpeer: ignore unknown 'odd' type messages

Browse Source 
from BOLT-01:
A receiving node:
  - upon receiving a message of odd, unknown type:
    - MUST ignore the received message.

b201efe054/01-messaging.md (lightning-message-format)
This commit is contained in:
SomberNight
2021-03-19 20:51:38 +01:00
parent d8352f1a0a
commit c912036180
3 changed files with 103 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
electrum/lnmsg.py
View File

@@ -9,9 +9,11 @@ from .lnutil import OnionFailureCodeMetaFlag
class FailedToParseMsg(Exception): pass
class MalformedMsg(FailedToParseMsg): pass
class UnknownMsgType(FailedToParseMsg): pass
class UnknownOptionalMsgType(UnknownMsgType): pass
class UnknownMandatoryMsgType(UnknownMsgType): pass
class MalformedMsg(FailedToParseMsg): pass
class UnknownMsgFieldType(MalformedMsg): pass
class UnexpectedEndOfStream(MalformedMsg): pass
class FieldEncodingNotMinimal(MalformedMsg): pass
@@ -479,7 +481,10 @@ class LNSerializer:
try:
scheme = self.msg_scheme_from_type[msg_type_bytes]
except KeyError:
raise UnknownMsgType(f"msg_type={msg_type_int}") # TODO even/odd type?
if msg_type_int % 2 == 0: # even types must be understood: "mandatory"
raise UnknownMandatoryMsgType(f"msg_type={msg_type_int}")
else: # odd types are ok not to understand: "optional"
raise UnknownOptionalMsgType(f"msg_type={msg_type_int}")
assert scheme[0][2] == msg_type_int
msg_type_name = scheme[0][1]
parsed = {}