AaronFiore/electrum
1
0
Fork 0
Code Activity

qml: use daemon threads

Browse Source 
Without this, if a user starts a lightning payment and quits the
app before the payment succeeds or fails, the app hangs indefinitely
and needs to be killed, because the future never returns.
This commit is contained in:
ThomasV
2023-03-16 10:18:11 +01:00
parent bcb06e5075
commit c5dc133c4c
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
electrum/gui/qml/qewallet.py
View File

@@ -530,7 +530,7 @@ class QEWallet(AuthMixin, QObject, QtEventListener):
def submitOtp(self, otp): def submitOtp(self, otp):
def submit_otp_task(): def submit_otp_task():
self._otp_on_submit(otp) self._otp_on_submit(otp)
threading.Thread(target=submit_otp_task).start() threading.Thread(target=submit_otp_task, daemon=True).start()
def broadcast(self, tx): def broadcast(self, tx):
assert tx.is_complete() assert tx.is_complete()
@@ -550,7 +550,7 @@ class QEWallet(AuthMixin, QObject, QtEventListener):
self.broadcastSucceeded.emit(tx.txid()) self.broadcastSucceeded.emit(tx.txid())
self.historyModel.requestRefresh.emit() # via qt thread self.historyModel.requestRefresh.emit() # via qt thread
threading.Thread(target=broadcast_thread).start() threading.Thread(target=broadcast_thread, daemon=True).start()
#TODO: properly catch server side errors, e.g. bad-txns-inputs-missingorspent #TODO: properly catch server side errors, e.g. bad-txns-inputs-missingorspent
@@ -576,7 +576,7 @@ class QEWallet(AuthMixin, QObject, QtEventListener):
except Exception as e: except Exception as e:
self.paymentFailed.emit(invoice.get_id(), repr(e)) self.paymentFailed.emit(invoice.get_id(), repr(e))
threading.Thread(target=pay_thread).start() threading.Thread(target=pay_thread, daemon=True).start()
def create_bitcoin_request(self, amount: int, message: str, expiration: int, *, ignore_gap: bool = False, reuse_address: bool = False) -> Optional[Tuple]: def create_bitcoin_request(self, amount: int, message: str, expiration: int, *, ignore_gap: bool = False, reuse_address: bool = False) -> Optional[Tuple]:
addr = self.wallet.get_unused_address() addr = self.wallet.get_unused_address()