AaronFiore/electrum
1
0
Fork 0
Code Activity

HardwareClientBase: provide default implementation for label

Browse Source 
and add warning about placeholders
This commit is contained in:
SomberNight
2020-04-08 18:28:21 +02:00
parent db1ff4915f
commit bf067f7558
3 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
electrum/plugins/digitalbitbox/digitalbitbox.py
View File

@@ -88,10 +88,6 @@ class DigitalBitbox_Client(HardwareClientBase):
pass pass
def label(self):
return " "
def is_pairable(self): def is_pairable(self):
return True return True

4
electrum/plugins/hw_wallet/plugin.py
View File

@@ -196,7 +196,9 @@ class HardwareClientBase:
and they are also used as a fallback to distinguish devices programmatically. and they are also used as a fallback to distinguish devices programmatically.
So ideally, different devices would have different labels. So ideally, different devices would have different labels.
""" """
raise NotImplementedError() # When returning a constant here (i.e. not implementing the method in the way
# it is supposed to work), make sure the return value is in electrum.plugin.PLACEHOLDER_HW_CLIENT_LABELS
return " "
def get_soft_device_id(self) -> Optional[str]: def get_soft_device_id(self) -> Optional[str]:
"""An id-like string that is used to distinguish devices programmatically. """An id-like string that is used to distinguish devices programmatically.

3
electrum/plugins/ledger/ledger.py
View File

@@ -80,9 +80,6 @@ class Ledger_Client(HardwareClientBase):
def is_initialized(self): def is_initialized(self):
return True return True
def label(self):
return ""
def get_soft_device_id(self): def get_soft_device_id(self):
if self._soft_device_id is None: if self._soft_device_id is None:
# modern ledger can provide xpub without user interaction # modern ledger can provide xpub without user interaction