AaronFiore/electrum
1
0
Fork 0
Code Activity

i18n: document not to use old-style (%) string formatting

Browse Source
This commit is contained in:
SomberNight
2023-01-10 14:06:29 +00:00
parent 63d801e363
commit b0e2e89395
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
electrum/i18n.py
View File

@@ -30,6 +30,11 @@ LOCALE_DIR = os.path.join(os.path.dirname(__file__), 'locale')
language = gettext.translation('electrum', LOCALE_DIR, fallback=True) language = gettext.translation('electrum', LOCALE_DIR, fallback=True)
# note: do not use old-style (%) formatting inside translations,
# as syntactically incorrectly translated strings would raise exceptions (see #3237).
# e.g. consider _("Connected to %d nodes.") % n
# >>> "Connecté aux noeuds" % n
# TypeError: not all arguments converted during string formatting
# note: f-strings cannot be translated! see https://stackoverflow.com/q/49797658 # note: f-strings cannot be translated! see https://stackoverflow.com/q/49797658
# So this does not work: _(f"My name: {name}") # So this does not work: _(f"My name: {name}")
# instead use .format: _("My name: {}").format(name) # instead use .format: _("My name: {}").format(name)