AaronFiore/electrum
1
0
Fork 0
Code Activity

Confirm tx dialog: warn if tx has multiple change outputs

Browse Source
This commit is contained in:
ThomasV
2023-03-08 17:52:15 +01:00
parent 364510906f
commit a244b508aa
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
electrum/gui/qt/confirm_tx_dialog.py
View File

@@ -569,6 +569,10 @@ class TxEditor(WindowModalDialog):
# warn if we merge from mempool # warn if we merge from mempool
if self.tx.rbf_merge_txid: if self.tx.rbf_merge_txid:
warnings.append(_('This payment was merged with another existing transaction.')) warnings.append(_('This payment was merged with another existing transaction.'))
# warn if we use multiple change outputs
num_change = sum(int(o.is_change) for o in self.tx.outputs())
if num_change > 1:
warnings.append(_('This transaction has {} change outputs.'.format(num_change)))
# TODO: warn if we send change back to input address # TODO: warn if we send change back to input address
self.warning = _('Warning') + ': ' + '\n'.join(warnings) if warnings else '' self.warning = _('Warning') + ': ' + '\n'.join(warnings) if warnings else ''