AaronFiore/electrum
1
0
Fork 0
Code Activity

Fix ledger sign message (#7004)

Browse Source 
there was an around ~1/128 chance of creating an invalid signature when signing a message with a ledger
This commit is contained in:
Gordan Nekić
2021-02-06 06:16:52 +01:00
committed by GitHub
parent 2bffc9d3eb
commit 9c4807644b
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
electrum/plugins/ledger/ledger.py
View File

@@ -334,7 +334,12 @@ class Ledger_KeyStore(Hardware_KeyStore):
if sLength == 33: if sLength == 33:
s = s[1:] s = s[1:]
# And convert it # And convert it
return bytes([27 + 4 + (signature[0] & 0x01)]) + r + s
# Pad r and s points with 0x00 bytes when the point is small to get valid signature.
r_padded = bytes([0x00]) * (32 - len(r)) + r
s_padded = bytes([0x00]) * (32 - len(s)) + s
return bytes([27 + 4 + (signature[0] & 0x01)]) + r_padded + s_padded
@runs_in_hwd_thread @runs_in_hwd_thread
@test_pin_unlocked @test_pin_unlocked